From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 05756A0471 for ; Wed, 19 Jun 2019 16:54:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C69C11C346; Wed, 19 Jun 2019 16:54:54 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40085.outbound.protection.outlook.com [40.107.4.85]) by dpdk.org (Postfix) with ESMTP id AB1FC1C335 for ; Wed, 19 Jun 2019 16:54:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C7tDMSh+/YY7diL6Q0l1XDuek507SwQ+Mg8cHwsg45U=; b=BKL4IEqh1p/g2QkXPqi3OJeqZZHjg1mpOBA7zkvLWsYggKJMfpcvpOZatyz77JvRkkJQJyPq6KPaSwQuS8EiIIblrrWnH/VMBqh/ysMMSbGmJC75B5kDONpSsY5f0yh8d1qlYwo/QdBDsHaKopXIeA6AJBLBXomh5/xI1W+a2+U= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6413.eurprd04.prod.outlook.com (20.179.232.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.12; Wed, 19 Jun 2019 14:54:52 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.1987.014; Wed, 19 Jun 2019 14:54:52 +0000 From: Akhil Goyal To: "Trahe, Fiona" , "Daly, Lee" , Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [PATCH] compress/isal: fix use after free Thread-Index: AQHVD+bvrltp9n3AaEeYO8Yp5B6Of6Z/KvKAgCQTBNA= Date: Wed, 19 Jun 2019 14:54:52 +0000 Message-ID: References: <20190521144713.12046-1-stephen@networkplumber.org> <348A99DA5F5B7549AA880327E580B43589773168@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B43589773168@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3996aa7f-e1bb-4362-936e-08d6f4c615d5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VE1PR04MB6413; x-ms-traffictypediagnostic: VE1PR04MB6413: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0073BFEF03 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(366004)(376002)(346002)(136003)(189003)(199004)(81156014)(33656002)(81166006)(8936002)(44832011)(316002)(66556008)(7736002)(64756008)(66446008)(26005)(76176011)(186003)(102836004)(9686003)(6506007)(6116002)(3846002)(11346002)(305945005)(76116006)(66946007)(66476007)(73956011)(4744005)(74316002)(14454004)(446003)(486006)(53936002)(110136005)(2906002)(4326008)(86362001)(476003)(5660300002)(55016002)(8676002)(66066001)(52536014)(478600001)(68736007)(6436002)(7696005)(99286004)(71200400001)(71190400001)(25786009)(6246003)(256004)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6413; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BLRC5lfiS7/RPIkgHMzpGmv0Tlef5i6K7eaRSNCzNYsdMsab9r9H5oIVBsmrDduO+hhQyVwe6GLPBOtgn8WtklHD6DQNCAgHMbVzQ5WGLXxKHZkT6QOEXhRd8ztTH3G9uy1B+LTte+wT7q1ShSpH1up7HTq2jtZTRwrgPD8gU7VNzmewalgPG6Medl48r6NXwOuxpvq8bySF1OdYFIfz7M2jwpnjDPs7m0t77v3N9YpHhJyW9U4QcTLbeoqWVRJyHH7bPwOo6H6ED652fRiYV0MLTQy7XUVF3UtUwCjuMOMilvwl686mZSAu/6et9RSuq0Qd4kbF/WPLJv1iCDbpC0atS6XkxoGahDLgDcRvsMYHRbF4ZrdhKcARQ/0hj1BAK9JVypjqFR7V6M/p3lxngg7pd7ELObLvBvIJLTuVCl8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3996aa7f-e1bb-4362-936e-08d6f4c615d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2019 14:54:52.5055 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6413 Subject: Re: [dpdk-dev] [PATCH] compress/isal: fix use after free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > The release function was using qp->stream after already releasing it = and the > > > null pointer checking was missing. > > > > > > Also since rte_free(NULL) is a no-op, remove unnecessary checks for N= ULL. > > > > > > Coverity issure: 340860 > > > Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functional= ity") > > > Signed-off-by: Stephen Hemminger > > > --- > Acked-by: Lee Daly > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks.