From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A08FA2EEB for ; Tue, 10 Sep 2019 13:39:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 378A01EE19; Tue, 10 Sep 2019 13:39:48 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130051.outbound.protection.outlook.com [40.107.13.51]) by dpdk.org (Postfix) with ESMTP id AAD6E4C8D for ; Tue, 10 Sep 2019 13:39:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMXSntn4N4RveJyr1A25JCoNDkmGrsMGohrog5inkDQj1eO0vUr9K78WYF+uLBQsrkqcy6xlyyilxeZX99mKMS77fNn0bV3hz/Gh8XanrTzKMrsgG8/a9O2SX6ey3wVB39G0xl2yZxlg4scde2KqZGQFWMHK7i1N3rc9lPd4cLUBTbt6xNVelR9o5NPA7m8oi0LS3v2HXnjc6jPdjkPnrJ+OoAtSwhzCD9Lp473SqFAiMaiQnj9+GuBICnFbVKWOWm7H4hl+ToklsFB2ErPF6a5YK/f4V3thC5wS1LbjcfINaHRKfklon50fywpePumBnVAMNK5e6urKn7jIVUyy5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uDY7hsmKsgiZ6I/0AfkMuNdrfMpMe4Cjsljmam+3L6I=; b=eBMLpf0QYtWMc4dhqqoLHFv17WSQA9nsL/JMZio3GC//ckjQCCWbliQrV6fWB+FyHl8aycDFNML+qsUVp45y26sb765wUVJzzo79YHeLst0qoCjCnChvwEzK20gRnJkxknLbBpgDsXx5jKGEOGgUtEFYM1ALYzg9R2+cbaoRfi62L0+292sTOHtixU9DHA8Wb6FIm2wOpwiP2FBU6fxHIuHChtK8UVfdJoe3HOduAzPGaWXY0tqdOrVUW86P4nCLuddqiAx37dPZJqNhULjd2+rhrK6W4gzosnhX4OV2M8D0wRxPq5LkKFqq1NkfSm05NewBPYbaaR//WPzVC50e/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uDY7hsmKsgiZ6I/0AfkMuNdrfMpMe4Cjsljmam+3L6I=; b=PVX++NDN+D6+3Pb3AjHUX97zmVHHmmrLEaeFAYtb5qzgq9L+Q7unTcLcha7HpvySSLIRvA8wD40uiujC6bEwSG70GVoTMtzUBP0pDQZml0liUv7wsUNpri0qRDp+ITxsGU5DNQ+RJC7V8VXKo9OJzyVuOFvxboslLNw50RejouU= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6525.eurprd04.prod.outlook.com (20.179.233.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Tue, 10 Sep 2019 11:39:45 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70%7]) with mapi id 15.20.2241.018; Tue, 10 Sep 2019 11:39:45 +0000 From: Akhil Goyal To: Anoob Joseph , Thomas Monjalon , Jerin Jacob Kollanukkaran CC: Pablo de Lara , Narayana Prasad Raju Athreya , Fiona Trahe , Kanaka Durga Kotamarthy , Shally Verma , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto asym support Thread-Index: AQHVZyMcS9S5UHehaUiefVNfEAutBKckTd6AgAAmToCAAFTAgIAAAFDw Date: Tue, 10 Sep 2019 11:39:45 +0000 Message-ID: References: <1568042799-25982-1-git-send-email-anoobj@marvell.com> <1568042799-25982-7-git-send-email-anoobj@marvell.com> <1573726.XVMC9ycaLO@xps> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd628de7-59f0-47a0-c88f-08d735e39431 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6525; x-ms-traffictypediagnostic: VE1PR04MB6525: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(136003)(376002)(39860400002)(396003)(13464003)(199004)(189003)(316002)(256004)(54906003)(6246003)(66946007)(2906002)(66476007)(9686003)(66446008)(44832011)(8936002)(486006)(55016002)(81166006)(81156014)(53936002)(7416002)(186003)(25786009)(476003)(99286004)(76116006)(4326008)(8676002)(53546011)(6506007)(102836004)(86362001)(6436002)(26005)(76176011)(74316002)(7736002)(52536014)(305945005)(478600001)(66556008)(64756008)(229853002)(7696005)(14444005)(71190400001)(71200400001)(11346002)(446003)(5660300002)(33656002)(3846002)(66066001)(6116002)(14454004)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6525; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: B+DYO1R+KBLybaS92hjsTUke5Rb9zBEDjegb8rRINuAXWOlhSBHexwovQo6P+hGhojouylnMKZU9qc5SFEZVfqgJ7CkY4m82yrk22Z5ZH0RBZfhKGdtKxpACfKlNWdaWh40MbfanyS14HCfb/6ab94XhGQ37rU4BlyZSsnQb8FWQiTt2ao7FggwAyxqGHznN+mx3lw6eIweGOf8345Fq5LiORWTP9xWakg5Mm+WiWZUcMRq9w37w5WA9QnB6CEDJDkeH1SPp28Xsl5QpmoUFQa9tXxXuGgGgV7jkkmQAGhNXFGk4npZHy06GmazMGM1xUN4KeQ9yhmZU0Ff3U6S1XmV92svNkZDlhVpbmgzaGMnaJKQvWjOQztUEPcWkEvWWXeofzyhwp5I1bcSm47H/+xRou/whixVlNfh/IVT0lSI= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd628de7-59f0-47a0-c88f-08d735e39431 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2019 11:39:45.4824 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6w1Cx+f6/2+zfs0neSwO/nmZLE4UEIhXeICTBQpuR16E6I8SKpSb6pC/elEJakP+SbmoY4GDCsqVvSMM1Bhpdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6525 Subject: Re: [dpdk-dev] [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto asym support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, >=20 > Hi Thomas, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Tuesday, September 10, 2019 12:00 PM > > To: Jerin Jacob Kollanukkaran ; Anoob Joseph > > > > Cc: Akhil Goyal ; Pablo de Lara > > ; Narayana Prasad Raju Athreya > > ; Fiona Trahe ; Kanaka > > Durga Kotamarthy ; Shally Verma > > ; Sunila Sahu ; dev@dpdk.org > > Subject: Re: [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto > > asym support > > > > 10/09/2019 06:13, Jerin Jacob Kollanukkaran: > > > From: Anoob Joseph > > > > Adding documentation for asymmetric features supported by > > > > crypto_octeontx2 PMD. > > > > > > > > Signed-off-by: Anoob Joseph > > > > Signed-off-by: Kanaka Durga Kotamarthy > > > > Signed-off-by: Sunila Sahu > > > > --- > > > > doc/guides/cryptodevs/features/octeontx2.ini | 9 +++++++++ > > > > doc/guides/cryptodevs/octeontx2.rst | 13 +++++++++++++ > > > > > > Please update the release notes. > > > > Please avoid doing a separate patch for documentation. > > It could be updated while adding the feature, in the same patch. >=20 > [Anoob] To which patch should I squash this change? Here are my options, >=20 > 1. The patch which adds ASYM in capabilities. Issue: the doc update updat= es > about autotest, which won't be available until the final patch is merged. > 2. Test patch which adds the autotest for the PMD. Issue: Additions to th= e doc > would be done by a patch which adds test. >=20 > Which one should I use? As per the convention followed these days, documentation should be the part= of the Patch which support it. If you have supported many features in your patchset, you should add that p= iece of documentation which is supported in each of the patches in the patchset. Release notes should be added in the patch which completes the whole featur= e. -Akhil