From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D377A046B for ; Thu, 27 Jun 2019 16:03:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B7402C4F; Thu, 27 Jun 2019 16:03:04 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40064.outbound.protection.outlook.com [40.107.4.64]) by dpdk.org (Postfix) with ESMTP id E17042BF7 for ; Thu, 27 Jun 2019 16:03:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JOGK7JJlmVejjpSeQcv2/VnAaVdhSj/8g3pHF4bHbBY=; b=aSaiZWbhVBRs2USvGDuva5eHWvW45a18uPxK9f9OpsoK/3uQFrBYknuKZbkJUpSwtgMUXNhELa2YGfIvMcoG5UkOshKHFkfGmfyBXeFssuinUW9Y0BLltOYg68CCjAvNnCYe+ewOEOCgV61Yy5IcL+swsVqvEUm5xSH/NLx8LuQ= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6606.eurprd04.prod.outlook.com (20.179.235.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Thu, 27 Jun 2019 14:03:02 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2008.014; Thu, 27 Jun 2019 14:03:02 +0000 From: Akhil Goyal To: Junxiao Shi , "dev@dpdk.org" CC: "pablo.de.lara.guarch@intel.com" , "Trahe, Fiona" , Shally Verma , "anoobj@marvell.com" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: free memzone when releasing cryptodev Thread-Index: AQHVFw4bIXRpvCx520u/MH3rz4kdh6avs48A Date: Thu, 27 Jun 2019 14:03:01 +0000 Message-ID: References: <201905301724.x4UHOJN7016223@lectura.cs.arizona.edu> In-Reply-To: <201905301724.x4UHOJN7016223@lectura.cs.arizona.edu> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2de1a44d-4c6a-47ac-2eb8-08d6fb082b25 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6606; x-ms-traffictypediagnostic: VE1PR04MB6606: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-forefront-prvs: 008184426E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(366004)(39860400002)(136003)(376002)(346002)(396003)(189003)(199004)(55016002)(305945005)(6436002)(44832011)(4326008)(54906003)(6116002)(3846002)(53936002)(25786009)(9686003)(66066001)(486006)(110136005)(229853002)(71190400001)(476003)(478600001)(2501003)(68736007)(71200400001)(5660300002)(66556008)(66946007)(256004)(11346002)(66476007)(7736002)(66446008)(446003)(64756008)(6506007)(81156014)(76176011)(4744005)(8676002)(7696005)(73956011)(76116006)(81166006)(99286004)(186003)(14454004)(33656002)(2906002)(102836004)(26005)(86362001)(6246003)(8936002)(52536014)(74316002)(316002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6606; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: yYoDd5JmQA4T2GmEpunaXDB7pgXlOTRwMb5Nq/e4dClbLkLRjlywufccycu51Fq11Si5YyccN+poEMbvZvcyDbA06FTwIfEPvk/XkEn+BG9aocZ1DOU0FQBf6FSVvkyDu6+1JWVVLl/vLCUlbKrUlTgXBVRQGhlAwS/eRdnQ+RbgolhgkdKde2vpV8r/DsQP2zG9NRC28oc2OdlHAv7Bz9BS2HzpO9k1bhTR5cQOuEqxu8GBft3oWIOvwJ9T36UHcYAr6Mr4fgDwduc42w6azFlqpFQH6+X+kv23E/rmuBgpe8O0BcoLBziJzF3PxO0jFMqzvquRaYl8cTuph6FO2F/NnWukRhgGd0u9p43J3tVoddsLyUCuuYJLytrhrKi+kMMjDI6URzqLqcEwKWv7K4GsZW7BtLqmSZx0XpFvsyM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2de1a44d-4c6a-47ac-2eb8-08d6fb082b25 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2019 14:03:02.0451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6606 Subject: Re: [dpdk-dev] [PATCH] cryptodev: free memzone when releasing cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > When a cryptodev is created in a primary process, > rte_cryptodev_data_alloc reserves a memzone. > However, this memzone was not released when the cryptodev > is uninitialized. After that, new cryptodev cannot be > created due to memzone name conflict. >=20 > This commit frees the memzone when a cryptodev is > uninitialized, fixing this bug. This approach is chosen > instead of keeping and reusing the old memzone, because > the new cryptodev could belong to a different NUMA socket. >=20 > Also, rte_cryptodev_data pointer is now properly recorded > in cryptodev_globals.data array. >=20 > Bugzilla ID: 105 >=20 > Signed-off-by: Junxiao Shi > --- Acked-by: Akhil Goyal