From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F888A2EFC for ; Mon, 16 Sep 2019 10:58:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 477021C0B4; Mon, 16 Sep 2019 10:58:02 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140085.outbound.protection.outlook.com [40.107.14.85]) by dpdk.org (Postfix) with ESMTP id AA6D71C029 for ; Mon, 16 Sep 2019 10:58:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S4+8ofOMSwSZGbq8SpSmnd0UswNWQe3IFQLXmksX7fs0J7+owX5Ddyi/iy8fX2y2CUeGdQ7t5aJBsjwLu3sGFDuIPYUzFlUdCNS/l18aZ6GUQGlH0IRcWQgX9ejkRcy9uB5fnTs73t8BY7B4NJ5/dJ9seOWq0f3tAdhDTg4UIGYrAIqsvju1ChDzMgmsNYP/4cHEtk3sGirtotwweNwUEDgessXxqBr3cLJo6topwX6zjVUVHfisnR5QSQZC5/nOmmYIE+nHtq9FIE90sFWI6i1GKp9lEu5dC2hO2HxHINAVGkMS2VzTQStV0LhFfLksuijN1iXPZdG2MkwJKNr39g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9dZUTBZjSKpTBY6mG+suTwItXw9FFsfzUc+oH4o8t2g=; b=gdrS7mDKIDJ8TWWBEUPHtRMbCGykzzOl9fXfM7NOeTXscEn0cyDlTX1py5Ty3ArETuEZB4fn/Tpqnrt1QRTE/6JwfO3E+onVQnZDQ6HzjXWj+AmoW/evT6cqsFAohVeoRb8NI3/F/vkSZxQf3ZDV9NzMjVCFv/zGkMuNIsphMgWsSZfb8eWCD/Py+uvnFK6+kIT752kBw0+otkcA/dmgVeowTQuOSxS4JNmIwl7bnPXrx2aYdCcjaxR4tYfhG5Akvl/aSyKnrSmqPNxC/qtnMKQNwmpD0r4/Pi3dVZuzsELIR/DtFrRtHK7WE7xnukGV2y0UcFMLq5vrSWnoeahpvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9dZUTBZjSKpTBY6mG+suTwItXw9FFsfzUc+oH4o8t2g=; b=PWkUXsDJmdYPHdqMKPjkCOAO+P+BefWLLpbv0Zj5kAYkP/2/JB4JiOE6NbwukY1qK467h9SXxdDGvffqiC/jECYDtkakYCkCn6+ExZ16B127+doyCrIbu/3h+IQuUfbqAPT/ZjZfaZncVhBzAyY8rs2YclQcZrcQNNRmC9FMYKA= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6462.eurprd04.prod.outlook.com (20.179.233.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.17; Mon, 16 Sep 2019 08:57:58 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70%7]) with mapi id 15.20.2263.023; Mon, 16 Sep 2019 08:57:58 +0000 From: Akhil Goyal To: Michael Shamis , "marko.kovacevic@intel.com" CC: "dev@dpdk.org" , Liron Himi Thread-Topic: [dpdk-dev] [PATCH 00/12] FIPS improvements Thread-Index: AQHVW+/tFRrYsR5vKkKKLrDGwa6Ew6cbVPeAgBFZHwCAAXLosA== Date: Mon, 16 Sep 2019 08:57:58 +0000 Message-ID: References: <20190826094120.22590-1-michaelsh@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.0.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a46a9cb-a452-46bd-e9c9-08d73a83f8e9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VE1PR04MB6462; x-ms-traffictypediagnostic: VE1PR04MB6462: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0162ACCC24 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(136003)(346002)(366004)(39860400002)(13464003)(43544003)(189003)(199004)(3846002)(86362001)(6436002)(6506007)(186003)(53546011)(26005)(8676002)(4326008)(76176011)(71200400001)(2501003)(256004)(14444005)(486006)(7696005)(446003)(11346002)(71190400001)(102836004)(25786009)(5660300002)(44832011)(74316002)(14454004)(7736002)(305945005)(476003)(478600001)(66446008)(33656002)(6246003)(76116006)(66946007)(6116002)(66066001)(66476007)(52536014)(81166006)(81156014)(2906002)(8936002)(99286004)(54906003)(55016002)(229853002)(53936002)(110136005)(316002)(9686003)(66556008)(64756008); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6462; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jIp9IShCFKMM2Z7e4OCAYGeVaXvmuux5933cDMTNSF5KbT+Xetrk1KUbajN9YT9qd/2NpWSrJ4mVubdicVqmqD23p6w/V9aCoPzgM5QelgUqRodPcaVj+idpAxUBBDtlNc7W+LmYdayvWRVTOeyBVAZ8hPfsKXG5U0CVTuj06mhJh63DDblAfhMTJXN1Lul1RRCSYHu3ljp1jHej7ZlseeefNgwOWNFFL0ujCxszX78iI6lT9BRKY/gPLrUHTIiFEGVy2uTrNlRHFwzT0c5ly+blgIGs9f+od4KbFMCBNEno73F20aYxzqKHiPQRAp2dhgQM49L9Wlla+Vg+wHyXL3SRVYi0kl/3qmwtPQELaSqmoD6vQDtGHtPItjTDsw5Std5m0E6aIpfEpW73GePxZapqXwMhMG5caT3igjKXiF0= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a46a9cb-a452-46bd-e9c9-08d73a83f8e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2019 08:57:58.5591 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1QZmJQTPw2ArSm3FO5UyqX17k/z7F7XOARnyOzKm0ChWjbOLlhVzh38YYT8iluZq9zsrXHpMac6hMYD7l0FB0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6462 Subject: Re: [dpdk-dev] [PATCH 00/12] FIPS improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, >=20 > I send 2 patch sets: one for new functionality support and another one fo= r fixes. > One patch was sent separately from both of the sets according to your > requirement: Ok will have a look. Thanks. >=20 > >> examples/fips: fix bad return code in fips_test_parse_header() > >examples/fips_validation: fix bad return value Can be a separate patch f= rom > this set. Also send to stable. >=20 > Please instruct me how to send the patches to stable. You just need to cc stable@dpdk.org and add this in the commit message as w= ell below the fixes line. You can check the git log for reference for the fixes. I will do this when I will apply the patch. You can take care of this in future. Thanks, Akhil >=20 > Thanks, > Michael >=20 > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, September 4, 2019 1:14 PM > To: Michael Shamis ; marko.kovacevic@intel.com > Cc: dev@dpdk.org; Liron Himi > Subject: [EXT] RE: [dpdk-dev] [PATCH 00/12] FIPS improvements >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Michael, >=20 > Please try to improve descriptions and patch titles as per the suggestion= s given > below. > There are many patches which are fixes. Are the eligible for backport to = stable > branches? > The support which is getting added, is it eligible for documentation upda= te for > the application. >=20 > -Akhil >=20 > > > > Added support for ECB mode in TDES and AES. > > Fixed some bugs in TDES and AES-GCM. > > > > Michael Shamis (12): > > examples/fips: added support for SHA algorithm in FIPS tests > examples/fips_validation: support SHA >=20 > > examples/fips: added support for TDES ECB mode in FIPS tests > examples/fips_validation: support TDES ECB >=20 > > examples/fips: added support AES ECB mode in FIPS tests > examples/fips_validation: support AES ECB >=20 > > examples/fips: fix bad return code in fips_test_parse_header() > examples/fips_validation: fix bad return value Can be a separate patch fr= om this > set. Also send to stable. >=20 > > examples/fips: AES-GCM vectors will use aead structure > examples/fips_validation: use AEAD based structs for AES-GCM rather it is= a fix > and should be sent to stable and the title would be > examples/fips_validation: fix structs used for AES-GCM >=20 > > examples/fips: set initial IV in AES-GCM if configured only salt > > value > examples/fips_validation: initialize IV for AES-GCM >=20 > > examples/fips: keep digest after crypto text > examples/fips_validation: move digest after cipher text >=20 > > examples/fips: AES-GCM decryption vectors fix > examples/fips_validation: fix AES-GCM decryption vector Add fixes line an= d cc > stable. Can be a separate patchset for fixes. >=20 > > examples/fips: fix KEY and PT output prints for TDES mode > Does not have a patch description and title does not look to justify the = patch. >=20 > > examples/fips: supported IV, PT and CT init for TDES ECB mode > Again there is no patch description and title is pretty long. Try to make= it short. >=20 > > examples/fips: algorithm definition by folder if it's not in file > examples/fips_validation: improve algo parsing logic update description t= ext to > elaborate the need for this logic >=20 > > examples/fips: erroneous overwrite of PLAINTEXT after DECRYPT > examples/fips_validation: fix plain text overwrite send to stable and add= fixes > line. >=20 > > > > examples/fips_validation/fips_validation.c | 92 ++++++-- > > examples/fips_validation/fips_validation.h | 7 + > > .../fips_validation/fips_validation_aes.c | 1 + > > .../fips_validation/fips_validation_gcm.c | 39 +++- > > .../fips_validation/fips_validation_tdes.c | 7 + > > examples/fips_validation/main.c | 204 +++++++++++++++--- > > 6 files changed, 301 insertions(+), 49 deletions(-) > > > > -- > > 2.23.0