From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00403A2E1B for ; Wed, 4 Sep 2019 11:51:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B6921EC0E; Wed, 4 Sep 2019 11:51:42 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60074.outbound.protection.outlook.com [40.107.6.74]) by dpdk.org (Postfix) with ESMTP id 983761C196 for ; Wed, 4 Sep 2019 11:51:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvdSRkkOaa20w00gcXdYaxkizG0pyjf2RkE2vlPQFI3J1RzZ+s/SBDNGLEDS36yh4i5ql0ohh4PuBNskQwifnvwwWQW8GAQFfBOCyKflIrWOt0PsUm7Sav05joh3sH0qTWZbwFjYBMFK/neRj0CzXE1qjs0DAgRHzJm5L+RMRKACte7KYjgI2STecHrmUummSfYkb7ztGXWQtGKHmrlgOf+ix1iU6DKEsJSiUydaBvNyFo8DVJo85T5S5zV7ZUTJGQ8WEEWefpx+edaXSF8CpYAasZ4M7VNd/mX694bbscy4UMf0dMoPu+klncra7sb0D9wEBgt4mRaSwB6TdrFrRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMFGvla7xiadstLo6zc0QQqAwwOh2LH3Jtsl3+s2SNs=; b=BDyurSFXOS9WWwlZLqFYX7CDTrgxtd/TAbYJ9tMtbrVjXTAmhCSpVVt0MYUnznL4imyPbA4MU/LwZ8W1/dsWbTRXQODe3MTBW1v8A+RIdLdt61nLPMztwZ14XMl5ZZK99Y1gTZOAzT4R54nvuqyO2UJzWBlWn0VsNjWqjRE1Xs1S2FphPA/8m7agOyyVcJKxiX0u+7d3/MpjuD9rc84tZC86r6TWE/edMASP5PTCVfnWgEnY/YfAhsHUp9HOGFJ+nfJSkOHn/3UgoVS18VPAPTCz3wK4hTy+3aL0V+tR29+EsKOClOVhs56szeG8/Vk7cLEb3LM8K86pEYiiwbPzPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PMFGvla7xiadstLo6zc0QQqAwwOh2LH3Jtsl3+s2SNs=; b=gKJZ4P1Sf4j/RhK/9dkD64LqSHXe72jmEA6HjsZB7/DR1mf7Z5DsoWrSLpgGmutDBCfDX0VkYwBDdnPc0dYBld4+OaurYMPc819vf/FFJf1KS1R4nxgjrzOXHwfXqzhzW8pjockpIh+mV+pELHMyJ0kbUfCdkUbQ9iqV5DsNnnI= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6447.eurprd04.prod.outlook.com (20.179.232.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Wed, 4 Sep 2019 09:51:39 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7092:d719:df0b:2b70%7]) with mapi id 15.20.2220.021; Wed, 4 Sep 2019 09:51:39 +0000 From: Akhil Goyal To: "michaelsh@marvell.com" , "marko.kovacevic@intel.com" CC: "dev@dpdk.org" , "lironh@marvell.com" Thread-Topic: [dpdk-dev] [PATCH 04/12] examples/fips: fix bad return code in fips_test_parse_header() Thread-Index: AQHVW/AHuM5aHTA7IUaUsKNWs95GMKcbU81w Date: Wed, 4 Sep 2019 09:51:39 +0000 Message-ID: References: <20190826094120.22590-1-michaelsh@marvell.com> <20190826094120.22590-5-michaelsh@marvell.com> In-Reply-To: <20190826094120.22590-5-michaelsh@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e58138b-65fd-4a8a-a169-08d7311d7baf x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6447; x-ms-traffictypediagnostic: VE1PR04MB6447: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-forefront-prvs: 0150F3F97D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(199004)(189003)(25786009)(33656002)(478600001)(26005)(14454004)(3846002)(6116002)(9686003)(102836004)(55016002)(53936002)(6246003)(4326008)(66066001)(76116006)(66476007)(66556008)(66446008)(66946007)(64756008)(186003)(6436002)(446003)(2501003)(71190400001)(71200400001)(316002)(110136005)(486006)(476003)(86362001)(44832011)(256004)(54906003)(2906002)(11346002)(52536014)(6506007)(5660300002)(7696005)(76176011)(99286004)(7736002)(305945005)(81156014)(81166006)(8936002)(74316002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6447; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YPeWlYkwG+/pimc47r8pxLEz5lxytr3RIulmY7dLgbdNL76A8K4SLrbWs4PuKRElfB6WW9TsUh8Z8ez5QV0VoqxCMeza5AAl1GATFDAZgjMv0chFRPB90G5rOHC0lZSBLtRjeh1nnGabMZTEbLrpjctIx+TUMUehzfPUyiwmysPJx0PY3YFlXnHGfWSDJ4r6oGaCl8pP3yS2MYMZ50l1p14+vG4+MrSsgpXpJ7M/7Aq651yxbACjOiGGfKicRHyn722eU/aowp9AHA3URDDN8KMEPZJ90TJ7gSUq7BLzdx8+ai+quql5YE9aZf3RWoaE+PSvRK3NntF6cWG6zUgbQpaf6ZOhkza0inhAdxahXMr4yg3JTD+rHJccjnP36UublEyY5ySrw08DmxDEEvDw6aGnP52TPe6ubo0cPjh95eU= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e58138b-65fd-4a8a-a169-08d7311d7baf X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2019 09:51:39.4175 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +VqSsWsMSG7KyGLj5hecQGftOm7RF2VvFIfD2hZMVTXWb1HHXH732dyFIeoLCs6Stgf5aNFis+ybGSxeApHg/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6447 Subject: Re: [dpdk-dev] [PATCH 04/12] examples/fips: fix bad return code in fips_test_parse_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Michael, Title should be " examples/fips_validation: fix bad return value " >=20 > Returning correct error value by fips_test_parse_header() > allows graceful exit of fips application. Please add a fixes line here and cc stable. It would be good if you can separate out the fixes from this patchset which= add some functionality. -Akhil >=20 > Signed-off-by: Michael Shamis > --- > examples/fips_validation/fips_validation.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation.c > b/examples/fips_validation/fips_validation.c > index fe3bcc386..91e6d48e7 100644 > --- a/examples/fips_validation/fips_validation.c > +++ b/examples/fips_validation/fips_validation.c > @@ -125,13 +125,13 @@ fips_test_parse_header(void) > info.algo =3D FIPS_TEST_ALGO_AES_CMAC; > ret =3D parse_test_cmac_init(); > if (ret < 0) > - return 0; > + return ret; > } else if (strstr(info.vec[i], "CCM")) { > algo_parsed =3D 1; > info.algo =3D FIPS_TEST_ALGO_AES_CCM; > ret =3D parse_test_ccm_init(); > if (ret < 0) > - return 0; > + return ret; > } else if (strstr(info.vec[i], "HMAC")) { > algo_parsed =3D 1; > info.algo =3D FIPS_TEST_ALGO_HMAC; > @@ -143,7 +143,7 @@ fips_test_parse_header(void) > info.algo =3D FIPS_TEST_ALGO_TDES; > ret =3D parse_test_tdes_init(); > if (ret < 0) > - return 0; > + return ret; > } else if (strstr(info.vec[i], "SHA-")) { > if (info.algo !=3D FIPS_TEST_ALGO_HMAC) { > algo_parsed =3D 1; > -- > 2.23.0