From: Phil Yang <Phil.Yang@arm.com>
To: Chenxu Di <chenxux.di@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "beilei.xing@intel.com" <beilei.xing@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>, nd <nd@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in flow query
Date: Tue, 14 Jul 2020 10:06:43 +0000 [thread overview]
Message-ID: <VE1PR08MB46400DDE83D080682B758C6CE9610@VE1PR08MB4640.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200714013721.50751-1-chenxux.di@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Chenxu Di
> Sent: Tuesday, July 14, 2020 9:37 AM
> To: dev@dpdk.org
> Cc: beilei.xing@intel.com; david.marchand@redhat.com;
> wenzhuo.lu@intel.com; Chenxu Di <chenxux.di@intel.com>
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in
> flow query
>
> This patch fix the error line break in the output format of flow query
>
> Fixes: bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
>
> Signed-off-by: Chenxu Di <chenxux.di@intel.com>
Tested-by: Phil Yang <phil.yang@arm.com>
> ---
> app/test-pmd/config.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index fcbe6b6f7..30bee3324 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1421,11 +1421,12 @@ rss_config_display(struct rte_flow_action_rss
> *rss_conf)
> }
>
> printf("RSS:\n"
> - " queues: ");
> + " queues:");
> if (rss_conf->queue_num == 0)
> - printf("none\n");
> + printf(" none");
> for (i = 0; i < rss_conf->queue_num; i++)
> - printf("%d\n", rss_conf->queue[i]);
> + printf(" %d", rss_conf->queue[i]);
> + printf("\n");
>
> printf(" function: ");
> switch (rss_conf->func) {
> --
> 2.17.1
next prev parent reply other threads:[~2020-07-14 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 6:28 [dpdk-dev] [PATCH] app/testpmd: fix display issue " Chenxu Di
2020-07-13 8:16 ` David Marchand
2020-07-13 8:23 ` Di, ChenxuX
2020-07-14 1:37 ` [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format " Chenxu Di
2020-07-14 10:06 ` Phil Yang [this message]
2020-07-14 11:38 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB46400DDE83D080682B758C6CE9610@VE1PR08MB4640.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=beilei.xing@intel.com \
--cc=chenxux.di@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).