Re: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode

[Phil Yang <Phil.Yang@arm.com>]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jasvinder Singh
> Sent: Monday, June 22, 2020 11:51 PM
> To: dev@dpdk.org
> Cc: cristian.dumitrescu@intel.com
> Subject: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode
>
> Softnic can be used like other virtual devices without
> needing any special mode. Therefore, softnic forward mode
> is removed from testpmd app. Documentation is updated as
> well.
>
Hi Jasvinder,

One quick question for this change.  How can we test the softnic PMD without this mode?
The softnic PMD guidance uses testpmd softnic mode in the PMD test section.
However, when I switch the forward mode from softnic to IO mode, the testpmd cannot work as expected.

I think you need to update the softnic PMD page as well.
doc/guides/nics/softnic.rst

Thanks,
Phil

> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
>  app/test-pmd/Makefile                       |   4 -
>  app/test-pmd/cmdline.c                      |  82 ---
>  app/test-pmd/config.c                       |  56 --
>  app/test-pmd/meson.build                    |   4 -
>  app/test-pmd/softnicfwd.c                   | 686 --------------------
>  app/test-pmd/testpmd.c                      |  16 -
>  app/test-pmd/testpmd.h                      |  22 -
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  10 -
>  8 files changed, 880 deletions(-)
>  delete mode 100644 app/test-pmd/softnicfwd.c
<snip>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.