From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B6E2A00BE; Wed, 8 Jul 2020 07:20:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9C911DE59; Wed, 8 Jul 2020 07:20:15 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2065.outbound.protection.outlook.com [40.107.21.65]) by dpdk.org (Postfix) with ESMTP id DEEF61DE0B; Wed, 8 Jul 2020 07:20:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P1SkBjDdZxtbR4e2J0/DOy8m6NEfCts5Nj2HBJnT1XY=; b=ufhmLv0OjgZN8myBxTQCqN6DJ8hhBVDMbQIkLbKLsv4sdQ2ate9cKtvHpBcM6jMUR8W6l8/bGZShcKmLCIQJa8SzCJTYSXYfPTuHa0geWmGintmkYDDOj5MxNmKCG4ri6sSt+jpewpI9gvA+tYfL2fBFLrGaNHRSuEbzACl8K08= Received: from AM5PR1001CA0063.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::40) by DB7PR08MB4603.eurprd08.prod.outlook.com (2603:10a6:10:75::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Wed, 8 Jul 2020 05:20:13 +0000 Received: from VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::c5) by AM5PR1001CA0063.outlook.office365.com (2603:10a6:206:15::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Wed, 8 Jul 2020 05:20:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT060.mail.protection.outlook.com (10.152.19.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Wed, 8 Jul 2020 05:20:12 +0000 Received: ("Tessian outbound e44de778b77e:v62"); Wed, 08 Jul 2020 05:20:12 +0000 X-CR-MTA-TID: 64aa7808 Received: from 6401a4987156.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B5D3AD48-E4D5-4945-B850-49E83570D0AC.1; Wed, 08 Jul 2020 05:20:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6401a4987156.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Jul 2020 05:20:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FuaX9QArUxMHopAOs9RIb+1OftP1DPu6qcWVkSqCgh2u5tRCLpc57Y+Q6j6t2Ki6jvWoOMZCKDU6AUFD6LiZ4vyGmhzskk6npkT+iZv48qfaH+EpNG0SG55yny0C4ba4XLW7DzVtqYXKgayitv2Xh5ckYiCH8/yd8Gt8AoW4kbiScUpbAa3sUO66IxYon527nO3RetrNFUPULEZjkvOejTsiswEvTaTz3MLnIzV6ErAKiP8/ZptJ2YFJtFR6qhmtvUD1dQj1O6EPO6ueAEahrTqM/ttCOWoAo4c5CxV2S429JffRcA5wOwVDDX6yQ7Khy45jK76dnQmNvijuBHYZRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P1SkBjDdZxtbR4e2J0/DOy8m6NEfCts5Nj2HBJnT1XY=; b=ercp1c5CuoN3dAU0MEVmQWyR1UPAqUbV3lT03LbpinIrY25zP4K2kTHAFbZjwJI0PpBKolLQ7dUP9A1HJ032/7VfEgSdXesUgLfh/coxeWZoWnfQcywLc+JCWejpk+azj1FnoDqTpqRfJB6QpuULK5HXJZpjdMAymEE+gzm0SPK6IythhQrBvX4AGu1aXi6z2+zfBhS7azLoA4udQ5tGHTFuqo9OL9c3ZyBGjM4MYPlsS2J8p0fvRw/cinq3xoePNYP3vNbwkWuprfCjNANODgNystAb7G/MSDjK++lU7cIfGRWTBTbS1bFx5ZsDg+B/U26rAEULM9bgm2XdwDHF5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P1SkBjDdZxtbR4e2J0/DOy8m6NEfCts5Nj2HBJnT1XY=; b=ufhmLv0OjgZN8myBxTQCqN6DJ8hhBVDMbQIkLbKLsv4sdQ2ate9cKtvHpBcM6jMUR8W6l8/bGZShcKmLCIQJa8SzCJTYSXYfPTuHa0geWmGintmkYDDOj5MxNmKCG4ri6sSt+jpewpI9gvA+tYfL2fBFLrGaNHRSuEbzACl8K08= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VI1PR0801MB1775.eurprd08.prod.outlook.com (2603:10a6:800:57::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Wed, 8 Jul 2020 05:20:03 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3153.029; Wed, 8 Jul 2020 05:20:03 +0000 From: Phil Yang To: Honnappa Nagarahalli , "dev@dpdk.org" CC: "drc@linux.vnet.ibm.com" , Ruifeng Wang , nd , "shahafs@mellanox.com" , "stable@dpdk.org" , nd Thread-Topic: [PATCH 1/2] eal: remove redundant code Thread-Index: AQHWVOa3VZbPGXt9uEyvjYl4FZ1jHaj9JOvA Date: Wed, 8 Jul 2020 05:20:03 +0000 Message-ID: References: <1591871065-12461-1-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 91605977-fdcc-4d6c-b3f2-4b00fac041a0.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d110e3c6-a6a5-4036-6842-08d822fe974b x-ms-traffictypediagnostic: VI1PR0801MB1775:|DB7PR08MB4603: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4941;OLM:4941; x-forefront-prvs: 04583CED1A X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: l826v9q0gNQsNv2Epi8/oUGspVFXkTAXuYkblze6FP9MVaeZzU+8d70j0/NUXQToqgcxshrcEViCB8U2CDrUDK1yx6pL8yThSltnUfozN/1SB4+PziouFvhzpA4prIUQZ7Eb4VNhns4LYFnG5kbQd8IAAuLU75LYah4I9pKHCDG5KSiW6dwQeC77qwa8TfbhvVrIBucBf45cyTX/N0JZAzGXMEXsFjKc8LN5Uh9orGfmnutLaMDhjC2Rr8hLISm92E1KmRtxOv6FcW2KX9ouGJskNNwpcpMa0ol7H6vviKUK2Yq725vRslzYy+f7nd4D X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39850400004)(136003)(366004)(346002)(396003)(8676002)(83380400001)(8936002)(4326008)(5660300002)(52536014)(55016002)(316002)(110136005)(9686003)(53546011)(186003)(7696005)(54906003)(6506007)(33656002)(71200400001)(86362001)(478600001)(26005)(76116006)(2906002)(66446008)(64756008)(66556008)(66946007)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: dZnHbq7IoK/f1dZEkHtL1hMq8gBwIWivsaESeMePhqkaRmuDTfjrMoNYfz1PVKnd4rFnl6dbXFJ8LWt5km9ytZ/83mVPkq0gzMTZuRStO6KqmL6Y/46AjQYdO6Hy+o+7jI5gz+ReI5MO98hPRZAGqNPuAuNAItd2KAkcMqlmTrLapAcxXIVGpZiGdRHj1hi/wQ2XJSFbWL2T2y0Je6IPUfZyYFYi6i1YtRuPRvVyp0Qs+TmddEykU1Be+8hS5/bnFtFyyeIZWqTrPfQmF0ZpNkIS0X9dLPp1VeMb9zkK+uVsWBQcsXijrQCe/SIu7Pl7LQQ961ssW4XNXrIwfCAfWBR1zwx4ICc1bqJOgcjrjMfGKdZgybDgF9TGov6XR8egaPpX7M/PaL03RVd2BdJzl06F8nhNeTdElci4mV6JnYHA8Y5tRcpoOwLSr1EBS22+8BJ54nPUZChZJOlSV6Zl0z4LyHLtUpySjrtbPK2mBdlDQhqPAv32yaQjMrMfXPN7 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1775 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39850400004)(396003)(346002)(136003)(46966005)(70206006)(336012)(9686003)(83380400001)(478600001)(8676002)(2906002)(54906003)(47076004)(110136005)(33656002)(5660300002)(450100002)(55016002)(186003)(82740400003)(6506007)(53546011)(356005)(86362001)(7696005)(70586007)(4326008)(82310400002)(81166007)(52536014)(8936002)(36906005)(26005)(316002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: a7f0c42b-0049-4843-f3c3-08d822fe91c7 X-Forefront-PRVS: 04583CED1A X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FJhj4sIi3l2jq/k9G72NujZndWsz3SNjPxyizdOFJM2bTNx7ENJlqg4iSkYj0lIRSte9oiGwRkyWWQMgP3B2ti7+Zv17c5nWnbpRe9Z+9q6aiJzpV/gTN5spP+qLoury0Wdz/6dAnE+n3cU6I/WRODmUfSYTuIyX2DJ8g+XiLkahZCNH15sAEa9eMcECKROIi6An65um5o8uLMBiPjq/GZvvQZCnMusBNd89NNEg4XVtIDMAXyoGK7vtX6iLWWKRLooLEYVxJpRCmdfcfUi11WMkfdtGFeg2tYP3MnSgfoZSq1/VbZvSaC4lJjSmhdVzharbq/E6dXeQy44tKt0Mcmupt047jvi77P3xxjqTXyh0qDxbjyauaj9OWjY/UzoFGx27G5JyCjSQbPTupCanwg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2020 05:20:12.6714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d110e3c6-a6a5-4036-6842-08d822fe974b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4603 Subject: Re: [dpdk-dev] [PATCH 1/2] eal: remove redundant code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Wednesday, July 8, 2020 1:15 PM > To: Phil Yang ; dev@dpdk.org > Cc: drc@linux.vnet.ibm.com; Ruifeng Wang ; nd > ; shahafs@mellanox.com; stable@dpdk.org; Honnappa > Nagarahalli ; nd > Subject: RE: [PATCH 1/2] eal: remove redundant code >=20 > >=20 > > Subject: [PATCH 1/2] eal: remove redundant code > > > > The event status has been cleaned up by the CAS operation when we free > > the event data, so there is no need to set it to invalid after that. > > > > Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt") > > Cc: shahafs@mellanox.com > > Cc: stable@dpdk.org > This is not a bug fix. I think it is not worth backporting, suggest remov= ing this. OK. >=20 > > > > Signed-off-by: Phil Yang > > Reviewed-by: Ruifeng Wang > Otherwise >=20 > Reviewed-by: Honnappa Nagarahalli >=20 > > --- > > lib/librte_eal/linux/eal_interrupts.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > b/lib/librte_eal/linux/eal_interrupts.c > > index 16e7a7d..2f369dc 100644 > > --- a/lib/librte_eal/linux/eal_interrupts.c > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle > > *intr_handle) > > if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) { > > /* force free if the entry valid */ > > eal_epoll_data_safe_free(rev); > > - rev->status =3D RTE_EPOLL_INVALID; > > } > > } > > } > > -- > > 2.7.4