From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 050E7A0528; Fri, 17 Jul 2020 06:48:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93A381BED0; Fri, 17 Jul 2020 06:48:19 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060.outbound.protection.outlook.com [40.107.20.60]) by dpdk.org (Postfix) with ESMTP id 586A01BEBC for ; Fri, 17 Jul 2020 06:48:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQ6vQphwQW6Mz8r2+VLhUsBXAJNAVxhMo8TOe1Y9ens=; b=zgOTBw5YlJNdnK9ebn4Ux7MjsNlFW3fINaG/zsm6XmNO6YP46f4I3mGDYYxD5lz2JaqqAKd0iTzvnKwFQboTa46itlPzm6ZMNX4jSWSdClL50MbniPsaaH896455VLzVwTNzTFcyVtHZy7KAvOn+RvA7raLlN1xoTPISQG7ApHI= Received: from DB3PR06CA0012.eurprd06.prod.outlook.com (2603:10a6:8:1::25) by DB6PR0801MB1832.eurprd08.prod.outlook.com (2603:10a6:4:3c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Fri, 17 Jul 2020 04:48:15 +0000 Received: from DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::56) by DB3PR06CA0012.outlook.office365.com (2603:10a6:8:1::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend Transport; Fri, 17 Jul 2020 04:48:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT047.mail.protection.outlook.com (10.152.21.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Fri, 17 Jul 2020 04:48:15 +0000 Received: ("Tessian outbound 7de93d801f24:v62"); Fri, 17 Jul 2020 04:48:15 +0000 X-CR-MTA-TID: 64aa7808 Received: from e9f06e0c4e7a.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2309D358-A383-46D6-AED6-00CCA1EEF561.1; Fri, 17 Jul 2020 04:48:10 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e9f06e0c4e7a.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Jul 2020 04:48:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mCj3rr4y5by1hEK2CEOcVBBHOHtlOQTERO0CHKSULni+35EZM7AntJnmc24KjoF/yj3RO1pbDCozFbcO68UPsYjxL+wwxd9eYZxTHHzLVKj7CMHLgtM+x0VfxUafaPHFrdGU9+D6hAUAN8YbdaipRu9bPKrg5D8RcQ+ur27PqrE7p7dl/CH+068FRbwvn2OKoTy0YYwd+T67JjH4iWbUt0mWvmcOhjgVbbbk+GIl+Pr/Q/jTAqE3RPu1AGJJBQdOMBV892KBk+66UbB+Z9iRr90V7UzDrnI9vbbIZxHyjnusKyLgiIUwTeh1Rnfmqpz7+I85sV1DnSbNFdrZeOWeFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQ6vQphwQW6Mz8r2+VLhUsBXAJNAVxhMo8TOe1Y9ens=; b=HkzQFQCSlf8ss4QucuJqnY7tPymkxhZa27tw+tY9FdLF5lbTyxQh5UJCW/M4rTnDR/9AIFaxDq8tHnXU2iFZbgMFlsYwRkmALzPPK37bFh8oWnIcEq/y4YkH1M0u1g4lvo6VHwigGDIaPtcstiyzOI140KSvVoHPNsqO+O4+oZq+MpqagnSNWrd3Tz3zjZbC0kUuuaAPTVJi72UwlOUE9O6iuO7dEZFbxr8MsLGQVjtb+NqvyKKC2ZsrUooOYAfRd/Ngr//EwoV9W6J0sO/juNtssSZYBTwJ3nk5ZAuV09269vCpebj7FSwO2VJkbkv7gFW+JhziKOPoUCIICSFI5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQ6vQphwQW6Mz8r2+VLhUsBXAJNAVxhMo8TOe1Y9ens=; b=zgOTBw5YlJNdnK9ebn4Ux7MjsNlFW3fINaG/zsm6XmNO6YP46f4I3mGDYYxD5lz2JaqqAKd0iTzvnKwFQboTa46itlPzm6ZMNX4jSWSdClL50MbniPsaaH896455VLzVwTNzTFcyVtHZy7KAvOn+RvA7raLlN1xoTPISQG7ApHI= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VI1PR0802MB2288.eurprd08.prod.outlook.com (2603:10a6:800:a6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Fri, 17 Jul 2020 04:48:07 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 04:48:07 +0000 From: Phil Yang To: Honnappa Nagarahalli , "thomas@monjalon.net" CC: "dev@dpdk.org" , "Mcnamara, John" , David Christensen , dev , "jerinj@marvell.com" , "Ananyev, Konstantin" , Ola Liljedahl , Bruce Richardson , Ruifeng Wang , nd , David Marchand , nd , nd , nd Thread-Topic: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches Thread-Index: AQHWW17JhtEN78yYH0WNHExzcO0TKKkKEpgAgABCV2CAABSQAIAABJ2AgADFT4A= Date: Fri, 17 Jul 2020 04:48:07 +0000 Message-ID: References: <1594621423-14796-1-git-send-email-phil.yang@arm.com> <3325015.uBoaBXitGU@thomas> <4777511.sDcrFEcvGN@thomas> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2c271da8-404b-482d-89b8-8b9da807fa44.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.111] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 024ed913-565a-4403-5758-08d82a0c9e52 x-ms-traffictypediagnostic: VI1PR0802MB2288:|DB6PR0801MB1832: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: irtMUmfcGYsdLKl2wkJI3ygf6PoHXkCtquw+wVD0/nyuawdaho1J0C+hoZp0KlSFRbcs/L3YnGVBD0gzv8qkAKYs6Qf4+fbc/GbCWVDBL/FYONbxFSXDBVzdzxwq2wu0cAulFXuTHk5lw5PJcGICKOj9kU5pUzCOTANQIaKczenWf/OtTa3Z1aKTWbiB72YUZyFxlXW93sD0Hls9OL4R6RkhtUi53Akik1HeHNG306P64yPGmCunJskN/zel/pJOKCfqafgh/sQ4zDyQK/lg350EaugKrjVQjKmeEk0jduAtep6Ea2I6RupHCs5BW81n X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(136003)(376002)(366004)(39860400002)(396003)(52536014)(83380400001)(110136005)(478600001)(55016002)(86362001)(66446008)(66556008)(5660300002)(66946007)(71200400001)(76116006)(54906003)(66476007)(9686003)(2906002)(64756008)(26005)(6506007)(8936002)(53546011)(4326008)(7696005)(186003)(8676002)(316002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 4HebWCLsnrvx1EG0HgHoAc3aomTsACjO8FY+07yLA8qTkGIJXsp50k1yEAgnB7zNaetBZDQzarA08UABo3v8vBpq1bv52V6CNSFSNmTr8/iZnfi9jR8zyStxSZnUG1x+fknxvJKdGHDoPgKOcLyTEgZ53NyYAvNCCoN2hV8dHaKtq1s3TB55vWtkzSGUqirMynZlikknZb+/xujo0l2vwO8AQqbnRVXVN0lbiQjHvOwgrt9YaHn8sSHvORYIyUAOpiIbafsrxAhIDN7gyHXDuRq+pJzieEy/VHqMlCZcFJZ/sCDFXqW3q1qd9WEKYE+SrUpJHLcj5bjPF7PuMhVi/e1YKFJ8r+ILG0IAlz2pUtU1lN19ZXeLlFzl77NhVUzbtzchAK896dyAPGgya3Fbae/aPAmUPsdfnpTnPIRAV9bMBb1Sc1adQOy1oIseJ2Q/oqA7l+mgHAms8nB8a0aFmyph6aOd9ke1miflXnJxefY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2288 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(376002)(39860400002)(136003)(46966005)(81166007)(83380400001)(336012)(7696005)(6506007)(186003)(26005)(47076004)(2906002)(52536014)(86362001)(5660300002)(82740400003)(33656002)(110136005)(316002)(356005)(82310400002)(53546011)(478600001)(70206006)(9686003)(8936002)(8676002)(54906003)(70586007)(4326008)(55016002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: f3b040b7-938a-4d8c-3d11-08d82a0c9977 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xxs4mjNYKbAUTxMVgMpB0lAc05u6ceO3MP6oMcKKx3yk/YmPaHw/w0WZZviOcRCSOhwpkqvuwA200mxjcVsChZquadNM9KOR/jMWh5km0X/HqZY7m9/WSVsqz95QpgVf/nIwzAJwZUbOV+a9xyJ1YRDtVhXZSjy8i97ZXqB0W4WBj+6lPTW6+eaLiUzGr/4VWOB8bH65wR8yBjvnhLNClCl/CGVqE6X9idbrzYl3moQF2LYM/B/Ee8lFmta6JVvVnDu4810yRVwB8Ye5pAfbSz15sIUQtB4Uv11tmmoGxdO1mr0Mwa5Tv5ng9tHvmiTEqD9U02iE8pMGh2Bonm2luc2kL8PNUtwqrkpSbW713bxRzo+I8aMo69NTor1oUcERK7xnFwOL/PgJC/z43PywGA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 04:48:15.7025 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 024ed913-565a-4403-5758-08d82a0c9e52 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1832 Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Honnappa Nagarahalli writes: >=20 > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte > > > > atomic APIs in future patches > > > > > > > > 16/07/2020 12:48, David Marchand: > > > > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wro= te: > > > > > > check_forbidden_additions() { # > > > > > > res=3D0 > > > > > > + c11_atomics_dir=3D"lib/librte_distributor lib/librte_ha= sh > > lib/librte_kni > > > > > > + lib/librte_lpm lib/librte_rcu lib/libr= te_ring > > > > > > + lib/librte_stack lib/librte_vhost > > > > > > + drivers/event/octeontx drivers/event/o= cteontx2 > > > > > > + drivers/event/opdl drivers/net/bnx2x > drivers/net/hinic > > > > > > + drivers/net/hns3 drivers/net/memif > > drivers/net/thunderx > > > > > > + drivers/net/virtio examples/l2fwd-even= t" > > > > > > > > > > I prefer a form like: > > > > > > > > > > + c11_atomics_dir=3D"" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/octeontx" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/octeontx2" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/opdl" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/bnx2x" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/hinic" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/hns3" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/memif" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/thunderx" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/virtio" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir examples/l2fwd-event" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_distributor" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_hash" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_kni" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_lpm" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_rcu" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_ring" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_stack" > > > > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_vhost" > > > > > > > > > > Easier to read and update. > > > > > > > > Why do we need this list at all? > > > > Are we allowed to add new code with old atomics in other > > > > directories? > > > > How bad it is to have a warning on non-converted libs? > > > > > > From my perspective, the pros of this list are : > > > 1. Avoid introducing false warnings in non-converted modules. Otherwi= se, > > the maintainers have to wonder if that module is converted or not. > > > > Don't we want to convert all libs? > The goal is to convert all the libs. >=20 > > If we are adding one more rte_atomic in a lib, we should ask the questi= on > > why not converting to C11, no? > Agree, I am fine with this approach. That will kind of distribute the con= version > work as well. Will do in V9. Thanks, Phil >=20 > > > > > 2. Keep non-converted modules compatible. C11 atomic builtins cannot > be > > used directly for rte_atomicXX_t variables. > > > > > > The cons are : > > > 1. The list needs updating every time we convert a module. > This list will go away once all the modules are converted. >=20 > > > 2. The script is not elegant as before. > > > > >=20