From: Phil Yang <Phil.Yang@arm.com>
To: oulijun <oulijun@huawei.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"beilei.xing@intel.com" <beilei.xing@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"linuxarm@huawei.com" <linuxarm@huawei.com>, nd <nd@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix the default RSS key configuration
Date: Fri, 17 Jul 2020 07:29:31 +0000 [thread overview]
Message-ID: <VE1PR08MB464053E5B5715ADE64A972A4E97C0@VE1PR08MB4640.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <8b0132df-19b7-508b-3484-56bc1b16c416@huawei.com>
<snip>
> >> Subject: [dpdk-dev] [PATCH] app/testpmd: fix the default RSS key
> >> configuration
> >>
> >> When an user runs a flow create cmd to configure an RSS rule
> >> without specifying the empty rss actions in testpmd, this mean
> >> that the flow gets the default RSS functions. However, the
> >> testpmd is not set the default RSS key incorrectly when RSS key
> >> is specified in flow create cmd.
> >
> > Hi Lijun,
> >
> > I think it works.
> > When we create an RSS flow rule which doesn't specify any 'rss-hash-key',
> the 'rss-hash-key' will be updated with the default key.
> >
> > Step 1:
> > testpmd> show port 0 rss-hash key
> > RSS functions:
> > all ipv4-frag ipv4-other ipv6-frag ipv6-other ip
> > RSS key:
> >
> 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B334AF64A4
> C05C6FA343958D8557D99583AE138C92E81150366
> >
> > Step 2:
> > testpmd> flow create 0 ingress pattern eth / ipv4 / udp / end actions rss
> types ipv4-udp end queues end / end
> > Flow rule #0 created
> >
> > Step 3:
> > testpmd> show port 0 rss-hash key
> > RSS functions:
> > all ipv4-udp udp
> > RSS key:
> >
> 74657374706D6427732064656661756C74205253532068617368206B65792C206F
> 7665727269646520697420666F722062657474
> >
> >
> > Thanks,
> > Phil
> >>
> Yes, However, it is not the default value that users use when testpmd
> starts. This may mislead users. When the driver is initialized, the
> default key used by the driver is provided for users. The key varies
> according to the DPDK vendor.However, after the DPDK is initialized, if
> the user runs the flow create command without specifying the rss key,
> the driver obtains another default key value, which may be different
> from the default value expected by the user.
It needs a dummy key.
a4391f8bae85 - app/testpmd: set default RSS key as null
next prev parent reply other threads:[~2020-07-17 7:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 13:47 Lijun Ou
2020-07-15 7:14 ` Phil Yang
2020-07-15 11:40 ` oulijun
2020-07-17 7:29 ` Phil Yang [this message]
2020-08-04 1:28 ` oulijun
2020-08-04 9:36 ` Phil Yang
2020-08-18 3:54 ` oulijun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB464053E5B5715ADE64A972A4E97C0@VE1PR08MB4640.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=adrien.mazarguil@6wind.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@huawei.com \
--cc=nd@arm.com \
--cc=oulijun@huawei.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).