From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A330A0528; Fri, 17 Jul 2020 09:29:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 063331BEE7; Fri, 17 Jul 2020 09:29:44 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50050.outbound.protection.outlook.com [40.107.5.50]) by dpdk.org (Postfix) with ESMTP id 2F0051BEDF for ; Fri, 17 Jul 2020 09:29:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=biuFsYIfqa8tWpYFVV3uK0+d2Nop+AyePt3RDqASWS4=; b=K8VErRXLOh89tyKLJGMAJlme4OXp5cVOS2cmPcCgvsiwX0oJyuftK9INMQuuhXbNW8GEpYYmbIP3yXR91HHnmkkcetjmBz2goReb/VRBRchyswq+Mi20AF6KXkd4DAwSfhw37RgPoq86030knffPZK9u21+xAtU3Hl/Prp3pWSY= Received: from AM6P191CA0044.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::21) by DB7PR08MB3564.eurprd08.prod.outlook.com (2603:10a6:10:4f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Fri, 17 Jul 2020 07:29:40 +0000 Received: from AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::7c) by AM6P191CA0044.outlook.office365.com (2603:10a6:209:7f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Fri, 17 Jul 2020 07:29:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT031.mail.protection.outlook.com (10.152.16.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Fri, 17 Jul 2020 07:29:39 +0000 Received: ("Tessian outbound 7de93d801f24:v62"); Fri, 17 Jul 2020 07:29:39 +0000 X-CR-MTA-TID: 64aa7808 Received: from a45fb7b365a9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49EFAFFF-308B-4254-9C82-76E5488BAC7D.1; Fri, 17 Jul 2020 07:29:34 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a45fb7b365a9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Jul 2020 07:29:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IrFPtPQjT07ViZGRViSKyagCws6kT0iIpl0yR7Kgq8T98GbaVGIk07grPfHs+tAv1CbCMSh5BGfwAbON8X6pjAtH5aUI6VyCH4JXw2LqbBSeBcdMC3uEP934K/uDmf2Wjad5pl31UD8J/gKB+VqVnle+nrBKItmeucv/9UhGQA76RfQeR5eqy0Q9RMZ4WrfT+01EikCCVrPM3wMvtsjK1PBn7ZjeEVV/9RGVC9yPn7h5STm3k6snP7/qLsXoNJig6gdptFBeKVfYSHWJHofGsppZe8Xz/P9CNqYtty3SMsHxwvAnL4FYCf2iRgXPe/nXRjOqa7CQHqSihN7Ld2rrxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=biuFsYIfqa8tWpYFVV3uK0+d2Nop+AyePt3RDqASWS4=; b=a1desrahQUUdabY2FmBUcX/M0B9tceFPstx0z0inqSSe1b/Bp8j7dn/GcL8T9r6Ls6XfnNU0bYbUiqXldD3yCaygJsT2KhtlkWAuhVAKDaGHquQ2YGVz4bsMGf32kQGmMGUcbMwRIShpmzLrhKQRLSncEGdRLX1FEKV0RlRDMY7DMjX0o9owY9lxTHjRWCOa9ac/krZ3PxuFY0/a6/+4H88igmqauERDx+quH20Rp5K+jRJYcC5LNUQ1UE7PSoBAL58HiKah51FLTKb0E+6Nsqlf3ilSM2CFf2vau1YYHrLPDndmWrpAQkxqVzDd6BdjCMx5jtqt2fZ072V+DBYCLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=biuFsYIfqa8tWpYFVV3uK0+d2Nop+AyePt3RDqASWS4=; b=K8VErRXLOh89tyKLJGMAJlme4OXp5cVOS2cmPcCgvsiwX0oJyuftK9INMQuuhXbNW8GEpYYmbIP3yXR91HHnmkkcetjmBz2goReb/VRBRchyswq+Mi20AF6KXkd4DAwSfhw37RgPoq86030knffPZK9u21+xAtU3Hl/Prp3pWSY= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VI1PR08MB5550.eurprd08.prod.outlook.com (2603:10a6:803:f3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Fri, 17 Jul 2020 07:29:31 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 07:29:31 +0000 From: Phil Yang To: oulijun , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" , "adrien.mazarguil@6wind.com" , "ferruh.yigit@intel.com" CC: "dev@dpdk.org" , "linuxarm@huawei.com" , nd , nd Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix the default RSS key configuration Thread-Index: AQHWWpzY1vAjf0a51UmolOnWVh/w8akLYdpQ Date: Fri, 17 Jul 2020 07:29:31 +0000 Message-ID: References: <1594302456-48256-1-git-send-email-oulijun@huawei.com> <8b0132df-19b7-508b-3484-56bc1b16c416@huawei.com> In-Reply-To: <8b0132df-19b7-508b-3484-56bc1b16c416@huawei.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: eae2f6e1-0687-402b-9b23-a9d382a0ca76.0 x-checkrecipientchecked: true Authentication-Results-Original: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.111] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 198ff97a-bad7-4ea6-e8be-08d82a232a72 x-ms-traffictypediagnostic: VI1PR08MB5550:|DB7PR08MB3564: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DWGuW0mD4MNWIxQeYNcNxydg/RM1prYKboUblmOoMgZHweNT+o+zevAVzM+FXkbFmpNMGaAu3I5BJ95lr2KWDkOzXcRKEMxFs8VF0ietYZhgDsO/z9lrvBzeT6deaCkfdxR9UmbRibllCb6+WA149faFs89Ks0Yz51xGJKOsrrXcKD6oQbXzX32k+/l9f49pN4arhcoiH72I6bBHdOfCuLDBCg/94QaOQpe+d1mGlIqBmfoqMIIPxkyPrgJYBe7WJVG2dqEvJnKdZoCun/7cNlD+xyUrjU9H3caUTphhJC7azCotjaiWSA2CtX970ZUC X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(366004)(346002)(396003)(39850400004)(83380400001)(33656002)(76116006)(66476007)(110136005)(66556008)(64756008)(7696005)(8936002)(52536014)(8676002)(71200400001)(86362001)(6506007)(2906002)(66446008)(186003)(54906003)(9686003)(55016002)(316002)(478600001)(5660300002)(26005)(4326008)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: yJ//SZVbizYQ6Ai/HQEWbvVr3YHCFCU9rv9h6Pl8SYej/rO9vxjFTyPnDYNdGPDGiLBljPeSLw9rJj2V3WVQq49p0UDmSF8K68v+fizTGuazj/YKZHyGv4whtyB1ufAsQVX+9UBTJH8EFilwYU5zGZTC0TqZsBYkd/QLnO/dvueDF8U1YAS82ABIkp5RIEdAqFluEPIQJRH9Bj+IE303pjlzzir/61hADSe1K0xCkobFcIgpnLkDkehTr8BXC4c7oiAmrEcdoh9g5Gud79E/L76cJ2ApQHbNf2dAXr/JCDMGtw/Re8hIXXa5ZqiN+clh5+eKqF0SS2XKlwQDmBk/GNq3zE6bhJlyQT1u3Oi5eM0QS1xxbMGVmPXPdaQPhg7J5ubi0VW8QT/IqYIh8YIbi/ZEG2sX9rW2hWla1PY4yKtLUhppa5q5GgkfTDbYjFUu7zKv0IoPfQGzLbvVFiRrfU8n7LCYCJlbd01bGIEh+dM= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5550 Original-Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(396003)(376002)(346002)(136003)(46966005)(4326008)(81166007)(5660300002)(8676002)(478600001)(83380400001)(70586007)(316002)(54906003)(356005)(110136005)(8936002)(36906005)(70206006)(82310400002)(2906002)(55016002)(52536014)(47076004)(82740400003)(186003)(26005)(33656002)(86362001)(9686003)(7696005)(336012)(6506007); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: f3346cc2-2a8f-4131-74c7-08d82a2325a0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bcfqw9OfqzEzURnSHsynBghyxgzoT0ZRRhz/YeirHIEXs1g5hMmFH/7hg5iE3OlqU67nMS2FNsYLHD5/I816illv70ArIo70LgTbtzc7Tlj+gUWvkLXL9DK38NmZd/Lwo3SLqre7s3HzxVgTFfVwfVPNjlTAJWcO7Utb7iIGx8Av0dH43i/HDz5edtuOyEmtdSNpQfHh83H/mS90zu3A+ELqpgPLHBQaXD8VnN4aqQuuTYNl8ZIxi9eFxiddUx6DkC1Qk54e+D2Utq1mC1O6FF6DJEcX/pdCjsfgEkNPJkvMKZPRqO2TmT+xAiWN9I1cYedhVsEccr/ppRbnQrL7wU2BpRLX8NQf7jVminXqqpkdPAAlOMjRnSNuiBhCU9Sp/eDIpITH+il3vDXGYo/AcA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 07:29:39.6731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 198ff97a-bad7-4ea6-e8be-08d82a232a72 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3564 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix the default RSS key configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >> Subject: [dpdk-dev] [PATCH] app/testpmd: fix the default RSS key > >> configuration > >> > >> When an user runs a flow create cmd to configure an RSS rule > >> without specifying the empty rss actions in testpmd, this mean > >> that the flow gets the default RSS functions. However, the > >> testpmd is not set the default RSS key incorrectly when RSS key > >> is specified in flow create cmd. > > > > Hi Lijun, > > > > I think it works. > > When we create an RSS flow rule which doesn't specify any 'rss-hash-key= ', > the 'rss-hash-key' will be updated with the default key. > > > > Step 1: > > testpmd> show port 0 rss-hash key > > RSS functions: > > all ipv4-frag ipv4-other ipv6-frag ipv6-other ip > > RSS key: > > > 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B334AF64A4 > C05C6FA343958D8557D99583AE138C92E81150366 > > > > Step 2: > > testpmd> flow create 0 ingress pattern eth / ipv4 / udp / end actions r= ss > types ipv4-udp end queues end / end > > Flow rule #0 created > > > > Step 3: > > testpmd> show port 0 rss-hash key > > RSS functions: > > all ipv4-udp udp > > RSS key: > > > 74657374706D6427732064656661756C74205253532068617368206B65792C206F > 7665727269646520697420666F722062657474 > > > > > > Thanks, > > Phil > >> > Yes, However, it is not the default value that users use when testpmd > starts. This may mislead users. When the driver is initialized, the > default key used by the driver is provided for users. The key varies > according to the DPDK vendor.However, after the DPDK is initialized, if > the user runs the flow create command without specifying the rss key, > the driver obtains another default key value, which may be different > from the default value expected by the user. It needs a dummy key. a4391f8bae85 - app/testpmd: set default RSS key as null