From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E21E8A04B7; Tue, 12 Nov 2019 06:25:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E75C723D; Tue, 12 Nov 2019 06:25:19 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00041.outbound.protection.outlook.com [40.107.0.41]) by dpdk.org (Postfix) with ESMTP id 1EBC7237; Tue, 12 Nov 2019 06:25:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AfESYhywadkzPOz464YOLkjaOQNsZ5ou2VOSIE/m6Hs=; b=phob42a/raewv1tKAUVh+VZszWvNt+njkqT0GNJYX8batc5f0GL4gojw4Or/vFoWOGr4hKMlCJ1AHq0UVnJR9mDiC49v2LmIs/AGLzMX+jVsNAc0W99PITh2Se6GC349LNKB96g2ZHvSCAJ4FpZ6/R9MHTc7sD5HwDtcg4k8ht8= Received: from DB6PR0801CA0064.eurprd08.prod.outlook.com (2603:10a6:4:2b::32) by VI1PR08MB5373.eurprd08.prod.outlook.com (2603:10a6:803:131::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Tue, 12 Nov 2019 05:25:15 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::201) by DB6PR0801CA0064.outlook.office365.com (2603:10a6:4:2b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.22 via Frontend Transport; Tue, 12 Nov 2019 05:25:14 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.21 via Frontend Transport; Tue, 12 Nov 2019 05:25:14 +0000 Received: ("Tessian outbound 0cf06bf5c60e:v33"); Tue, 12 Nov 2019 05:25:14 +0000 X-CR-MTA-TID: 64aa7808 Received: from ef25953b2d66.2 (cr-mta-lb-1.cr-mta-net [104.47.6.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 33D65EEB-C3B0-4DF0-8846-CF4C49661ABC.1; Tue, 12 Nov 2019 05:25:09 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ef25953b2d66.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Tue, 12 Nov 2019 05:25:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YFQBNLdZiKlF4UqqVxqPqVFyVvXKeTAdkoU9qTgVEs1OSyMiKChu4ORNgGrM0y9G7Y1KyUGrw4idjh0VvSxF7Hg3drHAvK7CfvRk7mOGwURdE1yBex0JrLgY7O9hSSrqpwMoomdfn+C6PNvCFmT7JmeLNwZOSfXlD4XiFZcUePYjTd4z6GKM9/YWRHNbkYbrwhPOKzlgXdFAyWm2slKR0myA2KSOUM1/FZXZuo4rM0EcwgRQcLCfbUYdSapOUrzYAa26B3AORJAHhvxChOKtipdX3HRVUNLnrtGjfhzP6D0XvbPOhnU4z7LKk3osXe1fq3TguN/umXWFYlZkNMuLfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AfESYhywadkzPOz464YOLkjaOQNsZ5ou2VOSIE/m6Hs=; b=XUW3tM3rg8G+FM3owBIQJEOgi08MoURcsELZuNzFP+hXYGDNXoR38R/C4x+BhUP6GK4Id5R86rRolO1NeVujT7dQLv9BCjcrPsvvodeHCG8z8YciJKilX1BYdoVUeNA2Vovqq/P1LiyvTAQs9cT3Bw5nvb9a8yGucDJO0CvVZiFhvy9FxIFnkVtrLTcWRuTZcA4CmYOU3xYTaJEWjER/8mz4K81sGq0U2ehP9cPIFA9WPV8nDUWJ7WX6lMUBEv8w12W4m2YiKaxb/ByTAaiMnt9YD3RveYfnvb0t/dHFK9bGO//I7fiJvOZmq2AofAZm6d2C7d7FJXjZ2syS/SpP/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AfESYhywadkzPOz464YOLkjaOQNsZ5ou2VOSIE/m6Hs=; b=phob42a/raewv1tKAUVh+VZszWvNt+njkqT0GNJYX8batc5f0GL4gojw4Or/vFoWOGr4hKMlCJ1AHq0UVnJR9mDiC49v2LmIs/AGLzMX+jVsNAc0W99PITh2Se6GC349LNKB96g2ZHvSCAJ4FpZ6/R9MHTc7sD5HwDtcg4k8ht8= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB4670.eurprd08.prod.outlook.com (10.255.114.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.23; Tue, 12 Nov 2019 05:25:07 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::3d2a:e5be:952e:541a]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::3d2a:e5be:952e:541a%6]) with mapi id 15.20.2430.027; Tue, 12 Nov 2019 05:25:07 +0000 From: "Phil Yang (Arm Technology China)" To: Bruce Richardson CC: "dev@dpdk.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" , "jerinj@marvell.com" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , "Joyce Kong (Arm Technology China)" , nd , "stable@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture Thread-Index: AQHVmH1n1zu49GwJzkuulAXqP/uuj6eG2hnQ Date: Tue, 12 Nov 2019 05:25:07 +0000 Message-ID: References: <1573468461-25972-1-git-send-email-phil.yang@arm.com> <20191111104712.GB1444@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191111104712.GB1444@bricha3-MOBL.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9514ad70-7579-4ed2-85d1-95169bb473bb.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 127ccf2b-74c8-43f1-9401-08d76730b292 X-MS-TrafficTypeDiagnostic: VE1PR08MB4670:|VE1PR08MB4670:|VI1PR08MB5373: X-MS-Exchange-PUrlCount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:663;OLM:663; x-forefront-prvs: 021975AE46 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(189003)(13464003)(199004)(33656002)(52536014)(476003)(55016002)(9686003)(6306002)(446003)(66446008)(66066001)(66476007)(66556008)(64756008)(53546011)(6506007)(11346002)(76116006)(7696005)(66946007)(5660300002)(76176011)(186003)(229853002)(55236004)(102836004)(6916009)(6116002)(6436002)(3846002)(99286004)(14444005)(25786009)(256004)(26005)(966005)(478600001)(8936002)(14454004)(6246003)(54906003)(2906002)(8676002)(7736002)(305945005)(4326008)(71200400001)(74316002)(81156014)(81166006)(486006)(316002)(86362001)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4670; H:VE1PR08MB4640.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vLyjs9FSdPek2xYvtRJLDURFuz7UuQgpVysXCI+j9eLyqPZ9/R09P/682VQt+xRzOSVQ4zl4rz+Ac7eYy36iew8aDyWAUPBTU4+WgrclS0dPinydNVQc0Xg1IrD458C7kgfHRj1ukjBB4Z9hJri1YZ5gFLd2I7mx9b0Ut0jrFlZXxDw4p4NZdVyi7GEsM1zOqWOr8EsN/cVBDYMwXRdd6GgZjLLQolOpg5Fx3bx4YMR6RIm9A6amWEQuDZzxYFWNML9j9ihlFx4LRMn0I6kJameibbj/sLAD+XuJcZET0pV/pR5LNd41tBSaKMhkRcCGeHBoy9+818HhnBy+VVAPCqvjt8KDkS+HAvNTcU6UjrNUUAnE/C7RbPIZxVy4V+eYYQ7DP7dJoIVG771JxpOXoS/HDYVpkRVoKvvKWHIuQuNXibAK/fU6xDttGWsl/6wtfPRpDN9abLYq5bU6zQ8paMn/EoXlW+cX6A4zVsrxcRA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4670 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(396003)(39860400002)(376002)(1110001)(339900001)(13464003)(199004)(189003)(70586007)(476003)(25786009)(50466002)(305945005)(446003)(70206006)(74316002)(86362001)(11346002)(7736002)(336012)(23726003)(8746002)(8936002)(450100002)(2906002)(102836004)(81166006)(99286004)(186003)(47776003)(81156014)(8676002)(66066001)(26005)(97756001)(53546011)(316002)(36906005)(3846002)(6116002)(478600001)(6506007)(966005)(26826003)(14454004)(14444005)(33656002)(76176011)(22756006)(6862004)(54906003)(76130400001)(6246003)(55016002)(6306002)(9686003)(486006)(4326008)(5660300002)(7696005)(126002)(105606002)(52536014)(229853002)(46406003)(356004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB5373; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 68b48842-71f4-457d-a167-08d76730ae30 NoDisclaimer: True X-Forefront-PRVS: 021975AE46 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wFv6IlhC7967Jqa0+abiICj9D9dpmLMlPxUadZAC3XsX3M9hB+t9ifOSkAI1pPCDlxoPF01cqA3Y5Lk569ZH+uH4ihCstXX6FAEV2uOFZQaat7kGouxxS0P2eYpEhYjz8D/kX6iFv+WT6xzHnLh8rLcnVDJ7GJ6J/OPtdA+eybIt7FtmdZ+CuNuXTmG2QSstSUI4b3PVBN9od8ZUoj2JZIKTTZRxlGBXX9pxFiVfm49HqLVi7pskSQIEiKXrQhPsHa8iQ+gJCrShOjcMUobkFf63KHQcQm/oQ/5qIkGbIhCTvlahbe5BrSnFySEJuCV2bc+ydyufC5b6wU9b3pnCB+QpaqLKGJSjoaOtU/oq6Z1xWEdSMZ+n14BIbHUgEbhi7g6dEaENjroTuXgU5kQviCOk4GmcZUgaMf7Rq14ep8BTuiA75cmkPBoQ6RCg8sf2uMEoj70qcXGGdAOyQ7HGEgIUL4zNERglmjPThhAJxZ0= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2019 05:25:14.7396 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 127ccf2b-74c8-43f1-9401-08d76730b292 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5373 Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Monday, November 11, 2019 6:47 PM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; thomas@monjalon.net; david.marchand@redhat.com; > jerinj@marvell.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; Joyce Kong (Arm Technology China) > ; nd ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on arm= hf > architercture >=20 > On Mon, Nov 11, 2019 at 06:34:20PM +0800, Phil Yang wrote: > > The older version (e.g. version 7.4.0 ) of GNU C compiler for the armhf > > architecture doesn't support the flag '-Wno-address-of-packed-member', > > so remove this flag for aarch32. > > > > Fixes: a385972c3675 ("mk: disable warning for packed member pointer") > > Cc: stable@dpdk.org > > > > Signed-off-by: Phil Yang > > Reviewed-by: Gavin Hu > > Tested-by: Joyce Kong > > > > --- > > mk/toolchain/gcc/rte.vars.mk | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.m= k > > index 9fc7041..ec0cbbf 100644 > > --- a/mk/toolchain/gcc/rte.vars.mk > > +++ b/mk/toolchain/gcc/rte.vars.mk > > @@ -100,7 +100,9 @@ WERROR_FLAGS +=3D -Wno-format-truncation > > endif > > > > # disable packed member unalign warnings > > +ifneq ($(CONFIG_RTE_ARCH_ARM), y) > > WERROR_FLAGS +=3D -Wno-address-of-packed-member > > +endif > > > You don't need to do this, as gcc will not complain about this unknown fl= ag > unless you have other issues in your code.[1] I think it's better to keep= the > code clean in this case, otherwise we'll have the code littered with > conditionals for various flags. >=20 > /Bruce >=20 > [1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html > "When an unrecognized warning option is requested (e.g., > -Wunknown-warning), GCC emits a diagnostic stating that the option is not > recognized. However, if the -Wno- form is used, the behavior is slightly > different: no diagnostic is produced for -Wno-unknown-warning unless othe= r > diagnostics are being produced. This allows the use of new -Wno- options > with old compilers, but if something goes wrong, the compiler warns that = an > unrecognized option is present." Thanks, Bruce.=20 There are thousands of warnings with alignment when compiling for ARMv7 (AR= Mv7 supports unaligned memory access). Without this new flag, the build system works fine for ARMv7. So I add thi= s conditional for ARMv7 only. I agree with you we should clean up the code, but it needs a lot of effort = to achieve that.=20 This patch is going to make the ARMv7 target build successfully during this= period. Thanks, Phil