From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C84E5A046B for ; Tue, 23 Jul 2019 05:29:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8916A1BEDE; Tue, 23 Jul 2019 05:28:59 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) by dpdk.org (Postfix) with ESMTP id 90F7B1BED6 for ; Tue, 23 Jul 2019 05:28:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tq84SADiSVG+3x8JGXi7A8P5p6x7eGq95c47VOwP0kxYyicfx/8m25ASSOdQ4Fyr2lPQ/z/hRb5oPfQF0XoldZ05x8Khn1VRJgAdWyCrR49Acc5/7aWkdHPxbXNUakI3jTOv36r7M54FKSnx/EHMPb6WTP4vLdpTkBKw7sUJLPUORhd09hFQzcqYhRnQhDFCDjz8IiD8ItexP59lUvtucvcJ1cXdiQ1zofXKFfAeY4TBHthAjw2QzbT8ovuHjkI1OeHLbcpZ/8MfL/dElObviAboXEdkv0CF6nofVmWvHyPch+ouHclOxpNrbHIngLampodwFGkDRDD5x8MojVX34Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7slOGkSovPJuMigmlEDM1OtV78IxDpKFeNDoZBpCks=; b=JPLFI08mYnd7UqqwPg16D4vm2FJghyXb+IiwBCJrTUHhpgMUfobcv1tk0Sufeh3VBn2V0vcF0QYlE+ZbNICyWM7DP89hiJoe//E/zK0O9O2PfCt07Lyaq7t4ArtAz/tgQQlw2hEIgP6b1ksrnkvy76gc8HyaKu9NUQngJCbfK9AQhm7PrlKRcL8+Xc9D2hvnePkNyugd9HD2K1eGcxbvG/k6XH86LoR93GkrpoFNpHDU15tRZMl3VOhYn0hXoyN+Hhwb/AzZ9zjL1TjpXDO4rkOI/a/dXYIiYYZWBJq0nupCj8/5BZD+SZYjvjVxtUoB4v/upe4LWYpcOdAF8zsLpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7slOGkSovPJuMigmlEDM1OtV78IxDpKFeNDoZBpCks=; b=fPNo3Ja9q4PpslgJuSxvCvddJtmtfMHvZtpNe28NXh1ZvzMkjZpI+bON8LLdnpJ3s7vxyWraEKM6EB6JrT01pM/BSVCu5AInZtdPBr4IgmyRQm9rvdDksbukK7ZUdYcQodYnlQiM3Af7Io1Iv7RRk32/0y2r3KZvhrz223NjmIk= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB4750.eurprd08.prod.outlook.com (10.255.112.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.17; Tue, 23 Jul 2019 03:28:56 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::f4e4:378b:49d3:d876]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::f4e4:378b:49d3:d876%5]) with mapi id 15.20.2094.013; Tue, 23 Jul 2019 03:28:56 +0000 From: "Phil Yang (Arm Technology China)" To: "jerinj@marvell.com" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "gage.eads@intel.com" , "hemant.agrawal@nxp.com" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , nd , nd Thread-Topic: [EXT] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare exchange Thread-Index: AQHVQK6Rch1V+ATIikmc7exTCgxuVqbXhbIg Date: Tue, 23 Jul 2019 03:28:56 +0000 Message-ID: References: <1561257671-10316-1-git-send-email-phil.yang@arm.com> <1563812554-7061-1-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 11e2d6a9-bd36-4047-bb1b-4a34ffe5364d.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 06d474c9-cffb-485f-98df-08d70f1de508 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4750; x-ms-traffictypediagnostic: VE1PR08MB4750: x-ms-exchange-purlcount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:1303; x-forefront-prvs: 0107098B6C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(396003)(39860400002)(376002)(136003)(199004)(189003)(13464003)(54906003)(110136005)(2906002)(14454004)(6116002)(2501003)(71200400001)(316002)(68736007)(71190400001)(8676002)(74316002)(305945005)(99286004)(7736002)(3846002)(33656002)(66066001)(476003)(11346002)(446003)(6506007)(53546011)(186003)(76176011)(55016002)(486006)(26005)(102836004)(6436002)(55236004)(76116006)(52536014)(966005)(25786009)(64756008)(66446008)(66476007)(66556008)(6246003)(7696005)(5660300002)(229853002)(66946007)(9686003)(6306002)(53936002)(256004)(478600001)(81156014)(8936002)(14444005)(4326008)(86362001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4750; H:VE1PR08MB4640.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: QoMoJYUxwRJduaVokodKXAZCC3Bu2EbLvyKiQWvu/1GZY2PIIsKWYPcV0WxkLY1cV2Oq+oKzvlbxp0OSsPa9vfm4Pn80spmmWIlBAbOArUKd+fkXu0KP/Pbeo50TSsDf0itE/ADZkX+BK2LDjXqsqiggNmblLEc/Uazs7lVzQukW4GHUQbybe81UjsS6j0eDFtChWU5ILLMYTnR09nQa/rK7BQOGLUKu4AX7gazTP9z0K1bY5yANI8S1RGFMtMiq3cdz2DeuXG6cBlpUsqwblYEzqYInqFX4P4bjs6Pp6u7JGZRsjHr3e5mkeXaVp8a5JMm3EKdaFHkcfKniFB1NDFuVErPvXVZt4UqtDy3XjKHp8crBvp+drFyJRioZ5IKU+uRWSxBkdQ/AYFsWYzaAPbJboageCkLsltOIwtVhK4M= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06d474c9-cffb-485f-98df-08d70f1de508 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 03:28:56.6119 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Phil.Yang@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4750 Subject: Re: [dpdk-dev] [EXT] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare exchange X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, July 23, 2019 12:57 AM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: thomas@monjalon.net; gage.eads@intel.com; > hemant.agrawal@nxp.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd > Subject: RE: [EXT] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare > exchange >=20 > > -----Original Message----- > > From: Phil Yang > > Sent: Monday, July 22, 2019 9:53 PM > > To: dev@dpdk.org > > Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran > ; > > gage.eads@intel.com; hemant.agrawal@nxp.com; > > Honnappa.Nagarahalli@arm.com; gavin.hu@arm.com; nd@arm.com > > Subject: [EXT] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare > > exchange > > > > Add 128-bit atomic compare exchange on aarch64. > > > > Suggested-by: Jerin Jacob > > Signed-off-by: Phil Yang > > Tested-by: Honnappa Nagarahalli > > Reviewed-by: Honnappa Nagarahalli > > > > --- > > diff --git a/config/common_base b/config/common_base index > > 8ef75c2..de6d1e0 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -82,6 +82,8 @@ CONFIG_RTE_MAX_LCORE=3D128 > > CONFIG_RTE_MAX_NUMA_NODES=3D8 > > CONFIG_RTE_MAX_HEAPS=3D32 > > CONFIG_RTE_MAX_MEMSEG_LISTS=3D64 >=20 >=20 > Add new line here. >=20 > > +# Use LSE ATOMIC instructions >=20 > I think, you can change the comment to "Use ARM LSE ATOMIC instructions" OK. Will fix it. >=20 > > +CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dn >=20 > This patches series has following check patch warning. Please fix it >=20 > With above fixes you can add my acked-by in 1/3 and 3/3 patches in next > revision. Thank you for your review and your comments. >=20 >=20 > I think, you can ignore following warning. > WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control > statements should be avoided >=20 > [master]dell[dpdk.org] $ ./devtools/checkpatches.sh Yes. I did this check before upstream this patch.=20 I ignored ' WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control state= ments should be avoided ' warnings. However, I didn't see any LONG_LINE warnings in the CI report here. http://= mails.dpdk.org/archives/test-report/2019-July/090889.html BTW, I think these 3 warnings in the report might be ineluctable. >=20 > ### eal/arm64: add 128-bit atomic compare exchange >=20 > WARNING:LONG_LINE: line over 80 characters The default tab size is 8. You might need to change it to 4 in the /usr/src= /linux/scripts/checkpatch tool. FYI.=20 diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a09333f..d3865a4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1211,7 +1211,7 @@ sub expand_tabs { if ($c eq "\t") { $res .=3D ' '; $n++; - for (; ($n % 8) !=3D 0; $n++) { + for (; ($n % 4) !=3D 0; $n++) { $res .=3D ' '; } next; @@ -3688,11 +3688,11 @@ sub process { #print "line<$line> prevline<$prevline> indent<$indent> sinden= t<$sindent> check<$check> continuation<$continuation> s<$s>=20 cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n"; if ($check && $s ne '' && - (($sindent % 8) !=3D 0 || + (($sindent % 4) !=3D 0 || ($sindent < $indent) || ($sindent =3D=3D $indent && ($s !~ /^\s*(?:\}|\{|else\b)/)) || - ($sindent > $indent + 8))) { + ($sindent > $indent + 4))) { WARN("SUSPECT_CODE_INDENT", "suspect code indent for conditional statements ($ind= ent, $sindent)\n" . $herecurr . "$stat_real\n"); } > #103: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:60: > + rte_int128_t updated) = \ >=20 > WARNING:LONG_LINE: line over 80 characters > #108: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:65: > + */ = \