From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 000C1A0523;
Thu, 2 Jul 2020 05:28:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id DFF4E1D59A;
Thu, 2 Jul 2020 05:28:40 +0200 (CEST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
(mail-eopbgr10055.outbound.protection.outlook.com [40.107.1.55])
by dpdk.org (Postfix) with ESMTP id 160721D418;
Thu, 2 Jul 2020 05:28:39 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=I21/j1NfwFbdku3sE5laqbMXrImawyGwNgNkup8Ab1Y=;
b=illrBkAOqOsOq2gP4zi664JU9XxO6qSJLqAmQwdJH6g5X98sVHO+14E965o6ixPTNGF7MTUZEgAESr+4t9ZsmTNtsypqG2qje5DArD9Aw51tob3zWi97SlgYfJmZfeX3s3aM/TzVSx2S21DyDjdu6KXYJ/YlbCZLccP4D+aClbI=
Received: from DB6PR07CA0089.eurprd07.prod.outlook.com (2603:10a6:6:2b::27) by
DB6PR0802MB2422.eurprd08.prod.outlook.com (2603:10a6:4:9f::23) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.3131.23; Thu, 2 Jul 2020 03:28:36 +0000
Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
(2603:10a6:6:2b:cafe::5e) by DB6PR07CA0089.outlook.office365.com
(2603:10a6:6:2b::27) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.8 via Frontend
Transport; Thu, 2 Jul 2020 03:28:36 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)
header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none
header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
63.35.35.123 as permitted sender) receiver=protection.outlook.com;
client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with
Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.3131.20 via Frontend Transport; Thu, 2 Jul 2020 03:28:36 +0000
Received: ("Tessian outbound b8ad5ab47c8c:v62");
Thu, 02 Jul 2020 03:28:36 +0000
X-CR-MTA-TID: 64aa7808
Received: from ff48b80282c4.2
by 64aa7808-outbound-1.mta.getcheckrecipient.com id
E12702D5-654E-4F2F-8110-0BE68C7D2D04.1;
Thu, 02 Jul 2020 03:28:31 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ff48b80282c4.2
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
Thu, 02 Jul 2020 03:28:31 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=UNswyOf5qorXFa74e4K96UzU0OtKIAbHoaZYnY9sipqes/kGQuHQEcvLblrQX39vLu60mAsYk6OiiAUZHcYWbx1mTLZB3TqHRafKTHgtm1o97WRNCGdZIMUFOSnPQeyRLd17YwRcEMGsI+ViNeAh+7qCycHDabVmPGemuRtARvq5w1O5Tv+xMTHZdxIRuLGI3kMIH5oFqX9qnZ/vNwNYIQVnQpQqTs0AAlsA8C0/Smzzc7K9Z27ILLIASSF/mCtl/PNZe8aU0hl6PmKvyTEAxe+7lxXxDjVm9xDFREf/WbJmvyMgIg+ALlpDj5vV3lrrApySHQbjZV1W6KYTfb+KxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=I21/j1NfwFbdku3sE5laqbMXrImawyGwNgNkup8Ab1Y=;
b=Uk/N4sUS+pXoc7dNvN8YPnz4nYWhjIxf0XjSlGWKu9IUviOBaRTEpr7mPWwwuuRGlU+tcWZx+HtzpAzGUMQ0XfY2dqgHqR5gMhaUh2VMKFsdJJJcm4VtqWt1xtWSVaSHG60OY+XmTRUH3JhnBGaJXLprvF4KRP36PUiaDXrWNY+oOnfbXxjhcwBq+9QYAifWCxqDX3XKTkq7KIH4+KuO3z+bLN44+cvjZP78J8Z/+c4rEqUox6qy3qnpTRqZgp880XwZ5PmQxdEnts0178c++xa4N44t6q5kKySp+eRDwQdwNBbT7TVgTGVLWStZFtPXSZRXc2kTQqvZtL/1Pb1USQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=I21/j1NfwFbdku3sE5laqbMXrImawyGwNgNkup8Ab1Y=;
b=illrBkAOqOsOq2gP4zi664JU9XxO6qSJLqAmQwdJH6g5X98sVHO+14E965o6ixPTNGF7MTUZEgAESr+4t9ZsmTNtsypqG2qje5DArD9Aw51tob3zWi97SlgYfJmZfeX3s3aM/TzVSx2S21DyDjdu6KXYJ/YlbCZLccP4D+aClbI=
Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11)
by VI1PR0802MB2239.eurprd08.prod.outlook.com (2603:10a6:800:a4::10)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Thu, 2 Jul
2020 03:28:29 +0000
Received: from VE1PR08MB4640.eurprd08.prod.outlook.com
([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com
([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3131.028; Thu, 2 Jul 2020
03:28:29 +0000
From: Phil Yang <Phil.Yang@arm.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
CC: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "Carrillo, Erik G"
<erik.g.carrillo@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>, Ruifeng Wang
<Ruifeng.Wang@arm.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>, nd
<nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer
list counter
Thread-Index: AQHWRYO0C4+OtcPfIEys7qAlWeZDrqjesL6AgAW3t8CADkBFAIABDWdg
Date: Thu, 2 Jul 2020 03:28:29 +0000
Message-ID: <VE1PR08MB4640A2E4C9BEEDC7DDE54A8CE96D0@VE1PR08MB4640.eurprd08.prod.outlook.com>
References: <1591960798-24024-1-git-send-email-phil.yang@arm.com>
<CY4PR1101MB2118653CE0272DB20268C2B9B99B0@CY4PR1101MB2118.namprd11.prod.outlook.com>
<DB6PR0802MB2216B52A7A16EC38FDB082DF989B0@DB6PR0802MB2216.eurprd08.prod.outlook.com>
<VE1PR08MB46402DE1929630D75EA6C207E9970@VE1PR08MB4640.eurprd08.prod.outlook.com>
<CALBAE1NxFPCy5URcn8AzVbdQ1+fCE_TayDyGA+bnG_5KP+=tMA@mail.gmail.com>
In-Reply-To: <CALBAE1NxFPCy5URcn8AzVbdQ1+fCE_TayDyGA+bnG_5KP+=tMA@mail.gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 7eb95078-d05c-4d10-a9a4-a863ae1a3c4e.0
x-checkrecipientchecked: true
Authentication-Results-Original: gmail.com; dkim=none (message not signed)
header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
x-originating-ip: [203.126.0.112]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 22a2e12e-8500-4c5e-cb2c-08d81e3801bb
x-ms-traffictypediagnostic: VI1PR0802MB2239:|DB6PR0802MB2422:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <DB6PR0802MB2422EB0DB6711B4B66D64261E96D0@DB6PR0802MB2422.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
x-forefront-prvs: 0452022BE1
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: pB7QQTVsoEgfukQueLewm2q/pMkqX+gE28SGv4kJOOJmTar0aZTRL9rnn6I0n/T2/Gh8wuDM6lOMAUV8YuBGLyNYcVNAgh9ryI0f6nIOjdpikclFITSTRQmpl54YSmb3RZ3Vj64rfODBOdRBhsX9Jby3V5458U9MsqECISg831G+IwE7BEl4Ok6GiuJl+QKqq7UcY3fKWZRv5mEzPwaRW3aFIizkF6FUZn1B1TMYhOORp4O+7ONRGpHeHAMQEmjZyV2LC+dmv8P7KCmJBXUg+dlxBNLYERFKqG4MfuexoKtuwnIQfZSqBggtWTD4wDHYdH/9wRb7e4VW9lMKjuI+7w==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en;
SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com;
PTR:; CAT:NONE; SFTY:;
SFS:(4636009)(136003)(396003)(376002)(366004)(39860400002)(346002)(9686003)(71200400001)(26005)(66446008)(478600001)(186003)(8936002)(2906002)(64756008)(5660300002)(6506007)(66556008)(66476007)(66946007)(86362001)(83380400001)(316002)(53546011)(33656002)(55016002)(76116006)(6916009)(8676002)(4326008)(52536014)(54906003)(7696005);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: LDydglCJ6zfSnKFEucdUQ/yXYlYC3x1TGa7rk8oANiHvqhKMMCnazAGxECgHNmjZT9ChlrmPSdCc9WnRHRTQnBCaNU5oN1KLiEL4DYhH49n1uwEwraEAO7J6/3iGBmbM2KOqz51fLZdbNRfZg397Thl1BReaDFRHxeve4FRlvlNqeheQy7OUYKPExKsSwSiXNnhXMmbq6gTouP3Of8msFFFLaOTLA4PdFl0/tT5uJDI/S6uHllyJfNNKMUzIV/7rugEzorM9lkIoXXazerChUipL6b4adi5HkEuDjRx7Ma9OqybkRRU4H7lNV+BXTyY2fjV2GK0GkhobpOFNQ9vHs3A/Kv/69mOrSKg1VOtZfS0/8xs16cSy1HXOUR6PjT7pozEBhQP7yv+5YFOBBHy/W8LOg4JnXGgHDyc+AxF9DzQ9djJp2vwK/6J9m/lWqdmqkh5KPehogDfUKra8nwdyOXi/tQTh8koymPn+gAJSr176XiYAHM6SMBl4eeJrfOmL
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2239
Original-Authentication-Results: gmail.com; dkim=none (message not signed)
header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;
IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;
PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;
SFS:(4636009)(39860400002)(346002)(136003)(376002)(396003)(46966005)(8936002)(53546011)(6506007)(7696005)(9686003)(2906002)(5660300002)(82740400003)(47076004)(70586007)(86362001)(8676002)(70206006)(81166007)(52536014)(6862004)(336012)(450100002)(82310400002)(33656002)(356005)(55016002)(478600001)(26005)(54906003)(316002)(186003)(4326008)(83380400001);
DIR:OUT; SFP:1101;
X-MS-Office365-Filtering-Correlation-Id-Prvs: adcb1710-45b2-4c90-a0fb-08d81e37fd66
X-Forefront-PRVS: 0452022BE1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: QOvpViWSz3U547HSVPf0hNxNQ7oUUIJXACH9NCn5tvgQrVml00VfIj7NzB5NqCdkkxXZtvtiDjwPxQXQOO5DZtsCDjCPT0e+1Jdruk5GslCl9Ay949RX6pJoUVziZTTl4tuK0LsQraA5doZUvpf/qZiEpBDoRwKbVKnVCJ7pKmrsEWJotofFL8QHpvpdlWQHBTWvlMbe/uWlRSP0Oij+zE7r5vpxySjOP5c5nu15HSDq42nhaCA8XmDG32CFnGjnoW5j/1TE94X519rOJcEjseEwOwaB8WVGMPulCWFitD2iPYmngm6VN9ySqVW44HIpYqGF1+mh1QS+1j4ExA9TGobgZflDkYpL15uq2hnBGeqQ4W+xGoJJEbwJRaKaOHMPKMbRmVIkLdepdpEZwfsrhQ==
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2020 03:28:36.8921 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 22a2e12e-8500-4c5e-cb2c-08d81e3801bb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2422
Subject: Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer
list counter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKZXJpbiBKYWNvYiA8amVyaW5q
YWNvYmtAZ21haWwuY29tPg0KPiBTZW50OiBXZWRuZXNkYXksIEp1bHkgMSwgMjAyMCA3OjIyIFBN
DQo+IFRvOiBQaGlsIFlhbmcgPFBoaWwuWWFuZ0Bhcm0uY29tPg0KPiBDYzogSG9ubmFwcGEgTmFn
YXJhaGFsbGkgPEhvbm5hcHBhLk5hZ2FyYWhhbGxpQGFybS5jb20+OyBDYXJyaWxsbywgRXJpayBH
DQo+IDxlcmlrLmcuY2FycmlsbG9AaW50ZWwuY29tPjsgZGV2QGRwZGsub3JnOyBkcmNAbGludXgu
dm5ldC5pYm0uY29tOw0KPiBSdWlmZW5nIFdhbmcgPFJ1aWZlbmcuV2FuZ0Bhcm0uY29tPjsgRGhh
cm1payBUaGFra2FyDQo+IDxEaGFybWlrLlRoYWtrYXJAYXJtLmNvbT47IG5kIDxuZEBhcm0uY29t
Pjsgc3RhYmxlQGRwZGsub3JnDQo+IFN1YmplY3Q6IFJlOiBbZHBkay1kZXZdIFtQQVRDSCAxLzNd
IGV2ZW50ZGV2OiBmaXggcmFjZSBjb25kaXRpb24gb24gdGltZXIgbGlzdA0KPiBjb3VudGVyDQo+
IA0KPiBPbiBNb24sIEp1biAyMiwgMjAyMCBhdCAzOjE4IFBNIFBoaWwgWWFuZyA8UGhpbC5ZYW5n
QGFybS5jb20+IHdyb3RlOg0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K
PiA+ID4gRnJvbTogSG9ubmFwcGEgTmFnYXJhaGFsbGkgPEhvbm5hcHBhLk5hZ2FyYWhhbGxpQGFy
bS5jb20+DQo+ID4gPiBTZW50OiBGcmlkYXksIEp1bmUgMTksIDIwMjAgMjoyNiBBTQ0KPiA+ID4g
VG86IENhcnJpbGxvLCBFcmlrIEcgPGVyaWsuZy5jYXJyaWxsb0BpbnRlbC5jb20+OyBQaGlsIFlh
bmcNCj4gPiA+IDxQaGlsLllhbmdAYXJtLmNvbT47IGRldkBkcGRrLm9yZw0KPiA+ID4gQ2M6IGRy
Y0BsaW51eC52bmV0LmlibS5jb207IFJ1aWZlbmcgV2FuZyA8UnVpZmVuZy5XYW5nQGFybS5jb20+
Ow0KPiA+ID4gRGhhcm1payBUaGFra2FyIDxEaGFybWlrLlRoYWtrYXJAYXJtLmNvbT47IG5kIDxu
ZEBhcm0uY29tPjsNCj4gPiA+IHN0YWJsZUBkcGRrLm9yZzsgSG9ubmFwcGEgTmFnYXJhaGFsbGkN
Cj4gPEhvbm5hcHBhLk5hZ2FyYWhhbGxpQGFybS5jb20+Ow0KPiA+ID4gbmQgPG5kQGFybS5jb20+
DQo+ID4gPiBTdWJqZWN0OiBSRTogW1BBVENIIDEvM10gZXZlbnRkZXY6IGZpeCByYWNlIGNvbmRp
dGlvbiBvbiB0aW1lciBsaXN0IGNvdW50ZXINCj4gPiA+DQo+IA0KPiA+ID4gU2luY2UgdGhpcyBj
b21taXQgd2lsbCBiZSBiYWNrIHBvcnRlZCwgd2Ugc2hvdWxkIHByZWZlciB0byB1c2UgcnRlX2F0
b21pYw0KPiA+ID4gQVBJcyBmb3IgdGhpcyBjb21taXQuIE90aGVyd2lzZSwgd2Ugd2lsbCBoYXZl
IGEgbWl4IG9mIHJ0ZV9hdG9taWMgYW5kIEMxMQ0KPiA+ID4gQVBJcy4NCj4gPiA+IE15IHN1Z2dl
c3Rpb24gaXMgdG8gZml4IHRoaXMgYnVnIHVzaW5nIHJ0ZV9hdG9taWMgc28gdGhhdCBiYWNrcG9y
dGVkIGNvZGUNCj4gd2lsbA0KPiA+ID4gaGF2ZSBvbmx5IHJ0ZV9hdG9taWMgQVBJcy4gQWRkIGFu
b3RoZXIgY29tbWl0IChpZiByZXF1aXJlZCkgaW4gdGhpcyBzZXJpZXMNCj4gdG8NCj4gPiA+IG1h
a2UgdGhlIGJ1ZyBmaXggdXNlIEMxMSBBUElzICh0aGlzIGNvbW1pdCB3aWxsIG5vdCBiZSBiYWNr
cG9ydGVkKS4NCj4gPg0KPiA+IEFncmVlLg0KPiA+IEkgd2lsbCBjaGFuZ2UgdGhpcyBwYXRjaCB0
byB0aGUgcnRlX2F0b21pYyB2ZXJzaW9uIGluIHRoZSBuZXh0IHZlcnNpb24uDQo+IA0KPiBIaSBQ
aGlsLA0KPiANCj4gQ291bGQgeW91IHNlbmQgdGhlIG5leHQgdmVyc2lvbj8gSSB3b3VsZCBsaWtl
IHRvIHRha2UgdGhpcyBzZXJpZXMgZm9yDQo+IFJDMShuZXh0LWV2ZW50ZGV2IHRyZWUpDQoNClRo
YW5rcywgSmVyaW4uDQpJIHdpbGwgdXBzdHJlYW0gdGhlIG5ldyBwYXRjaCBzZXJpZXMgc29vbi4N
Cg0KDQo+IA0KPiANCj4gPg0KPiA+IFRoYW5rcywNCj4gPiBQaGlsDQo+ID4NCg==