From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24709A0526; Wed, 22 Jul 2020 14:06:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBB171BFE4; Wed, 22 Jul 2020 14:06:27 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) by dpdk.org (Postfix) with ESMTP id 14BC62B86 for ; Wed, 22 Jul 2020 14:06:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wuFf2DzhIbYZJlf3F/bEJogyBk6cKy39efyoSNWo+c8=; b=eZimoYE4ofFGDroeCeei1iRhLokCzwT0LaSAbgVMr+Vx4ximoJ0eTLdisFUJZRpyGEoLaxzp94nlOExCE58Fpk5KlSDwYukgpacTFQPGv//tCTW/kKFET0CMQ6plJUxOIt9OCHvj2MULMd1twQc47EIRnJBJKYyZkCasFjEPNDE= Received: from AM6P195CA0042.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::19) by VI1PR08MB4031.eurprd08.prod.outlook.com (2603:10a6:803:e7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Wed, 22 Jul 2020 12:06:21 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:87:cafe::90) by AM6P195CA0042.outlook.office365.com (2603:10a6:209:87::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Wed, 22 Jul 2020 12:06:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.10 via Frontend Transport; Wed, 22 Jul 2020 12:06:21 +0000 Received: ("Tessian outbound 2ae7cfbcc26c:v62"); Wed, 22 Jul 2020 12:06:21 +0000 X-CR-MTA-TID: 64aa7808 Received: from 910095f3b44d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8B4F2DCF-435D-4D9F-A084-30F97E249CEF.1; Wed, 22 Jul 2020 12:06:16 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 910095f3b44d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 22 Jul 2020 12:06:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVUbrZtJgfwlsRUALYSsc9ybxFwgJejE2G5UBU39dX2RLrJ/5e/8YYMPavOCkb0xZFsUvHOkvZIclCtuXk5nCnYSarCVg06bfCaKiwdTZWkljJmxz1/nc5FJz1g/Me0PP+IPGULBCAnkrvNy8nqMsd8oAzSNRQqOiLlQ5WXIV/ZQAPQh3i8ypvIFwMYzzhlDNqWgGgX4zW10gSU3Vx15Ikq8BWYmKnEyShiE2SJv6UNrBHv8L6m7hKZuThRDiEl59K7sNHaZadjAnOltMund+9gvBrLrMUcY9zUbPmd8oPmUGlEdhsilzVELlxMkXbS9Qpwa4JGRgeirREV1TGYbvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wuFf2DzhIbYZJlf3F/bEJogyBk6cKy39efyoSNWo+c8=; b=msyBEdyThuH7ytvTiHHASTCYjEBksfCruMkUrsrxSuoSW37Ux24vN8K1XOiWljV17b8z8lMnxVBB6GFw8SSmLUzQTtwg7gy3ifCGw5DK4AIMkEGomxhPQLmf1Wew0oVkmQ4lqof+oX0ycgHjRqdespWsh0kU+A/RHjRK4Rb8XwJKi+dFnJcwbpfF/Y1JQ83oI9gTzp8egLkgeqr+s0hRXD8ip8FHCSuV801Tj6cJ/E8Yr8iYnpjKozcF+uwTxltyjYHYmlxrzflcRMFAbRw0QjnXTfKZpM4lB4/0/8uKS7EfBUNGF0WSQthFEkQCBz7gH3L+A4oHhyJyok/1WkZzdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wuFf2DzhIbYZJlf3F/bEJogyBk6cKy39efyoSNWo+c8=; b=eZimoYE4ofFGDroeCeei1iRhLokCzwT0LaSAbgVMr+Vx4ximoJ0eTLdisFUJZRpyGEoLaxzp94nlOExCE58Fpk5KlSDwYukgpacTFQPGv//tCTW/kKFET0CMQ6plJUxOIt9OCHvj2MULMd1twQc47EIRnJBJKYyZkCasFjEPNDE= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VI1PR08MB5312.eurprd08.prod.outlook.com (2603:10a6:803:139::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Wed, 22 Jul 2020 12:06:13 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::28a3:3a4e:65ca:5707]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::28a3:3a4e:65ca:5707%3]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020 12:06:13 +0000 From: Phil Yang To: Alexander Kozyrev , Honnappa Nagarahalli , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "drc@linux.vnet.ibm.com" , nd , "dev@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt Thread-Index: AQHWXuyRqTPpygPJg0imDSLz2DSNPakRQ72QgAAkzQCAAAGHAIAAAiaAgAID8iA= Date: Wed, 22 Jul 2020 12:06:13 +0000 Message-ID: References: <20200410164127.54229-7-gavin.hu@arm.com> <1592900807-13289-1-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: f1d3ccf5-503a-46a4-a1bb-125b662948c2.0 x-checkrecipientchecked: true Authentication-Results-Original: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.111] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 20496fcb-142e-4da9-b544-08d82e37a5db x-ms-traffictypediagnostic: VI1PR08MB5312:|VI1PR08MB4031: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pa/FRKBsjg+tYRMQbJtgU3asvSQkraI3c1G2PBxmEcdO4z+HEY/0I0F81OswP/iAmElIRMuZtPXgbqZlGgpGIz+n0HAW318btjWU7QMxsat3dWsc8tZVD8QfGB+HWOeblM9qyOVJR1pesFg1zQ3zEAzHueeXjgJHs5gq35TPoE696LXJtRnVm72ppntvt8aN8Ng4Y6eAUzOZIPO0mROknkmAjrZRgFY4Rqznz+vQq1gsVd4v+KnClvb//1/qwppcClvAR+BbVA8JKOlZmmUCfdr6p4VuMTdOdk1i/BbwRKnwNDq7y5O9L9m048KMWnsah45jK8wpAKqbkfQvUy48Sw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(316002)(110136005)(4326008)(86362001)(55016002)(54906003)(7696005)(8936002)(9686003)(33656002)(2906002)(66446008)(66946007)(64756008)(26005)(66476007)(52536014)(186003)(76116006)(66556008)(83380400001)(478600001)(6506007)(5660300002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: IvZBtKEdjXCHN+QhuOLEZe10+j7Qw56NwFBVZ/DlLdcrL+UcZIIfsYjU3zFwK81PAWLnT4iAUptX9z0F6cPMPYO7VB/PDgod88Ky/mk0JBxFj1hV253Cy3gzUAL+UFEd4ZrrsM6UhTi08BohYU1hRuMtTe6Vib7IXMNP8dVrFw29bKkoAvJjQ3ZBBRNBew61vtwJYkdhSclvKhIR9X+zzLnCeUJYdTIEmghMaXvBdiybLGIiuBzJEFRHJIE2iitkM5c3jlVlHHq4IksrxPXmRerjUQnfyO6caS1Vi8s3EHQX//sPgaDf95e7cYjY1emqBErD8ukpDlcRJpS/L/Cf1c1jQK9YMmSbmxRZcnj9ggFQ/ehX2bOQ4zWBmSE7EKYbVr7Ik2KGOSJEeVfcDjj5mo1gx9zKXWbbSktMgtdia2QchHlF8p8rklwq8ghn1e0/tHHM30eHn5aiGtN8XQSufH+Uc4cKGXQNZ2REHPdj0UM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5312 Original-Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(346002)(39860400002)(376002)(46966005)(478600001)(54906003)(110136005)(4326008)(6506007)(7696005)(316002)(9686003)(36906005)(26005)(186003)(2906002)(52536014)(8936002)(55016002)(336012)(47076004)(82310400002)(356005)(81166007)(82740400003)(5660300002)(83380400001)(70586007)(86362001)(33656002)(70206006); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 0e2b940e-af40-4128-1bb3-08d82e37a155 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vm0gdI7IoJHj5MCQXaO0je/wb96Sg+J6KfbpgZlZx5jPRO2yIfEPkpqnpDjflouENcTmSAue6d1+iHbx/DKbZB6kFnb5q/UPe+ys2rMi916Ot120hF677WDXhDp22Ou7U8AX4nkdwyJ8qaLg2YTS6Sf03whEaHLy8ikO2hb/7feEHh+/GhUa37BUa0oeo9xh8m4ipXHj2vTPWKqg7Hwoc9kJatWsFNA1lHlnE8pfFoMJ1sEYmK/2AdjPVhuUmXppUnAhE7rNdrJaeuumWSl9XyGX2baeRlnbicfow0Wnp77MlPvD8Y2NiRLEu+B++iJy6207xDC9OvNbgNQAitdMUDwhaJf92GGdqdBB1t/XzJkF5PVNN1t3/rl5XBXJmC8Phq8Xr//WWOSjpSE4nIAqag== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2020 12:06:21.2515 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20496fcb-142e-4da9-b544-08d82e37a5db X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4031 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Alexander Kozyrev writes: > > > > > > > Subject: RE: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for > > > > > multi- packet RQ buffer refcnt > > > > > > > > > > Hi Phil Yang, we noticed that this patch gives us 10% of > > > > > performance degradation on ARM. > > > > > x86 seems to be unaffected though. Do you know what may be the > > > > > reason of this behavior? > > > > > > > > Hi Alexander, > > > > > > > > Thanks for your feedback. > > > > This patch removed some expensive memory barriers on aarch64, it > > > > should get better performance. > > > > I am not sure the root cause of this degradation now, I will start > > > > the investigation. We can profiling this issue together. > > > > Could you share your test case(including your testbed configuration= ) > > > > with > > > us? <...> > > > > > > I'm surprised too, Phil, but looks like it is actually making things > > > worse. I used Connect-X 6DX on aarch64: > > > Linux dragon71-bf 5.4.31-mlnx.15.ge938819 #1 SMP PREEMPT Thu Jul 2 > > > 17:01:15 IDT 2020 aarch64 aarch64 aarch64 GNU/Linux Traffic generator > > > sends 60 bytes packets and DUT executes the following command: > > > arm64-bluefield-linuxapp-gcc/build/app/test-pmd/testpmd -n 4 -w > > > 0000:03:00.1,mprq_en=3D1,rxqs_min_mprq=3D1 -w > > > 0000:03:00.0,mprq_en=3D1,rxqs_min_mprq=3D1 -c 0xe -- --burst=3D64 -- > > > mbcache=3D512 -i --nb-cores=3D1 --rxq=3D1 --txq=3D1 --txd=3D256 --r= xd=3D256 > > > --auto- start --rss-udp Without a patch I'm getting 3.2mpps, and only > > > 2.9mpps when the patch is applied. > > You are running on A72 cores, is that correct? >=20 > Correct, cat /proc/cpuinfo > processor : 0 > BogoMIPS : 312.50 > Features : fp asimd evtstrm crc32 cpuid > CPU implementer : 0x41 > CPU architecture: 8 > CPU variant : 0x0 > CPU part : 0xd08 > CPU revision : 3 Thanks a lot for your input, Alex. With your test command line, I remeasured this patch on two different aarch= 64 machines and both got some performance improvement. SOC#1. On Thunderx2 (with LSE support), I see 7.6% performance improvement = on throughput.=20 NIC: ConnectX-6 / driver: mlx5_core version: 5.0-1.0.0.0 / firmware-version= : 20.27.1016 (MT_0000000224) SOC#2. On N1SDP (I disabled LSE to generate A72 likewise instructions), I a= lso see slightly (about 1%~2%) performance improvement on throughput. NIC: ConnectX-5 / driver: mlx5_core / version: 5.0-2.1.8 / firmware-version= : 16.27.2008 (MT_0000000090) Without LSE (i.e. A72 and SOC#2 case.) it uses the 'Exclusive' mechanism to= achieve atomicity. For example, it generates below instructions for __atomic_add_fetch. __atomic_add_fetch(&buf->refcnt, 1, __ATOMIC_ACQUIRE); 70118: f94037e3 ldr x3, [sp, #104] 7011c: 91002060 add x0, x3, #0x8 70120: 485ffc02 ldaxrh w2, [x0] 70124: 11000442 add w2, w2, #0x1 70128: 48057c02 stxrh w5, w2, [x0] 7012c: 35ffffa5 cbnz w5, 70120 In general, I think this patch will not lead to a sharp decline in performa= nce.=20 Maybe you can try other testbeds? Thanks, Phil