From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9381A052B; Wed, 29 Jul 2020 16:07:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CB39F04; Wed, 29 Jul 2020 16:07:58 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061.outbound.protection.outlook.com [40.107.20.61]) by dpdk.org (Postfix) with ESMTP id 0A08C2AB for ; Wed, 29 Jul 2020 16:07:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5EyfTv8r7SqMdYRcKAToya/gFAopV3CiPbO1MMWdkRA=; b=Tasjs1kEForF9SUmJG7/6M1RXGiUT/P0Z0+2DkEq0qpDpJ5c+ncPWXsi/eELtsYVT1DPx8FgMv4fSS7wv1flfJ5yFOmtMlKTh+OPI9Q4WnFCvWTJ5g5BjIObU+2DSm8SPwzuLnXuqyeBSN+PKEQDdtZo567yfBh6KdJ4tu8LicA= Received: from DB6PR07CA0057.eurprd07.prod.outlook.com (2603:10a6:6:2a::19) by AM6PR08MB4722.eurprd08.prod.outlook.com (2603:10a6:20b:c5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Wed, 29 Jul 2020 14:07:55 +0000 Received: from DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::db) by DB6PR07CA0057.outlook.office365.com (2603:10a6:6:2a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.9 via Frontend Transport; Wed, 29 Jul 2020 14:07:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT031.mail.protection.outlook.com (10.152.20.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.10 via Frontend Transport; Wed, 29 Jul 2020 14:07:55 +0000 Received: ("Tessian outbound 7de93d801f24:v62"); Wed, 29 Jul 2020 14:07:55 +0000 X-CR-MTA-TID: 64aa7808 Received: from 5025ce5f68d5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A58D1E6A-4719-40BC-9995-864A92478CA9.1; Wed, 29 Jul 2020 14:07:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5025ce5f68d5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 29 Jul 2020 14:07:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=REMjTnHocqluNTod21Rp+ymHbPF8K0wSq6tH3EDx4IMj0L0lvszI6lyVb0NcaHppDQmrbs1ZO0Y3ooYUwQIH9Hb5DVMR7HCpVW47QT/6sJojLlDLip/M+wziOJa6fQklU3xkPRdhMK2KvqgXGo2gHil2uEJi0i8vtoaW++BwRutdB9rAEkKI3TVCo9TFDs2nFT3OIeZDd74tutx6B7hcBETOw0+0k085bWkI000aaEQZ5E+zI/mpwVE6aykfZZJxt2g+Sij/CcX6hRSsBeEjks1MiWR9i67hE/PhwPChPnhDWYFdbi8Y7m+lm6ew8SuGQJCX/VRwEOYF4ayEPPqgWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5EyfTv8r7SqMdYRcKAToya/gFAopV3CiPbO1MMWdkRA=; b=UrDgR2O7oLHp39P7t23+N7y3eZop3XUOM0zkJX6YeBBacGPuA7Fy4ch4FDvCq7H7ctabS3maRHMXv3M+ynFeYjemY38/j/2hJbQaTcZiMu0Be50yK2d67jy8AE4uunoPiVZZNXK2S1obCiTrSGMto0ZNoSC+GeHf23XDN6uYdtfbMgJFJ7X/NR1qlP5CER+8i7tT/jENU8wGPlTWee6Yn3hQ27Ze3N4xsPacoix3Vg6XcMVrNyuZLPuX4rtJ1iUXgXCpUoe/k/Btg9wKSbZINJS6XNL+Iw/xWKzep2cWXn1CAG8FJCQWtx0xm38JRKTQsCWzyIp46QR0nKzOBD/39A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5EyfTv8r7SqMdYRcKAToya/gFAopV3CiPbO1MMWdkRA=; b=Tasjs1kEForF9SUmJG7/6M1RXGiUT/P0Z0+2DkEq0qpDpJ5c+ncPWXsi/eELtsYVT1DPx8FgMv4fSS7wv1flfJ5yFOmtMlKTh+OPI9Q4WnFCvWTJ5g5BjIObU+2DSm8SPwzuLnXuqyeBSN+PKEQDdtZo567yfBh6KdJ4tu8LicA= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VI1PR08MB2782.eurprd08.prod.outlook.com (2603:10a6:802:1c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.33; Wed, 29 Jul 2020 14:07:48 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::28a3:3a4e:65ca:5707]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::28a3:3a4e:65ca:5707%3]) with mapi id 15.20.3216.033; Wed, 29 Jul 2020 14:07:48 +0000 From: Phil Yang To: Viacheslav Ovsiienko , "dev@dpdk.org" CC: "matan@mellanox.com" , "rasland@mellanox.com" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , nd , nd Thread-Topic: [PATCH v2] app/testpmd: fix txonly mode timestamp intitialization Thread-Index: AQHWZaQPiFHRCaNpPEKi9L76NjeDjKkelmzw Date: Wed, 29 Jul 2020 14:07:48 +0000 Message-ID: References: <1595863595-11344-1-git-send-email-viacheslavo@mellanox.com> <1596025794-26599-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1596025794-26599-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2dd78547-9fe5-4280-a737-0a92ca01b19e.0 x-checkrecipientchecked: true Authentication-Results-Original: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [180.162.1.103] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 09f2afc8-f57b-4a51-e8ab-08d833c8ca4f x-ms-traffictypediagnostic: VI1PR08MB2782:|AM6PR08MB4722: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gOFv6bRGxHX28iodxgBjEf0+MRfgr+d0/uyck2xBnfSjgzxkt57XnPSHmfB7ULo4S08E9R2pk+LuIzn3Ow1lKZqnM84g3rDGx9P05ePcwPBuk5bIgx+nNQetlnIAQqZ8agVlPDfe+3rcAJqhrUyHLX8/ShtNI6F5WRUIHixP9zVkTva9pvlwc9jkq9sS6m3biroMyxZfbXCPbzKuG09xoXB2RlSewLTZZrPjEo+ztUFjPrl28moLIzhI0CVdvZ3g1H1Wj7+8i/i6kgl3FYJkt9XhLgk7QmwFjkUdQXBnWDbezVLcIt0x2+o81YiY7b9a58kuH+QqiDUSLxIhmeYYRA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(4326008)(52536014)(8676002)(26005)(6506007)(53546011)(8936002)(5660300002)(110136005)(186003)(54906003)(7696005)(316002)(33656002)(2906002)(66556008)(71200400001)(9686003)(478600001)(76116006)(66946007)(4744005)(66476007)(64756008)(66446008)(83380400001)(55016002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Q+Ilm6DBMMWHHHwhw+Gl74PuwttRFJLXHXQbJMOFKPFNshcDH33vTtpH7m51k/5Q/AZrDoS+6+ceE+9xjf7fGVKsYIpOCHXeQEpwHLjJvLcUSweKfTCdnVs2DMNpX79MzkcZTWI7vm8pjc2EQVMFJTvvFML6tpSsrhjnGnv1S/p3U1i9FU+xd9sdaAPzmHtUaaM0weed8bD4aZ9gQeLadcsJoyC7OwQuUCG+m0Uud7rmzLEu44++iIgySlDr0LyQ5RzbBnqAT48mfU9Z2xhmY0m7y13NPRT/3qFK/8XynuEXwOQzRh/5phCGQFz688PsrnQbkNH7GnvL6bEhew9ZGmA4+V6eq3V+DGu++OTE+B4lewruCWsIi8wQMBwd3rTL29opkReVc1nPI2PwKCLM23bUcY5cbGoaTO/s+a497XcCTx/IUdtdgwA/rACX5j47ziHSjlpUNYkiwnuf4PLb+jnRR0J1FrzzToZ9f3xytMQ= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2782 Original-Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b1d1823c-68c6-4cb5-9f5b-08d833c8c628 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j/Iv3vVPEIg1+Cca/llPzZtG3s4gCl5tToe8u+VrsVFsar6CO//aW9ai68lEkFligip3SlbuQEKuemRjeo2JyrK5IdmZ6MUy3w/rsAwYGA/eQhN+2vHDYvYHTnjv0N68x9VmazBHBnVaY6CB1gondRG1+3wxbYLZfUtYF16lMf2SSuVhMLp3Z0WvZdSEU+VRINjJu3EbllSHXX50qlA4PtkcOCRkaT5AmglAXMRspUJsMDp4Maj5dxe7Ej9v0lb4H8YLQGS2IG0pGbAmjJvEbSgLu1Hs9/eGyytV1HOaKNxOiDhcJzDeodOVnogH0QZy0Guvtafp8Vp7aFOWnd7PvahJEoBsO5P59gkIDSemk0P1rxBMex75mtuwOIa7zU0QGkiw2WCCqi+nQy7/U4pp1g== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(396003)(39860400002)(136003)(46966005)(2906002)(83380400001)(316002)(8936002)(110136005)(9686003)(70586007)(54906003)(8676002)(4326008)(356005)(70206006)(55016002)(81166007)(6506007)(47076004)(82740400003)(5660300002)(26005)(186003)(52536014)(7696005)(82310400002)(86362001)(336012)(53546011)(478600001)(33656002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2020 14:07:55.3565 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09f2afc8-f57b-4a51-e8ab-08d833c8ca4f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4722 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix txonly mode timestamp intitialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Wednesday, July 29, 2020 8:30 PM > To: dev@dpdk.org > Cc: matan@mellanox.com; rasland@mellanox.com; thomas@monjalon.net; > ferruh.yigit@intel.com; Phil Yang > Subject: [PATCH v2] app/testpmd: fix txonly mode timestamp intitializatio= n >=20 > The testpmd application forwards data in multiple threads. > In the txonly mode the Tx timestamps must be initialized > on per thread basis to provide phase shift for the packet > burst being sent. This per thread initialization was performed > on zero value of the variable in thread local storage and > happened only once after testpmd forwarding start. Executing > "start" and "stop" commands did not cause thread local variables > zeroing and wrong timestamp values were used. >=20 > Fixes: 4940344dab1d ("app/testpmd: add Tx scheduling command") >=20 > Signed-off-by: Viacheslav Ovsiienko It looks good to me.=20 Reviewed-by: Phil Yang Thanks, Phil <...>