From: Phil Yang <Phil.Yang@arm.com>
To: Shy Shyman <shys@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"beilei.xing@intel.com" <beilei.xing@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"xavier.huwei@huawei.com" <xavier.huwei@huawei.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU command
Date: Tue, 9 Jun 2020 14:44:09 +0000 [thread overview]
Message-ID: <VE1PR08MB4640C794E8294FB6FE67EAECE9820@VE1PR08MB4640.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200608141747.157249-1-shys@mellanox.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Shy Shyman
> Sent: Monday, June 8, 2020 10:18 PM
> To: dev@dpdk.org
> Cc: wenzhuo.lu@intel.com; beilei.xing@intel.com;
> bernard.iremonger@intel.com; xavier.huwei@huawei.com
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU
> command
>
> MTU is used in testpmd to set the maximum payload size for packets.
> According to testpmd, the setting influnce RX only.
> In rte_ethdev there's no relation between MTU setting and JUMBO offload
> or
> rx_max_pkt_len.
>
> The previous fix in patch referenced below was meant to update the
> correlated variables of max_pkt_len and JUMBO offload, but by doing
> so it assumes that MTU setting can only exist when JUMBO offload
> supported in the device. For example fail-safe device does supports set MTU
> and doesn't support JUMBO offload, and in this case, though set MTU
> succeeds, an error message is still printed since the JUMBO packet
> offload is disabled.
>
> The fix separates the two conditions to make sure the error
> triggers only in case the set_mtu action actually failed.
>
> Fixes: 150c9ac2df13 ("app/testpmd: update Rx offload after setting MTU")
> Cc: xavier.huwei@huawei.com
>
> Signed-off-by: Shy Shyman <shys@mellanox.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
next prev parent reply other threads:[~2020-06-09 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 9:27 [dpdk-dev] [PATCH] " Shy Shyman
2020-05-19 11:10 ` Asaf Penso
2020-05-19 14:15 ` Iremonger, Bernard
2020-05-19 14:57 ` Ferruh Yigit
2020-05-19 16:40 ` Shy Shyman
2020-05-20 14:14 ` Ferruh Yigit
2020-06-08 14:17 ` [dpdk-dev] [PATCH v2] " Shy Shyman
2020-06-08 15:04 ` Ferruh Yigit
2020-06-09 14:44 ` Phil Yang [this message]
2020-06-09 14:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB4640C794E8294FB6FE67EAECE9820@VE1PR08MB4640.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=shys@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).