From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2210A04FE; Tue, 9 Jun 2020 16:44:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 581601BC24; Tue, 9 Jun 2020 16:44:20 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60056.outbound.protection.outlook.com [40.107.6.56]) by dpdk.org (Postfix) with ESMTP id 745AF1B951 for ; Tue, 9 Jun 2020 16:44:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alYNrp0PJGqlxYuOCinH9gi9lXTcvyWUKCIpWvBunGE=; b=kdj6tzkqtNtzrR0/jGClybx96kQRCTuOjekC8MzcarIhxIeJ/mxijjQvT39RwsOSLQAsAKqT+d9IHQguX+HJm3yo/zT5o98C/7umOPHKq6J8z+a954vf2gLwUBdHl0orTajJIuXRwmycqWQ/LBmcAPvosRS+jk2U8mgWsZkCjoo= Received: from DB6PR0801CA0061.eurprd08.prod.outlook.com (2603:10a6:4:2b::29) by VI1PR0801MB2127.eurprd08.prod.outlook.com (2603:10a6:800:50::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.20; Tue, 9 Jun 2020 14:44:16 +0000 Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::19) by DB6PR0801CA0061.outlook.office365.com (2603:10a6:4:2b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18 via Frontend Transport; Tue, 9 Jun 2020 14:44:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18 via Frontend Transport; Tue, 9 Jun 2020 14:44:16 +0000 Received: ("Tessian outbound 8bb15bb571b3:v59"); Tue, 09 Jun 2020 14:44:16 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9472ea9c174c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E74299F8-FA17-4767-88D5-048AABA01566.1; Tue, 09 Jun 2020 14:44:11 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9472ea9c174c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Jun 2020 14:44:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8/LAhQAl4TzYrkTPuDr6L3Q+/ekAyvcje0ApknzQegbUmxQ8mZOEetJDb4FIVnGo4cp3m55fc/1J1cK2hqGBGoNEdSlPKYuEP4ZRhbgJCiOBOsIzpJzBpwGePyfBls7fq3c2N2G3wL7d+k6ToGQAK1wtzDiX+5ps7Sfe6InLW9VB3NDWk0HyWlXF447DTsnbxwKH5zosTfcMmNo50QCrVI6X9Lc831XwSxqeyxlKhe4GXV3Tx7oKtM2EG6cF9KrikzgfVCLsnJ3FLBGCBteovU3L+OkmVrnppv/Zzn6WdkpvAoPLDYftb4yuyELjkWt1TUDsA/KUMeygTmFH3dqUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alYNrp0PJGqlxYuOCinH9gi9lXTcvyWUKCIpWvBunGE=; b=V0aoPhwq33FnfjPnzkMzNfEjywJzlRvlrPF3BpKzD0Q0azWqqaCFiJH5kWR+uIbdhii0w+paw78ITfWx1dt3OHcWvZjomj04PXNgrC43rG459Wvg91K7gBHKZLzYKFLalvVrRpadcNNwRLKjTit7/So+SZFws+fOk78Tq3XTJwzHhbuHsApGa7qGSMP8z54Spm3DfRYymA/64/1EVrtt5p11hsXCZp2v1gNMw+83lmMzrZYUbUF2HQDeymcqHY0zXCfl9bziBFvU444AbRvJwJ61G3YqlvnKrxzt/f8mb2RiYmUZkUW1G8tazhoHkm3lxsH9V2KqcbEciOIqiYOA+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alYNrp0PJGqlxYuOCinH9gi9lXTcvyWUKCIpWvBunGE=; b=kdj6tzkqtNtzrR0/jGClybx96kQRCTuOjekC8MzcarIhxIeJ/mxijjQvT39RwsOSLQAsAKqT+d9IHQguX+HJm3yo/zT5o98C/7umOPHKq6J8z+a954vf2gLwUBdHl0orTajJIuXRwmycqWQ/LBmcAPvosRS+jk2U8mgWsZkCjoo= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VE1PR08MB5006.eurprd08.prod.outlook.com (2603:10a6:803:113::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.20; Tue, 9 Jun 2020 14:44:09 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 14:44:09 +0000 From: Phil Yang To: Shy Shyman , "dev@dpdk.org" CC: "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" , "xavier.huwei@huawei.com" , nd Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU command Thread-Index: AQHWPZ+tG6rzW/gxx02b761DRzeCdKjQXR/g Date: Tue, 9 Jun 2020 14:44:09 +0000 Message-ID: References: <20200518092704.188832-1-shys@mellanox.com> <20200608141747.157249-1-shys@mellanox.com> In-Reply-To: <20200608141747.157249-1-shys@mellanox.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: deb7ae6d-0d2a-4b70-b63c-dc629e2c2e69.0 x-checkrecipientchecked: true Authentication-Results-Original: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.111] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6dca3210-a3a2-4f57-47ee-08d80c8395cc x-ms-traffictypediagnostic: VE1PR08MB5006:|VI1PR0801MB2127: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; x-forefront-prvs: 042957ACD7 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nroKf6dLfHxEQTrwlT4v59yAszPd62mL9jgnAgcxTJS6XtFpxqcfm6eUPeuh00uzrLN8lNee9kO04CEJeD8JzEsvq6s3OFVe0PHKtl/w0OIOgmDYwDbkRLji2Gg76Ljahjdd/AEUhG3sI5HPRnz/ct6UkcNhnLDGdVYnx/BckEGwe5hSBKqZlwGEMfbtK/hk6sh2FdPrPCalXqE29ym86MxVzgG9lwBaytfRSauq5ycOiDDF13WgEBzrNKLsc7oc9dZ+dWpP8HRUvJEpnfMZ6SHO8tfXepFwvqqMrjp/NJPcjer5WDwW5TfEnRRSyPeLQvtgTjayxo2vC8+9X0vmDQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(2906002)(86362001)(66476007)(76116006)(71200400001)(478600001)(8936002)(64756008)(316002)(33656002)(66556008)(5660300002)(26005)(66946007)(186003)(83380400001)(66446008)(4326008)(54906003)(55016002)(53546011)(7696005)(9686003)(6506007)(110136005)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: zV6K99bPxXcPc/wTckgesJchaSu1erFqu53phDAWWBTfD1QGoORw0wkJfgw5tMQa4p/hJ6fd9tx2r4/ywraAyK1uWK6hhOZ6jL2rrUjxwuBychlO+yh5ZQyOw0eAqO1VlHlM0KN1OQ3M1aqT983A3cjWDL8SAsKy8rQKWtvAZ4HktnFf3Khkd2FCGfrGG4uLvGyRLniIDjzXnZ4AkBjuCbiGw6uONCJbSYSABZcaDOEJc7Zsvx591Eips/qzWC7GUcqpGVKi19GOHPQtSSUZ4vPP3aPmp9x8VymnUHlDeXD5c7IVN53LDkpa3+0n4NMDYL+hvbTsnX7aqkc+KxB7s9PLNRowjPBiYYOWvPx60kvQxm5kbX7SM6rEsAzMtd+RBGXc0b/fdgVoqwskTuCb8tUSZJ3REmLnyHxtJQcpmD1+b+mZCHEZbNUmRBxRw89fPVHHTyKOBe4CNFlVI1cgXtgyS/5H6wkuYWAwghTJxk0= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5006 Original-Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(136003)(396003)(39860400002)(376002)(46966005)(82310400002)(26005)(186003)(356005)(4326008)(82740400003)(47076004)(52536014)(8936002)(81166007)(478600001)(83380400001)(316002)(110136005)(5660300002)(9686003)(70206006)(86362001)(6506007)(53546011)(2906002)(54906003)(7696005)(70586007)(336012)(33656002)(55016002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 4cc2345e-348e-4d49-43d3-08d80c8391b7 X-Forefront-PRVS: 042957ACD7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4pQMTKqHpCTUh1NmGnK/tHinfjYtPVNQRuvcV5TNqgWxdS/myXhrfwi3Wye9NUq+PwfpVdPZHWcwbnuSKksIRXxcJCJyxUlu5oZXgTP0e2Sq3KjekgjTxWaezLy9YhBrQH9WDwgi9mtDQtpnNzG5+NVXvF55ZqZ8aiRcSYSUs0/3lo8rLoI8GGWYVMzxDwNrjIWTF0+88LNjGJ8wulml2PI3lnBGjP+4x7hMaQapSXWAgeVBLQN4R2UJF8cSKuBMhb3TnQiHUZ0SveGWzpeqgPvoh/PysIzH4TE0pw7u7d9krXgd6jWrN1LP1sBdvQVw2sRRImcyWNK0J1Du8XygtWE+mO1p3J56LLdq5Ew4wazfgohoYFTJyggjol0zPqZsc1566VN2SNXI4g0hCFMQyw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2020 14:44:16.6292 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6dca3210-a3a2-4f57-47ee-08d80c8395cc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2127 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Shy Shyman > Sent: Monday, June 8, 2020 10:18 PM > To: dev@dpdk.org > Cc: wenzhuo.lu@intel.com; beilei.xing@intel.com; > bernard.iremonger@intel.com; xavier.huwei@huawei.com > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU > command >=20 > MTU is used in testpmd to set the maximum payload size for packets. > According to testpmd, the setting influnce RX only. > In rte_ethdev there's no relation between MTU setting and JUMBO offload > or > rx_max_pkt_len. >=20 > The previous fix in patch referenced below was meant to update the > correlated variables of max_pkt_len and JUMBO offload, but by doing > so it assumes that MTU setting can only exist when JUMBO offload > supported in the device. For example fail-safe device does supports set M= TU > and doesn't support JUMBO offload, and in this case, though set MTU > succeeds, an error message is still printed since the JUMBO packet > offload is disabled. >=20 > The fix separates the two conditions to make sure the error > triggers only in case the set_mtu action actually failed. >=20 > Fixes: 150c9ac2df13 ("app/testpmd: update Rx offload after setting MTU") > Cc: xavier.huwei@huawei.com >=20 > Signed-off-by: Shy Shyman Reviewed-by: Phil Yang