From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E111A2EEB for ; Tue, 10 Sep 2019 00:33:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 479DE1ED4D; Tue, 10 Sep 2019 00:33:37 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10055.outbound.protection.outlook.com [40.107.1.55]) by dpdk.org (Postfix) with ESMTP id 985362BE6 for ; Tue, 10 Sep 2019 00:33:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RtHtXbwfauhat8qtANlSw5kJCggurLFF464HehUrteE=; b=dZtk4EyZVMg0ByU3hmN4OA0BSWIa/ILf0yCa1viNBmfGoyfSPz01/HAm5JOqBIwE7bgiH2y+qiKVUWcE+norlexIja1b0TglPih9d1rhlOVHAS80BRu1ZLZX9OKDuWByEk7d6cJxRZ15aa7bKDgtnDJ6r9LHINCw9gpACZ1WkbU= Received: from DB7PR08CA0068.eurprd08.prod.outlook.com (2603:10a6:10:26::45) by AM0PR08MB4132.eurprd08.prod.outlook.com (2603:10a6:208:127::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Mon, 9 Sep 2019 22:33:32 +0000 Received: from VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::200) by DB7PR08CA0068.outlook.office365.com (2603:10a6:10:26::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15 via Frontend Transport; Mon, 9 Sep 2019 22:33:32 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT034.mail.protection.outlook.com (10.152.18.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14 via Frontend Transport; Mon, 9 Sep 2019 22:33:31 +0000 Received: ("Tessian outbound 1b0c40e33850:v28"); Mon, 09 Sep 2019 22:33:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 88f6c64b01e47188 X-CR-MTA-TID: 64aa7808 Received: from c62cb7d0d1c8.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.8.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id AA58D80B-35EC-4A02-A941-398036364A5A.1; Mon, 09 Sep 2019 22:33:20 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c62cb7d0d1c8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Mon, 09 Sep 2019 22:33:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C5dFJOM1v+JoYGyeNvl+ETHNoAA2ENl5iLRmOwbGO40wIq7PoCma8jWkJOgaAxI3WKxTh2XC6yQwpJTw0eHPQlffSgF9bdK0crLUDjMyxQ4ryjqdJqM92c5PKemylnfKhbB4Y8V8LrOGpIpZwoIX9I2MFAhNTyjtTrHbgZs9gkHSjR3xQCSD8kbU6jMKOtLfmhrFNIQN/o5bjzUNO1tDlMSzMLB1iCJa+8gmxUDgNdiXyJz2PyYo43i2RNTc5+iC4X/YN+jpW3+CEBtvJApKZX/AMtifcv24ivbTixX7wKyA+28vRwo73VHc8pm7hpxzjsGJbpM+XEf+HOwNi4ENvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RtHtXbwfauhat8qtANlSw5kJCggurLFF464HehUrteE=; b=Et9Ts+ybWFcT7AguhP4sbtfDTcvO4HYQayUB9IAWtqAoBpo4GZNBTcJG6xfwp6G9VOhip/LIfJMjhuopQDopbqY8HxEAOzYYFJLHGamfjyHNp5zjyBJsyJ6hIr1VVzLqMDu0MQDWcSTjYDZBnnGRHHJpt67ahyBperphuUzgiNa7WNo4vYN3gI36fN5sKfZVFxrWLIz5Dn5V/PMxS49C27HASwIQkcsEmvvGhV32ztfBb/8gkTyg28WvNIf2hFxhgy4tlYqhxQAlz7RIDzYEyh9NI8JA8Xs8aKEDpc10zCyL/jizchVryKkQ1KV3aRqrW0HItC7XzaK8g4TUe2YU1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RtHtXbwfauhat8qtANlSw5kJCggurLFF464HehUrteE=; b=dZtk4EyZVMg0ByU3hmN4OA0BSWIa/ILf0yCa1viNBmfGoyfSPz01/HAm5JOqBIwE7bgiH2y+qiKVUWcE+norlexIja1b0TglPih9d1rhlOVHAS80BRu1ZLZX9OKDuWByEk7d6cJxRZ15aa7bKDgtnDJ6r9LHINCw9gpACZ1WkbU= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB4864.eurprd08.prod.outlook.com (10.255.113.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.19; Mon, 9 Sep 2019 22:33:18 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::5050:1354:f0bd:4b92]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::5050:1354:f0bd:4b92%7]) with mapi id 15.20.2241.018; Mon, 9 Sep 2019 22:33:18 +0000 From: Honnappa Nagarahalli To: Bruce Richardson , Stephen Hemminger CC: "olivier.matz@6wind.com" , "yipeng1.wang@intel.com" , "sameh.gobriel@intel.com" , "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "pbhagavatula@marvell.com" , "jerinj@marvell.com" , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH v2 2/6] lib/ring: add template to support different element sizes Thread-Index: AQHVZ16U6SGA9ReNgkKtsfRevVDBEg== Date: Mon, 9 Sep 2019 22:33:18 +0000 Message-ID: References: <20190828144614.25284-1-honnappa.nagarahalli@arm.com> <20190906190510.11146-1-honnappa.nagarahalli@arm.com> <20190906190510.11146-3-honnappa.nagarahalli@arm.com> <20190908204436.52fd804b@xps13> <20190909090111.GA1886@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190909090111.GA1886@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 16cf4062-c045-44b7-b19b-e667b04be270.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 887071ba-9dd2-46a1-cc96-08d73575be43 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4864; X-MS-TrafficTypeDiagnostic: VE1PR08MB4864:|VE1PR08MB4864:|AM0PR08MB4132: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219; x-forefront-prvs: 01559F388D X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(346002)(366004)(136003)(39860400002)(189003)(199004)(13464003)(53546011)(14454004)(66946007)(3846002)(102836004)(66446008)(478600001)(6506007)(9686003)(54906003)(64756008)(8676002)(7736002)(305945005)(11346002)(446003)(76116006)(186003)(8936002)(52536014)(25786009)(99286004)(53936002)(66476007)(71190400001)(71200400001)(486006)(4326008)(55016002)(6436002)(6246003)(33656002)(110136005)(2906002)(476003)(66066001)(6116002)(256004)(5660300002)(26005)(316002)(76176011)(81156014)(74316002)(81166006)(86362001)(7696005)(229853002)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4864; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: pR/EcAnFHUzxmdOXlEx6omx5X0RTR8BPSjf0nZC5bjBNW+2/ZBqibe5edV2b6tXGogKR6hKMZz+fklDtEiCmHshwnZ446VDj8H/Zd3BqB7bT3mA6uy55z91VXbN0XZUP14O0zBhh9MBruBaC//LNLqn24mkcn8v8dN8MlfLGFrvlNXyeRA8bdVa2Ck0Hl9rHXyY3HUm8ll/abNyR0/APHaYElaMzbVayF+I0edGS8cXhe5V2n+e2Tv4kRbLK6ZpCTYjWeOhKacJ1KVD5+SWEh7ebXx10dtZogzp8IZtf6F0gb0aW1636/XvjPX7NwdIg9Mol+rZUkTQymctoiB4QIvzxhPBURs3EkCDVeYLEE7ldA7kY53acJaDgbITPgWROA9NQz8kv+IFOhr4t6ViBPZdKtBjuLQ0X/iCoOZpiRAo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4864 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT034.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(346002)(39860400002)(376002)(2980300002)(199004)(189003)(13464003)(99286004)(26826003)(97756001)(14454004)(22756006)(70586007)(316002)(36906005)(46406003)(70206006)(110136005)(54906003)(47776003)(5660300002)(76130400001)(4326008)(63370400001)(446003)(11346002)(86362001)(81156014)(8676002)(63350400001)(26005)(50466002)(486006)(126002)(476003)(229853002)(7696005)(356004)(6246003)(66066001)(102836004)(336012)(186003)(33656002)(53546011)(6506007)(76176011)(25786009)(9686003)(6116002)(52536014)(3846002)(23726003)(81166006)(2906002)(74316002)(305945005)(478600001)(7736002)(8936002)(8746002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4132; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 458779f3-9324-4aef-53bb-08d73575b6ae X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB4132; NoDisclaimer: True X-Forefront-PRVS: 01559F388D X-Microsoft-Antispam-Message-Info: YQPbN9w/RRbZd/7AxyIPlhV8ytoOshTNhXYKxqnBsimkqGxdpdZGAU+OqG4fkWXAt7caP9iSD0hB7VP+dWca1O0mv+JmU6Ld9w595JB1CeGogOnbJ7NPI8gj4Hgb8UrBKSWvqNwhYkIaWyy/cbdKJxFk0UaNxnJjWyYPeQk6Nhw1a/zBDLWvPbTYXUyes/2pmPUZ9rX0jOLWx7lniOYYYohUk31BC91hjZBYLgrBy/OE5XtkLhAzJRWE7POOcvPLTOjO6imrCznr0khgqybOt1K12x+up7oPKM6DHAS8RYL/UUSUY8GVhjqzPbPIW9dDYbLQhiMtbf4ZHx42KOjrOKcZ1H9GbIcv4PRnBs72QBbhx3UiQFGsqW/h9aJpObukcc48UIqkIpSIL7IVflFo6naqA5GfDoNZEmfVZRCckIc= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2019 22:33:31.4423 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 887071ba-9dd2-46a1-cc96-08d73575be43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4132 Subject: Re: [dpdk-dev] [PATCH v2 2/6] lib/ring: add template to support different element sizes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Monday, September 9, 2019 4:01 AM > To: Stephen Hemminger > Cc: Honnappa Nagarahalli ; > olivier.matz@6wind.com; yipeng1.wang@intel.com; > sameh.gobriel@intel.com; pablo.de.lara.guarch@intel.com; dev@dpdk.org; > pbhagavatula@marvell.com; jerinj@marvell.com > Subject: Re: [dpdk-dev] [PATCH v2 2/6] lib/ring: add template to support > different element sizes >=20 > On Sun, Sep 08, 2019 at 08:44:36PM +0100, Stephen Hemminger wrote: > > On Fri, 6 Sep 2019 14:05:06 -0500 > > Honnappa Nagarahalli wrote: > > > > > Add templates to support creating ring APIs with different ring > > > element sizes. > > > > > > Signed-off-by: Honnappa Nagarahalli > > > Reviewed-by: Dharmik Thakkar > > > Reviewed-by: Gavin Hu > > > Reviewed-by: Ruifeng Wang > > > > Understand the desire for generic code, but macro's are much harder to > > maintain and debug. Would it be possible to use inline code taking a > > size argument and let compiler optimizations with constant folding do t= he > same thing. > > > > Sorry, I vote NO for large scale use of macro's. >=20 > I would tend to agree. This use of macros makes the code very awkward to > read and understand. Stephen, Bruce, thank you for your feedback. Looks like we at least have a= n agreement on the problem definition, hopefully we can find a solution. I = will try to rework this and get back with solutions/problems.