From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20078.outbound.protection.outlook.com [40.107.2.78]) by dpdk.org (Postfix) with ESMTP id C57D91B3C0 for ; Thu, 4 Apr 2019 17:30:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ry6F0GowTawbPuYdKsd7WILv6frRwOX9Zd0d0QJ5F58=; b=pEbSHd9+3iYZ5/AuNu62FVWdcANtJb/rWZwTyXhcwLBUeDGTw2FSriFgK+I7SyYdYcJHL8VZDcChS9AdWoIeRKeIqGXLz5zfe/CvkEyrljaNBevgIBzYVxSWMBwHQW8hT02rB2Y8uT1nP1z/5EF5YnhX+jk4Q/+9TFsJoVVxSm8= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5198.eurprd08.prod.outlook.com (20.179.31.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.15; Thu, 4 Apr 2019 15:30:05 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177%2]) with mapi id 15.20.1771.016; Thu, 4 Apr 2019 15:30:05 +0000 From: Honnappa Nagarahalli To: "Phil Yang (Arm Technology China)" , "dev@dpdk.org" , "thomas@monjalon.net" CC: "david.hunt@intel.com" , "reshma.pattan@intel.com" , "Gavin Hu (Arm Technology China)" , "Phil Yang (Arm Technology China)" , nd , nd Thread-Topic: [PATCH v3 2/3] test/distributor: replace sync builtins with atomic builtins Thread-Index: AQHU6etCEepRv6x1rEe+HkQV9XVLUqYsInBw Date: Thu, 4 Apr 2019 15:30:05 +0000 Message-ID: References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1554274796-23258-1-git-send-email-phil.yang@arm.com> <1554274796-23258-3-git-send-email-phil.yang@arm.com> In-Reply-To: <1554274796-23258-3-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3e51746-6277-4afd-db43-08d6b91269c9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5198; x-ms-traffictypediagnostic: VE1PR08MB5198: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0997523C40 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(136003)(39860400002)(199004)(189003)(68736007)(81156014)(4326008)(9686003)(55016002)(6246003)(11346002)(446003)(52536014)(53936002)(72206003)(6506007)(55236004)(102836004)(8676002)(478600001)(26005)(476003)(5660300002)(486006)(316002)(54906003)(33656002)(25786009)(110136005)(8936002)(186003)(7696005)(76176011)(81166006)(14454004)(97736004)(229853002)(74316002)(305945005)(7736002)(2906002)(86362001)(105586002)(256004)(66066001)(6436002)(71200400001)(71190400001)(106356001)(2501003)(2201001)(99286004)(6116002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5198; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: wfu1l/8OBzpQFWnXX4AHfBlgOxrHu1ijNUd3uK7GPqwWODviEaXHi2hE8ad2Z9zxeTjAITMOlkpgNMbj1PuHNM+tlBWAFcQTSc9goyRKEJh5ZUNxUwo5QON7GvHp4fmfEfD9YN1o6Bw5vrbut/W3wFTHK5O5qraeQMBwhFv0hRqNccgfB5Wr3uC5xUAaL5w1sdUHuBTxSaASMXzHoIGfbJE9rk2xFiB/UxMk1iL5GiUrUl4tMCzM1Mgg2kRYL12HF/jp1sF/grLL4sLGSi9u1/iwUQDLi2qF3zqNsSgixQ/RuuqfY1G/3AWAIqFZmlQDt9cbfQfaE4ngYXpOSsu2C68mq9v/u9bfZpWuzMpCcV95d4ztT8kml9Yb9Zn0LcRGr+BGY1BWuhFprSiveIPbkwY6n+aSUaIqSLxC0F202Qo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3e51746-6277-4afd-db43-08d6b91269c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2019 15:30:05.3519 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5198 Subject: Re: [dpdk-dev] [PATCH v3 2/3] test/distributor: replace sync builtins with atomic builtins X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 15:30:08 -0000 >=20 > '__sync' built-in functions are deprecated, should use the '__atomic' > built-in instead. the sync built-in functions are full barriers, while at= omic > built-in functions offer less restrictive one-way barriers, which help > performance. >=20 > Here is the example test result on TX2: > sudo ./arm64-armv8a-linuxapp-gcc/app/test -l 112-139 \ -n 4 --socket- > mem=3D1024,1024 -- -i > RTE>>distributor_perf_autotest >=20 > *** distributor_perf_autotest without this patch *** =3D=3D=3D=3D Cache l= ine switch > test =3D=3D=3D Time for 33554432 iterations =3D 1519202730 ticks Ticks pe= r iteration > =3D 45 >=20 > *** distributor_perf_autotest with this patch *** =3D=3D=3D=3D Cache line= switch test > =3D=3D=3D Time for 33554432 iterations =3D 1251715496 ticks Ticks per ite= ration =3D 37 >=20 > Less ticks needed for the cache line switch test. It got 17% of performan= ce > improvement. >=20 > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang > Reviewed-by: Joyce Kong > Reviewed-by: Dharmik Thakkar > --- Reviewed-by: Honnappa Nagarahalli From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3405EA0679 for ; Thu, 4 Apr 2019 17:30:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E85591B3DA; Thu, 4 Apr 2019 17:30:08 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20078.outbound.protection.outlook.com [40.107.2.78]) by dpdk.org (Postfix) with ESMTP id C57D91B3C0 for ; Thu, 4 Apr 2019 17:30:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ry6F0GowTawbPuYdKsd7WILv6frRwOX9Zd0d0QJ5F58=; b=pEbSHd9+3iYZ5/AuNu62FVWdcANtJb/rWZwTyXhcwLBUeDGTw2FSriFgK+I7SyYdYcJHL8VZDcChS9AdWoIeRKeIqGXLz5zfe/CvkEyrljaNBevgIBzYVxSWMBwHQW8hT02rB2Y8uT1nP1z/5EF5YnhX+jk4Q/+9TFsJoVVxSm8= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5198.eurprd08.prod.outlook.com (20.179.31.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.15; Thu, 4 Apr 2019 15:30:05 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177%2]) with mapi id 15.20.1771.016; Thu, 4 Apr 2019 15:30:05 +0000 From: Honnappa Nagarahalli To: "Phil Yang (Arm Technology China)" , "dev@dpdk.org" , "thomas@monjalon.net" CC: "david.hunt@intel.com" , "reshma.pattan@intel.com" , "Gavin Hu (Arm Technology China)" , "Phil Yang (Arm Technology China)" , nd , nd Thread-Topic: [PATCH v3 2/3] test/distributor: replace sync builtins with atomic builtins Thread-Index: AQHU6etCEepRv6x1rEe+HkQV9XVLUqYsInBw Date: Thu, 4 Apr 2019 15:30:05 +0000 Message-ID: References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1554274796-23258-1-git-send-email-phil.yang@arm.com> <1554274796-23258-3-git-send-email-phil.yang@arm.com> In-Reply-To: <1554274796-23258-3-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3e51746-6277-4afd-db43-08d6b91269c9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5198; x-ms-traffictypediagnostic: VE1PR08MB5198: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0997523C40 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(136003)(39860400002)(199004)(189003)(68736007)(81156014)(4326008)(9686003)(55016002)(6246003)(11346002)(446003)(52536014)(53936002)(72206003)(6506007)(55236004)(102836004)(8676002)(478600001)(26005)(476003)(5660300002)(486006)(316002)(54906003)(33656002)(25786009)(110136005)(8936002)(186003)(7696005)(76176011)(81166006)(14454004)(97736004)(229853002)(74316002)(305945005)(7736002)(2906002)(86362001)(105586002)(256004)(66066001)(6436002)(71200400001)(71190400001)(106356001)(2501003)(2201001)(99286004)(6116002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5198; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: wfu1l/8OBzpQFWnXX4AHfBlgOxrHu1ijNUd3uK7GPqwWODviEaXHi2hE8ad2Z9zxeTjAITMOlkpgNMbj1PuHNM+tlBWAFcQTSc9goyRKEJh5ZUNxUwo5QON7GvHp4fmfEfD9YN1o6Bw5vrbut/W3wFTHK5O5qraeQMBwhFv0hRqNccgfB5Wr3uC5xUAaL5w1sdUHuBTxSaASMXzHoIGfbJE9rk2xFiB/UxMk1iL5GiUrUl4tMCzM1Mgg2kRYL12HF/jp1sF/grLL4sLGSi9u1/iwUQDLi2qF3zqNsSgixQ/RuuqfY1G/3AWAIqFZmlQDt9cbfQfaE4ngYXpOSsu2C68mq9v/u9bfZpWuzMpCcV95d4ztT8kml9Yb9Zn0LcRGr+BGY1BWuhFprSiveIPbkwY6n+aSUaIqSLxC0F202Qo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3e51746-6277-4afd-db43-08d6b91269c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2019 15:30:05.3519 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5198 Subject: Re: [dpdk-dev] [PATCH v3 2/3] test/distributor: replace sync builtins with atomic builtins X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190404153005.BmvM1xco2uZcp9M5wKyAKnBZ6XjOOVg18mczSKlp3LA@z> >=20 > '__sync' built-in functions are deprecated, should use the '__atomic' > built-in instead. the sync built-in functions are full barriers, while at= omic > built-in functions offer less restrictive one-way barriers, which help > performance. >=20 > Here is the example test result on TX2: > sudo ./arm64-armv8a-linuxapp-gcc/app/test -l 112-139 \ -n 4 --socket- > mem=3D1024,1024 -- -i > RTE>>distributor_perf_autotest >=20 > *** distributor_perf_autotest without this patch *** =3D=3D=3D=3D Cache l= ine switch > test =3D=3D=3D Time for 33554432 iterations =3D 1519202730 ticks Ticks pe= r iteration > =3D 45 >=20 > *** distributor_perf_autotest with this patch *** =3D=3D=3D=3D Cache line= switch test > =3D=3D=3D Time for 33554432 iterations =3D 1251715496 ticks Ticks per ite= ration =3D 37 >=20 > Less ticks needed for the cache line switch test. It got 17% of performan= ce > improvement. >=20 > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang > Reviewed-by: Joyce Kong > Reviewed-by: Dharmik Thakkar > --- Reviewed-by: Honnappa Nagarahalli