From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: nd <nd@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: remove compiler barrier for aarch64
Date: Wed, 28 Aug 2019 22:48:31 +0000 [thread overview]
Message-ID: <VE1PR08MB5149AC8B9BCFB99DDACC91BC98A30@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1565693011-33998-3-git-send-email-gavin.hu@arm.com>
>
> As packet length extraction code was simplified,the ordering was not
> necessary any more.[1]
IMO, there is no relationship between the compiler barrier and [1] at least on Arm platforms. I suggest we just say 'there is no reason for the compiler barrier'.
I think this compiler barrier is not required for x86/PPC as well.
>
> 2% performance gain was measured on Marvell ThunderX2.
> 4.3% performance gain was measure on Ampere eMAG80
>
> [1] http://mails.dpdk.org/archives/dev/2016-April/037529.html
>
> Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Steve Capper <steve.capper@arm.com>
> ---
> drivers/net/i40e/i40e_rxtx_vec_neon.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c
> b/drivers/net/i40e/i40e_rxtx_vec_neon.c
> index 5555e9b..864eb9a 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c
> @@ -307,9 +307,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq,
> struct rte_mbuf **rx_pkts,
> rte_mbuf_prefetch_part2(rx_pkts[pos + 3]);
> }
>
> - /* avoid compiler reorder optimization */
> - rte_compiler_barrier();
> -
> /* pkt 3,4 shift the pktlen field to be 16-bit aligned*/
> uint32x4_t len3 =
> vshlq_u32(vreinterpretq_u32_u64(descs[3]),
> len_shl);
> --
> 2.7.4
next prev parent reply other threads:[~2019-08-28 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 10:43 [dpdk-dev] [PATCH 0/2] i40e neon vPMD optiomization " Gavin Hu
2019-08-13 10:43 ` [dpdk-dev] [PATCH 1/2] net/i40e: desc loading is unnecessarily ordered " Gavin Hu
2019-08-28 22:09 ` Honnappa Nagarahalli
2019-08-30 8:33 ` Gavin Hu (Arm Technology China)
2019-08-13 10:43 ` [dpdk-dev] [PATCH 2/2] net/i40e: remove compiler barrier " Gavin Hu
2019-08-28 22:48 ` Honnappa Nagarahalli [this message]
2019-08-30 8:51 ` Gavin Hu (Arm Technology China)
2019-09-04 7:49 ` [dpdk-dev] [PATCH 0/2] i40e neon vPMD optiomization " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB5149AC8B9BCFB99DDACC91BC98A30@VE1PR08MB5149.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).