From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EED46A0487 for ; Fri, 5 Jul 2019 08:08:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2CC62F42; Fri, 5 Jul 2019 08:08:19 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by dpdk.org (Postfix) with ESMTP id A7F062E83 for ; Fri, 5 Jul 2019 08:08:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=avxB7j2j28JKMszAHOQkb78/vidOSltfdI1nvb8ShCU=; b=2gS/7/7Pv7Qq5AqqkbzvSEir0gGUsQLu2m/u9NX/gXj9xFwtH6Rr6RIrCcHIcOnAnSm+q8ab1j6572lUR3uItiCOU0mJ1qMdgcZcDcglwW9FalfqODW8IdDUj2T21szvHXvgO6w0nrYwDVtE1dLivin2XlGpycgEjUnAWcxuG40= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5214.eurprd08.prod.outlook.com (10.255.159.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Fri, 5 Jul 2019 06:08:17 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a89e:33:fbda:ed35]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a89e:33:fbda:ed35%4]) with mapi id 15.20.2052.010; Fri, 5 Jul 2019 06:08:17 +0000 From: Honnappa Nagarahalli To: "jerinj@marvell.com" , "yipeng1.wang@intel.com" , "sameh.gobriel@intel.com" , "bruce.richardson@intel.com" , "pablo.de.lara.guarch@intel.com" CC: "Gavin Hu (Arm Technology China)" , "Ruifeng Wang (Arm Technology China)" , "dev@dpdk.org" , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free Thread-Index: AQHVMvgJ1EuXqNxiKE22WFNW6i9BhQ== Date: Fri, 5 Jul 2019 06:08:17 +0000 Message-ID: References: <20190625211520.43181-1-honnappa.nagarahalli@arm.com> <20190702211634.37940-1-honnappa.nagarahalli@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: a8972684-0482-4abe-a37d-e5bc40c708c6.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1330d1a-fdef-4769-40d0-08d7010f2c2d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5214; x-ms-traffictypediagnostic: VE1PR08MB5214: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 008960E8EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(189003)(199004)(478600001)(316002)(305945005)(110136005)(54906003)(73956011)(66476007)(76176011)(6116002)(3846002)(2906002)(7736002)(66556008)(14454004)(64756008)(66446008)(76116006)(26005)(486006)(186003)(2501003)(74316002)(7696005)(66946007)(52536014)(11346002)(102836004)(476003)(446003)(8936002)(6436002)(81156014)(71190400001)(71200400001)(33656002)(99286004)(5660300002)(8676002)(14444005)(256004)(55016002)(229853002)(53936002)(6506007)(9686003)(86362001)(25786009)(68736007)(6246003)(4326008)(66066001)(81166006)(2201001)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5214; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dQRSf2/xfaPD48Pzof1d2mNTL+gKLvPtGq9GHfwXhf8BnWljlQr4Jq4ajrMLHQqa30z64L6AXEl5EwsmkRnxcTVQRLyPSLv1se79Q6YeyxtYwtpVqG7eQs3gBv3z2fh2oO7ye2RQbGTqBlzjDcIMU1lVelodtvzL+FYYtdAhN+yfGUDVEGIE1s2GylOsuaqSxM4ZrhcpoVr9Dv7rcoGo7Zo1GqiMyn4d9rkHGDhwBJTTpqzHw77Srr4i7yC3QpBPwaY+0FFViY5wfE76XgzREGxJEpvqDNOHWsQdOnRWItfyaIGnVUBEKarS+MEExMbAJjcqq9vFkJ79cudTR1aYmMIW0YHUlg81kyZKxUgU2L8Jph8Wu4D25dfIXPxmO00POXZym6qWCKLQ8TGKmUjHojJn+ijWYTHqEhQc1Et1To0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1330d1a-fdef-4769-40d0-08d7010f2c2d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2019 06:08:17.1556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Honnappa.Nagarahalli@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5214 Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > [Snip] >=20 > > The first patch in this series moves the signature comparison before > > the load- acquire of the key_index. This does not result in any issues > > because of the full key comparison which is done after the load-acquire= of > the key_index. > > Performance improvements: > > Lookup Hit: 6.16% > > Lookup Miss: 8.54% > > > > The second patch in this series, moves the store-release of pData > > before the store to any hash internal data structures. This is not > > necessary, but just helps to show the non-dependency between > > application data and hash table data. On the reader side, the pData is > > loaded only if the keys match, this provides performance benefits. > > Performance improvements (with patch 1): > > Lookup Hit: 6.25% > > Lookup Miss: 13.97% >=20 > Could you share the commands/data to test this specific performance > measurement? The data given here uses hash_readwrite_lf test with 5M entries. The keys u= sed for hit is again 5M. We also tested this using L3-fwd (note that L3-fwd app needs to be changed = to enable lock-free hash code path). Command: ./examples/l3fwd/build/l3fwd -c 0xc0 -n 1 -- -E -P -p 0x3 --config= =3D"(0,0,7),(1,0,6)" On A72: Upstream lock-free: Hit: 11.117/11.168/11.101 Miss: 6.760/6.763/6.764 Upstream lock-free + patches(1,2) Hit: 11.310/11.276/11.385 Miss: 11.245/11.293/11.281