Re: [dpdk-dev] [PATCH] mk: link ring mempool by default for app build

[Shreyansh Jain <shreyansh.jain@nxp.com>]

Hi Olivier,

> -----Original Message-----
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> Sent: Tuesday, April 18, 2017 5:34 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; bruce.richardson@intel.com;
> john.miller@atomicrules.com
> Subject: Re: [PATCH] mk: link ring mempool by default for app build
> 
> On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain <shreyansh.jain@nxp.com>
> wrote:
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver")
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> > ---
> > Context:
> >  From the discussion in [1], it was observed that application should
> >  have a default pool already linked even in case of shared builds.
> >  Ring is especially important because packet mbuf creation API refer to
> >  ring_mp_mc as default handler.
> >
> >  Documentation for this is pending.
> >
> >  [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html
> 
> Maybe this comment could go in the patch.
 
I can send another version of the patch with some part of the above documentation within the patch commit.

> 
> Thanks,
> Olivier