From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0079.outbound.protection.outlook.com [104.47.2.79]) by dpdk.org (Postfix) with ESMTP id 5C26E14E8 for ; Wed, 13 Dec 2017 11:55:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RAbl14WlsU/5fKD+uMZg5GbCXx+/4eo6avzb5A4MKsc=; b=xet5hqhxn7641AxgZgrT/wGUzsHyGPJ68UpNUnUWWcBcgzeM3P0GqgBGmRgfpNkWLu4UPLTCgpcqLp4OeRo2e7y7jgc7UukcaCX1tS7Yz/V1W4o5KQUc0tVD8Yusy86OrVurNkHz11kYAecCsU4h6JLVW3wKVSn73YAR9rbA0nM= Received: from VI1PR0401MB2464.eurprd04.prod.outlook.com (10.168.64.147) by VI1PR0401MB2464.eurprd04.prod.outlook.com (10.168.64.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 10:55:08 +0000 Received: from VI1PR0401MB2464.eurprd04.prod.outlook.com ([fe80::7d3e:4591:f58a:354c]) by VI1PR0401MB2464.eurprd04.prod.outlook.com ([fe80::7d3e:4591:f58a:354c%17]) with mapi id 15.20.0302.013; Wed, 13 Dec 2017 10:55:08 +0000 From: Shreyansh Jain To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 18/18] doc: remove devargs deprecation notices Thread-Index: AQHTc/zJvucBp2xV3k+5sFYpru+3daNBFxSw Date: Wed, 13 Dec 2017 10:54:47 +0000 Deferred-Delivery: Wed, 13 Dec 2017 10:53:49 +0000 Message-ID: References: <3930fcee-7ff6-c6f9-273b-14c16bef6ab1@nxp.com> <20171213102552.nmrf73y7yvzexkz7@bidouze.vm.6wind.com> In-Reply-To: <20171213102552.nmrf73y7yvzexkz7@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0401MB2464; 6:FsJjQ5Oc8nxWOTOv9dBINpsHkkfHlk4hUqXrr4bWmvU6Q366M9dhVQq7wIoS9WkRNn936BXO+6yUCf0OQTB81j9zhlpt8o6GLwpc3z0mxkbW4SvGVdPu+Oa6vjU4JDs46wNsS0D5JD0yhTnh6JHrqc1/deJa5k86TqO7sOKb0YlgzYpEyTSbq9QoqouF7A8QnbBobXKOEU9Ua667KOuLZFSaorPfEGo0ET9jt5AvVcqSxdNTfC9TIkUXTqq+rOudL8KRB2UpOD8OD3QuERXXvmTOMYKK4JhWVsd9VihCotHOmk6uc4SCDtpDEM44d/qkfOoHpUXFl+79+6IOeXb+iHgPYUzPpYJLW/h4JgMask0=; 5:0XeHgHOFcJ9x36Uw1pt6klF5iNkxNTzscXsK0D+YNxT7Htu7+ZvODxdUrHFgP9kBYR+2T4lo2utC+0IyXGKl4qG+g40dOkE5A9vLkdQDczg7QsWc+ya2om04Bl/RpBibf8UL0vtFXczywhd4GTUUthEr2AW2mQROXDyTgZDBfGY=; 24:w4aJd7PPkioGRyJYEi/4pqX+4j3wKv0Yjbnfk2uXUuu6YkKXgYzoRwnPWlp07DZvFBG0QLYaktR7iMG07Ooqp3s22HNVcsd20cvMthBnrzE=; 7:bAE+5P0gCFG/O3sY+ZqwwOAP3PlIj4Qxw/UG4u4kbgAhLA1CmfO4C/RiO55pyi6bKHx3Yx1KRoXR6oRofpIyohUXtTDoyX6eejFwa2QQ0jAZxQmhyxQzD7zcx8sHKsoZ/79IJ+iTdQvUtYa2k2PP2ddcCRHuQGld7uHZ6iKkqoHLsLasVkEG5hduuPFX0O/jIr4TF0G6lvQama8LPyPmfTLEDYu+bGdWmaYadqe/50wLH32nxUYKDV9gP65Qnu2Z x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5d23825f-5ae4-43cb-3f83-08d54217f9bf x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307); SRVR:VI1PR0401MB2464; x-ms-traffictypediagnostic: VI1PR0401MB2464: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(3231023)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123558100)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011); SRVR:VI1PR0401MB2464; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR0401MB2464; x-forefront-prvs: 052017CAF1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(51914003)(501624003)(13464003)(24454002)(199004)(189003)(2906002)(5250100002)(2900100001)(93886005)(86362001)(7736002)(14454004)(33656002)(305945005)(55016002)(3280700002)(5890100001)(53936002)(8676002)(106356001)(81166006)(6246003)(229853002)(66066001)(105586002)(9686003)(6116002)(6436002)(74316002)(3660700001)(6666003)(3846002)(102836003)(2950100002)(7696005)(8936002)(5660300001)(6916009)(316002)(99286004)(25786009)(97736004)(68736007)(76176011)(6506007)(478600001)(4326008)(15650500001)(53546011)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2464; H:VI1PR0401MB2464.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d23825f-5ae4-43cb-3f83-08d54217f9bf X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2017 10:55:08.3440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2464 Subject: Re: [dpdk-dev] [PATCH v2 18/18] doc: remove devargs deprecation notices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 10:55:10 -0000 Hello Gaetan, > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Wednesday, December 13, 2017 3:56 PM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 18/18] doc: remove devargs deprecation notices >=20 > Hello Shreyansh, >=20 > On Wed, Dec 13, 2017 at 03:47:04PM +0530, Shreyansh Jain wrote: > > Hello Gaetan, > > > > On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: > > > These actions have been enacted. > > > > > > Signed-off-by: Gaetan Rivet > > > --- > > > doc/guides/rel_notes/deprecation.rst | 13 ------------- > > > 1 file changed, 13 deletions(-) > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > > > index ef2264f..23faa19 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -16,19 +16,6 @@ Deprecation Notices > > > - ``rte_set_log_type``, replaced by ``rte_log_set_level`` > > > - ``rte_get_log_type``, replaced by ``rte_log_get_level`` > > > -* eal: several API and ABI changes are planned for ``rte_devargs`` i= n > v17.11. > > > - The format of device command line parameters will change. The bus = will > need > > > - to be explicitly stated in the device declaration. The enum > ``rte_devtype`` > > > - was used to identify a bus and will disappear. > > > - The structure ``rte_devargs`` will change. > > > - The ``rte_devargs_list`` will be made private. > > > - The following functions are deprecated starting from 17.08 and wil= l > either be > > > - modified or removed in 17.11: > > > - > > > - - ``rte_eal_devargs_add`` > > > - - ``rte_eal_devargs_type_count`` > > > - - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_par= se`` > > > - > > > * eal: An ABI change is planned for 17.11 to make DPDK aware of IOV= A > address > > > translation scheme. > > > Reference to phys address in EAL data-structure or functions may > change to > > > > > > > Once this patch is formalized, the documentation reference for > rte_devargs.h > > also needs to be changed as it still refers to RTE devargs as: > > > > "...These devices can be PCI devices or virtual devices....". > > > > Similarly, the rte_devargs_parse too has PCI traces. > > > > Next step would be to remove the "pci"/"vdev" reference from > > rte_eal_dev_attach. > > >=20 > Noted, thanks. >=20 > > Former can be part of this series, but the later needs to be a separate > > patch, I think. Let me know if you want me to work on these (or later). > > > > Other than that, I think I am OK with overall patch. If you can push th= e > > final series (I am not sure it would be with or without bus control), I= can > > give it a spin (to vaildate if non-PCI like FSLMC bus can work fine). >=20 > Indeed, I also think everything should be settled first. > I have mostly finished working on this series yesterday, > I will integrate your above remarks which will be short. >=20 > (Well, by finished I mean I finished the first 90%. The other 90% is > still in progress...) >=20 > I removed the rte_devargs unit test and am not too happy about it. There > are parsing functions there, which are extremely error-prone and would > like to have at least the basis for some tests, that we could populate > as we go. If I have the courage I will try to write it and send it with > this series. =20 While reading through the code, I also had the same feeling - there can be = corner cases in the parsing functions which I can't imagine. Anyways, those= need to be runtime-verified - static reviews may not suffice. >=20 > I would certainly appreciate if you are able to fix the pci / vdev > limitation in rte_eal_dev_attach, as I am starting to be overwhelmed > with work (trying to finish a lot of things before the holidays). =20 OK. Once you give the devargs a push, I will start work on the PCI removal from= rte_eal_dev_attach. Before that, I just want to be sure of devargs with no= n-PCI bus (non hotplug case). And, thanks for tons of work you are handling. I saw the patches and really= appreciate how you have split things up in sequential manner per-patch. It= is difficult. >=20 > Thanks for the review! >=20 > -- > Ga=EBtan Rivet > 6WIND