From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 987D9A2EFC for ; Mon, 14 Oct 2019 06:57:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A8A71C190; Mon, 14 Oct 2019 06:57:28 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140075.outbound.protection.outlook.com [40.107.14.75]) by dpdk.org (Postfix) with ESMTP id 23ECF1C129 for ; Mon, 14 Oct 2019 06:57:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UTbTQ4Pnt+LS77p6qDrwn8heDZAfYtn7xz/SQewhBpTPDiniyHaVy4UYF1A9lPelCejdv5IyUym6lmC8zdhSTdbkQRiD3QFmalQMH4zFRxpCqYAqXDfmYgPl1QARUC88XM5oWc+rtOD/QNaXo/oO934NTnSjFlZrKtYZWNh7mvsYkBedlL5CW4xwYF+vm4V8ukHhlGEZL0OtAZscBjZHbFUPfXLu2xJKQsAkZGkwiWG83XYsRAPhPIU5e4TR/rQputlF/mYI3g0+j7oN785z+o9KkDSpjMUnjmYhT0hLrSBwNAtdLrbo3joFxTOaPK7maEVCtQIvmxEZuzXdv4awdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5QdT/cKNIOn8wB4LUu0gZg+6xDOXG1FH7r9icbtEG4s=; b=V1KzpIoH4YnKPfLnRzDIhafZJ0xHosS1pHqwS7IatPu1J1Yua03VStY4sPFVCFFpMNe7ufffPp1cPDbPDcDmx34GTJTIf4SPAdHgalV2r8uOaFKfEXT/NG+Iv0ftH2AWNevHDI9iU8Tf8SJ/JtoBH1Mw8DtpgvVmK2BkWTtGwXkzb5Qou7WatWix0vuby443PbHSe5olpHkDUFIoGmerlhkuzQk5xbd8lDBYz9K7LgAFi9aKGZ+FCBFm8OlywfDXFAoQVkcPHNpGeZnW5M+6tpWk7/luypzGFCG4DI1oh5whp75fZ+qnBqh3OLJzUaxHn3oeCKCYCM02VnqZHeNNrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5QdT/cKNIOn8wB4LUu0gZg+6xDOXG1FH7r9icbtEG4s=; b=c2BR3f2Y5FP8k7uBYgVMjOXHPsOYATtRWBvE3XaEgTgdTvPQTOrgKL3i5uSJJcyd3bzfKlPI/8HCXbh5r8vDAJm/Q0dMrsqN4q/iNcxOJauK6ElQfIMBtKhJ2X/SQUcOwnRWsN63nmn/DbFF9y6eEVHPk8zExkSxi1OFX0z+t2Q= Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.62.139) by VI1PR0401MB2669.eurprd04.prod.outlook.com (10.168.62.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.21; Mon, 14 Oct 2019 04:57:25 +0000 Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::b0c5:3e17:6ab7:5c26]) by VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::b0c5:3e17:6ab7:5c26%10]) with mapi id 15.20.2347.021; Mon, 14 Oct 2019 04:57:25 +0000 From: Hemant Agrawal To: Aaron Conole CC: "dev@dpdk.org" , Akhil Goyal Thread-Topic: [dpdk-dev] [PATCH 10/10] crypto/dpaa_sec: code reorg for better session mgmt Thread-Index: AQHVgFHgJ9a7Y5mE70yp7FJVRml8VqdVzJrGgAPKTBA= Date: Mon, 14 Oct 2019 04:57:25 +0000 Message-ID: References: <20191011163233.31017-1-hemant.agrawal@nxp.com> <20191011163233.31017-11-hemant.agrawal@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [92.120.1.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 63090139-959a-4053-5d43-08d750630171 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VI1PR0401MB2669:|VI1PR0401MB2669: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 01901B3451 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(13464003)(199004)(189003)(25786009)(6506007)(71190400001)(5660300002)(8936002)(81166006)(81156014)(8676002)(186003)(76176011)(99286004)(7696005)(66066001)(102836004)(14454004)(52536014)(71200400001)(54906003)(53546011)(33656002)(26005)(4744005)(86362001)(316002)(478600001)(305945005)(3846002)(476003)(6116002)(2906002)(74316002)(7736002)(256004)(446003)(6916009)(486006)(11346002)(4326008)(44832011)(66446008)(64756008)(66556008)(66476007)(66946007)(6436002)(76116006)(6246003)(9686003)(229853002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2669; H:VI1PR0401MB2541.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9TxvOPSVMT3AsSjHV2KUFmmGFpcxOyyIxvwSDGprnuOCJH8vCScVJwVAooaDI/O/gQ7napowHB29Sywe/ytYdpGinghhb2SzMB+WM6e18XVs9Ao/xPJcjtiWWVKONrY4kwoeK+tRZE+s48SNXNXtAyJ1aWz4YPC9XBnlhnVmhvwawK8+sBVClweSsOVOnVnUIBIIKiYFQGHZYICSObUqsih9AH462e+uwgoV/NQptVCIwnKlUVqK9aioouthZyLL+JOMcyWCk0bAPaCAFyG6GvGwEiYFga5AKrOBT9EnHR+l38sGUze2wda1Bwuh0ibPpzM+61ch8fo0/odR/8ZnqWPv3kebbKeLp2joopzOxHYZ+YaM/gz3PGJKbjIAF6bx/AfiNJD4s39bkSHGBsBiZQ176O+Q/QNohlKJTzptXMo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63090139-959a-4053-5d43-08d750630171 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2019 04:57:25.0716 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yfr3p14XCOhoBiCX4pO/1zLONfeI4hoeFtJ/f8zg7Xhwm/4qJTU29b42Zls4+4Ji3u9qNrknaGUHK+NUhBw+4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2669 Subject: Re: [dpdk-dev] [PATCH 10/10] crypto/dpaa_sec: code reorg for better session mgmt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Aaron, Thanks! I will fix these comments. Regards, Hemant > -----Original Message----- > From: Aaron Conole > Sent: Saturday, October 12, 2019 12:34 AM > To: Hemant Agrawal > Cc: dev@dpdk.org; Akhil Goyal > Subject: Re: [dpdk-dev] [PATCH 10/10] crypto/dpaa_sec: code reorg for > better session mgmt > Importance: High >=20 > Hemant Agrawal writes: >=20 > > The session related parameters shall be populated during the session > > create only. > > At the runtime on first packet, the CDB should just reference the > > session data instead of re-interpreting data again. > > > > Signed-off-by: Hemant Agrawal > > --- >=20 > As a part of this patch, a number of static functions are no longer used,= and > should be removed (for example is_auth_only, is_cipher_only, is_aead, > is_auth_cipher, and is_proto_ipsec). >=20 > You will see this if you choose to build with clang. gcc sees the functi= ons > marked as static inline, and doesn't seem to warn. >