From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF321A0562; Thu, 2 Apr 2020 17:44:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8E8A375B; Thu, 2 Apr 2020 17:44:34 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60088.outbound.protection.outlook.com [40.107.6.88]) by dpdk.org (Postfix) with ESMTP id E2B542B8B for ; Thu, 2 Apr 2020 17:44:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOAKytW+u9w+UPfep7yBChgurhZ8Oc2nBAeoxtyCBY37VnjonQ1HHqtT1vBqcpX5iHsCbTkdvbgWHcD5cjHwXYEqtfuop8UkMtfxy93IwaAETHrUH76HVuzeFeZhlsBE0rFdWzU+Yu2qwJSVetvb17qwF+rAA5S+V5rU3b4XU6220En9uHwxkKkdHVYm0PpsFSgjindyQW1Car+OgI88CKyDZI9BfdLEkhltW6a7g1FfGHIuxJW73ffeg67V0/vbxsptw5p2l0rfqHIDG1R4Gr3Ubh7IgtSCbL50d9aiHKtTRUTFM1dQrTD32Trdv04zCjuWtK/xlfX+3lEDNpLPuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R4DnU+wQYy5bNr5OfrnOEuefBGUt7CRiPEleVMQ548s=; b=l5dReIkWL841w+42qhT5QVAn+Wh6960VGUJ60xCnDd2qdtcfFErOOr0jDeKOqcTe1nRhg3Dckb3OkwLIBlCeRqJhd5zkVXhLRBCtj1OiRRItwU1Nw1NXOHM4tVzAc73NXYi6GZaipiMSnPeeL1zDf78bVTTF0r/aJ2hPscwk3fQtEO8I2rF9my+evxTZd98aCaYAq8r0nCtgSrd8VQpb2bMDZQLNvpxBWqA7nHEXaUMKh0ZhOSYvw5JltnSpuHGx4hiIHFFs2UTVYniaheKe146/j3fFFWdjpInsCL6ieQYbX1y7ncnEQuFjIB1FwXmYU6i+C+umrvah1f2HXoSbrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R4DnU+wQYy5bNr5OfrnOEuefBGUt7CRiPEleVMQ548s=; b=kHYg1uahrkh5uXJUyKuUq4rddkfEWFe5W45nm5fqIuFJIljo9pKzqPkchE7t2toL7FZQc7GkTjM+Jw8v8NpuTwbfa2VfTKpBEVl1lhVQ9DSrO2ZBq0G0Yrw44E8bs5BSaNCbYKbyRlcjS4ThMPKO6TAA09OBGpIEsX2h9AKFW3A= Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.62.139) by VI1PR0401MB2671.eurprd04.prod.outlook.com (10.168.64.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Thu, 2 Apr 2020 15:44:32 +0000 Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::c0e5:9ade:9b5:9434]) by VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::c0e5:9ade:9b5:9434%4]) with mapi id 15.20.2878.016; Thu, 2 Apr 2020 15:44:32 +0000 From: Hemant Agrawal To: Neil Horman CC: "david.marchand@redhat.com" , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Bruce Richardson , Thomas Monjalon , Akhil Goyal Thread-Topic: [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal Thread-Index: AQHVIfO1SAD/0vQdcEurvr2RNsm1HKafdgfQgANeWoCBxI1tkIAAHouAgABG02A= Date: Thu, 2 Apr 2020 15:44:32 +0000 Message-ID: References: <20190525184346.27932-1-nhorman@tuxdriver.com> <20190613142344.9188-1-nhorman@tuxdriver.com> <20190613142344.9188-6-nhorman@tuxdriver.com> <20190619104543.GB19712@hmswarspite.think-freely.org> <20200402113035.GA4063060@hmswarspite.think-freely.org> In-Reply-To: <20200402113035.GA4063060@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [182.69.71.168] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 22a597e0-7460-47ba-1409-08d7d71cbd1f x-ms-traffictypediagnostic: VI1PR0401MB2671:|VI1PR0401MB2671: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0361212EA8 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0401MB2541.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(6506007)(4326008)(44832011)(8676002)(7696005)(8936002)(86362001)(71200400001)(81156014)(53546011)(55016002)(76116006)(33656002)(81166006)(66476007)(9686003)(54906003)(2906002)(66946007)(316002)(26005)(5660300002)(478600001)(6916009)(186003)(52536014)(64756008)(66446008)(66556008); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: phgQww3iJXBi04uo5TsiqbEwVoEfdCvsc66e7czmWQ8EmOJa2fvkAyUlO2hlVwOXgWCkiatzGI2TlJq1MXkrqOtVGqFlEbqYVwAVV7ctf6DKwcifm2gfgmAR7LDZT2ygD1muJnrFLSELW+v+9xWcb7qbJqGPm1WuP1FLz9WoVT+898sSOI6M0RAHXh2TUqcWp9scaARgdxBqYnLDrUnXFdkyy/EG4z1VqTOaceCVdn42pziE82Fj7Ux78HjipuW/puCuPo8k0Zbecf4UA6SCPilEzbaxR6KcCL9oTJt9DeWHJu/0UoShM/tp/6yoaoSbcHmaWEBWmHwitKdGtOO9ki4/Z8PnnJKmYed8PM/tsNBEhoabmQJTFUB2rCfmR0F6nbzV0gtXKawRD5iGEWenHMmAAV0IS4WboOAg+cwM3IzzX7YnplfVJ6rAtTSFI+mS x-ms-exchange-antispam-messagedata: MeictwpAGOycebIJbnhmu/XiDDrQfAGUi1aDJoBGuCO2+Q6ALOCzZ+f3joYMYXQNzIJCtTYQMkrVng0tkrHA2F8VZm8znDX/hfEi1h38RhN0S0uXeNtr4Yw06hgVpsJDsiL041O65ZePTQfyom46wA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22a597e0-7460-47ba-1409-08d7d71cbd1f X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2020 15:44:32.6971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y/oT/dt/rRBppjRkqISz4b89rayxs5lP7oB5YCKAOgXNzjqwKvwgHfGMkptcOH7DG1aNGjgdEHmF0tMzROphLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2671 Subject: Re: [dpdk-dev] [PATCH v2 05/10] fslmc: identify internal only functions and tag them as __rte_internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Neil, On 02-Apr-20 5:00 PM, Neil Horman wrote: > On Thu, Apr 02, 2020 at 09:49:20AM +0000, Hemant Agrawal wrote: >> HI Neil, >>> On Mon, Jun 17, 2019 at 07:30:34AM +0000, Hemant Agrawal wrote: >>>> HI Neil, >>>> The same code of low-level HW driver is shared with different OSs >>> (kernel, uboot etc) and different framework. If we introduce rte_intern= al in >>> these low-level hw files, it will be a big maintenance issue for NXP. E= verytime >>> there is a change or upgrade, it will be a pain. >>>> >>> Why? If you don't want to support the use of a project specific tag in= other >>> projects, you can add a global cflag to those like this: >>> -D__rte_experimental >>> >>> and the code will be eliminated >>> >>> I'm not sure what you see as difficult here >> [Hemant]=20 >> Do, we have an alternate for this approach? >> > No, what issue do you see with the approach suggested above? We are just trying to reduce the maintenance cost it brings. Specially deal= ing with extra changes to the common libraries provided by other teams. > > >> Also, w.r.t to changes, at present you are adding the "__rte_internal" a= fter the function return type. Is it possible to add it before the function= return type and limiting the changes to header file only i.e. something si= milar to the current approach of "__rte_experimental" > The __rte_internal macro expands to a function attribute, and the gcc man= ual > mandates that it be inserted between the return type and function name. = As for > its application in both the prototypes and declarations, I'd need to go b= ack and > look again, I can't recall if that can be done. Thanks in advance. Please check if you can make it similar to __rte_experim= ental support. > >> =3D> current approach >>> * Return: '0' on Success; Error code otherwise. >>> */ >>> -int dpbp_open(struct fsl_mc_io *mc_io, >>> +int __rte_internal dpbp_open(struct fsl_mc_io *mc_io, >>> uint32_t cmd_flags, >>> int dpbp_id, >>> uint16_t *token) >> >> =3D> approach used in rte_experimental >>> __rte_experimental >>> uint16_t >>> rte_bbdev_count(void); >> >> This will help in minimizing the changes. >> >> Regards, >> Hemant >> >>> >>> Neil >>> >>>> Regards, >>>> Hemant >>>> >>>>> -----Original Message----- >>>>> From: Neil Horman >>>>> Sent: Thursday, June 13, 2019 7:54 PM >>>>> To: dev@dpdk.org >>>>> Cc: Neil Horman ; Jerin Jacob Kollanukkaran >>>>> ; Bruce Richardson ; >>>>> Thomas Monjalon ; Hemant Agrawal >>>>> ; Shreyansh Jain >>>>> Subject: [PATCH v2 05/10] fslmc: identify internal only functions >>>>> and tag them as __rte_internal >>>>> Importance: High >>>>> >>>>> Identify functions in fslmc bus driver which are internal (based on >>>>> their not having an rte_ prefix) and tag them with __rte_internal >>>>> >>>> >>