From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"anoobj@marvell.com" <anoobj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v5 3/3] crypto/dpaa2_sec: enable anti replay window config
Date: Wed, 6 Nov 2019 05:16:11 +0000 [thread overview]
Message-ID: <VI1PR0401MB2541E6B3A74AB8C2A7AFD2C889790@VI1PR0401MB2541.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <VE1PR04MB663924214DFB38A8EB65B3CFE67E0@VE1PR04MB6639.eurprd04.prod.outlook.com>
Hi Akhil,
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, November 6, 2019 3:38 AM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>; dev@dpdk.org
> Cc: konstantin.ananyev@intel.com; anoobj@marvell.com; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Subject: RE: [PATCH v5 3/3] crypto/dpaa2_sec: enable anti replay window
> config
> Importance: High
>
> Hi Hemant,
> >
> > This patch usages the anti replay window size to config the anti
> > replay checking in decap path for lookaside IPSEC offload
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 24
> +++++++++++++++++++
> > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 6 +++--
> > drivers/crypto/dpaa_sec/dpaa_sec.c | 26 +++++++++++++++++++++
> > drivers/crypto/dpaa_sec/dpaa_sec.h | 6 +++--
> > 4 files changed, 58 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> > b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> > index 52e522e4a..6d59e73e9 100644
> > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> > @@ -2836,6 +2836,30 @@ dpaa2_sec_set_ipsec_session(struct
> > rte_cryptodev *dev,
> > sizeof(struct rte_ipv6_hdr) << 16;
> > if (ipsec_xform->options.esn)
> > decap_pdb.options |= PDBOPTS_ESP_ESN;
> > +
> > + if (ipsec_xform->replay_win_sz) {
> > + uint32_t win_sz;
> > + win_sz = rte_align32pow2(ipsec_xform-
> >replay_win_sz);
> > +
> > + switch (win_sz) {
> > + case 1:
> > + case 2:
> > + case 4:
> > + case 8:
> > + case 16:
> > + case 32:
> > + if (ipsec_xform->options.esn)
> > + decap_pdb.options |=
> > PDBOPTS_ESP_ARS64;
>
> Why is it dependent on ESN?
[Hemant] ESN requires to maintain the > 32 bit seq numbers. So there is no meaning of keeping the windows size as 32 for this case.
>
> > + else
> > + decap_pdb.options |=
> > PDBOPTS_ESP_ARS32;
> > + break;
> > + case 64:
> > + decap_pdb.options |= PDBOPTS_ESP_ARS64;
> > + break;
> > + default:
> > + decap_pdb.options |=
> PDBOPTS_ESP_ARS128;
>
> Default case should not set anti replay window like case 0 when we don't
> want anti replay.
[Hemant] We are choosing to default to 128 bit AR, if the user chooses to set it > 128. It is implementation choice.
>
> > + }
> > + }
> > session->dir = DIR_DEC;
> > bufsize = cnstr_shdsc_ipsec_new_decap(priv-
> >flc_desc[0].desc,
> > 1, 0, SHR_SERIAL,
> > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> > b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> > index 662559422..b97dacbcb 100644
> > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> > @@ -675,7 +675,8 @@ static const struct rte_security_capability
> > dpaa2_sec_security_cap[] = {
> > .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
> > .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
> > .direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
> > - .options = { 0 }
> > + .options = { 0 },
> > + .replay_win_sz_max = 128
> > },
> > .crypto_capabilities = dpaa2_sec_capabilities
> > },
> > @@ -686,7 +687,8 @@ static const struct rte_security_capability
> > dpaa2_sec_security_cap[] = {
> > .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
> > .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
> > .direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
> > - .options = { 0 }
> > + .options = { 0 },
> > + .replay_win_sz_max = 128
> > },
> > .crypto_capabilities = dpaa2_sec_capabilities
> > },
> > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c
> > b/drivers/crypto/dpaa_sec/dpaa_sec.c
> > index 6c186338f..7cfa5f6dc 100644
> > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c
> > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
> > @@ -2693,6 +2693,32 @@ dpaa_sec_set_ipsec_session(__rte_unused
> struct
> > rte_cryptodev *dev,
> > sizeof(struct rte_ipv6_hdr) << 16;
> > if (ipsec_xform->options.esn)
> > session->decap_pdb.options |= PDBOPTS_ESP_ESN;
> > + if (ipsec_xform->replay_win_sz) {
> > + uint32_t win_sz;
> > + win_sz = rte_align32pow2(ipsec_xform-
> >replay_win_sz);
> > +
> > + switch (win_sz) {
> > + case 1:
> > + case 2:
> > + case 4:
> > + case 8:
> > + case 16:
> > + case 32:
> > + if (ipsec_xform->options.esn)
> > + session->decap_pdb.options |=
> > +
> PDBOPTS_ESP_ARS64;
> > + else
> > + session->decap_pdb.options |=
> > +
> PDBOPTS_ESP_ARS32;
> > + break;
> > + case 64:
> > + session->decap_pdb.options |=
> > PDBOPTS_ESP_ARS64;
> > + break;
> > + default:
> > + session->decap_pdb.options |=
> > +
> PDBOPTS_ESP_ARS128;
> > + }
> > + }
> > session->dir = DIR_DEC;
> > } else
> > goto out;
> > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h
> > b/drivers/crypto/dpaa_sec/dpaa_sec.h
> > index c10ec1007..684950d6d 100644
> > --- a/drivers/crypto/dpaa_sec/dpaa_sec.h
> > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h
> > @@ -692,7 +692,8 @@ static const struct rte_security_capability
> > dpaa_sec_security_cap[] = {
> > .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
> > .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
> > .direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS,
> > - .options = { 0 }
> > + .options = { 0 },
> > + .replay_win_sz_max = 128
> > },
> > .crypto_capabilities = dpaa_sec_capabilities
> > },
> > @@ -703,7 +704,8 @@ static const struct rte_security_capability
> > dpaa_sec_security_cap[] = {
> > .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP,
> > .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL,
> > .direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS,
> > - .options = { 0 }
> > + .options = { 0 },
> > + .replay_win_sz_max = 128
> > },
> > .crypto_capabilities = dpaa_sec_capabilities
> > },
> > --
> > 2.17.1
next prev parent reply other threads:[~2019-11-06 5:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 6:20 [dpdk-dev] [PATCH 1/2] security: add anti replay window size Hemant Agrawal
2019-10-25 6:20 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add support for replay win for lookaside Hemant Agrawal
2019-10-25 10:00 ` [dpdk-dev] [PATCH 1/2] security: add anti replay window size Ananyev, Konstantin
2019-10-25 15:56 ` Hemant Agrawal
2019-10-30 6:57 ` [dpdk-dev] [PATCH v2 " Hemant Agrawal
2019-10-30 6:57 ` [dpdk-dev] [PATCH v2 2/2] ipsec: remove redundant replay_win_sz Hemant Agrawal
2019-10-30 8:57 ` [dpdk-dev] [PATCH v3 1/2] security: add anti replay window size Hemant Agrawal
2019-10-30 8:57 ` [dpdk-dev] [PATCH v3 2/2] ipsec: remove redundant replay_win_sz Hemant Agrawal
2019-10-30 13:08 ` Ananyev, Konstantin
2019-10-31 4:54 ` [dpdk-dev] [PATCH v4 1/3] security: add anti replay window size Hemant Agrawal
2019-10-31 4:54 ` [dpdk-dev] [PATCH v4 2/3] ipsec: remove redundant replay_win_sz Hemant Agrawal
2019-10-31 10:21 ` Ananyev, Konstantin
2019-10-31 4:54 ` [dpdk-dev] [PATCH v4 3/3] crypto/dpaa2_sec: enable anti replay window config Hemant Agrawal
2019-10-31 6:29 ` [dpdk-dev] [PATCH v4 1/3] security: add anti replay window size Anoob Joseph
2019-10-31 7:30 ` Hemant Agrawal
2019-10-31 10:20 ` Ananyev, Konstantin
2019-10-31 13:15 ` [dpdk-dev] [PATCH v5 " Hemant Agrawal
2019-10-31 13:15 ` [dpdk-dev] [PATCH v5 2/3] ipsec: remove redundant replay_win_sz Hemant Agrawal
2019-11-05 22:01 ` Akhil Goyal
2019-11-06 5:16 ` Hemant Agrawal
2019-10-31 13:15 ` [dpdk-dev] [PATCH v5 3/3] crypto/dpaa2_sec: enable anti replay window config Hemant Agrawal
2019-11-05 22:07 ` Akhil Goyal
2019-11-06 5:16 ` Hemant Agrawal [this message]
2019-11-01 6:16 ` [dpdk-dev] [EXT] [PATCH v5 1/3] security: add anti replay window size Anoob Joseph
2019-11-01 9:48 ` Hemant Agrawal
2019-11-06 6:54 ` [dpdk-dev] [PATCH v6 " Hemant Agrawal
2019-11-06 6:54 ` [dpdk-dev] [PATCH v6 2/3] ipsec: remove redundant replay_win_sz Hemant Agrawal
2019-11-06 7:00 ` Akhil Goyal
2019-11-06 13:31 ` Ananyev, Konstantin
2019-11-06 13:40 ` Akhil Goyal
2019-11-06 14:27 ` Ananyev, Konstantin
2019-11-06 14:29 ` Akhil Goyal
2019-11-06 6:54 ` [dpdk-dev] [PATCH v6 3/3] crypto/dpaa2_sec: enable anti replay window config Hemant Agrawal
2019-11-06 7:02 ` Akhil Goyal
2019-11-06 13:15 ` [dpdk-dev] [PATCH v6 1/3] security: add anti replay window size Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB2541E6B3A74AB8C2A7AFD2C889790@VI1PR0401MB2541.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).