From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 850B3A0555; Wed, 25 May 2022 17:23:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23E1C40146; Wed, 25 May 2022 17:23:18 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140128.outbound.protection.outlook.com [40.107.14.128]) by mails.dpdk.org (Postfix) with ESMTP id E9AAA400EF for ; Wed, 25 May 2022 17:23:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YYkMj1tmI1HsyQhh2HNLOrRkAdhuAP3VA2yBvO+N6SkdIno7aMPSREA0lEmqCbb7GeoJ0fVSZv0nnaN4Rp/v+z1oSdB+6/FKxThvsxhJrp3YVnrMmk1dW4IuKKXOHIO+AxrCwhoV8PUum25EQ/HkWfsvfsTNCCif5ehNh+KeRuwjxAacc9kp/hFuyQVPIm3hqBVV7bGhYH2eC1mMu3hrKxgG0Gd2YKQSPk2TsaXosPtbFIPWaHmhMU70kvJxiKCSMc7/fkYZoGzZ1i8GNKlMNPo6eTIZdPWI0e9B9kvuUdfkqEoTu38JeKNxlHSDyAbX+WkfqZFMxKknp7hVz9A58g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BvBlpAdBTZVPt82CViNRO/sIpKjkk4vWplQqHpBuNMI=; b=mRq2T203ZVeoIPh9dNwNIcPyHzclhjLaCzHi+6i79P9EiIYQNINqe7Q3XOZGFE7SLDEZ3IBA2Zk40JzLue77kpcueQ4aYkMYsCf8qTq4hALjLJBzg63EXexZldkXtZJS04MZNWelbMHwTGvX8QNODkspzMCBh/2z+61OWA2CCXOjEkBLsCY7lPL2gd2eaeV3rD3cfC80alm4FdEjumuSH3YccnYOlT+IP9jPlvkb1bDXJi3Qsuk+PJBcQo6Luqaq7j/lu9uY0MMnftBZkCnevHdIzcR9Pvy2BzNVMFJM1ybtCGvK4sTV9BR4Vo707DS5D7p7wbkz+Sy5AE9yZl470w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BvBlpAdBTZVPt82CViNRO/sIpKjkk4vWplQqHpBuNMI=; b=acE5mtUgAC+31Srx39b7vfXqioWW+2lJyd3AhcPDImGGqEHvkQpi0YLibxgmvtIK4WCstQ2Kh4jMYU8gSGbmetBeQNkWmtj6vvL0evzW4G+QiKNp3RvwwTResrFVKZOwYl05kNylG6il6TrMh9GM+LXgdGgfb5j/FrXwwAkKdek= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by AS8PR04MB7960.eurprd04.prod.outlook.com (2603:10a6:20b:2a8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 15:23:13 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc%4]) with mapi id 15.20.5293.013; Wed, 25 May 2022 15:23:13 +0000 From: Jeff Daly To: "Zhang, Qi Z" , Thomas Monjalon , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOR1ZG0azI89kSESFkJBuENiqzuHpQAgDk5yICAASnaUIAD5wuAgACO5OCAAJrJAIACm4DQ Date: Wed, 25 May 2022 15:23:13 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1681763.yIU609i1g2@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 316e9bb4-3769-4329-50e2-08da3e627c02 x-ms-traffictypediagnostic: AS8PR04MB7960:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q5e4E6M1Wm6iqbzhEcTh/0PVOfuyXd3xyzkoHDj3WzGmhAu5s5h7+185YcZWVvbA0QtswXVMUwk7YbjaoDx10D3EaLZf0FRTzQfcLnIy4F3T4AFPmJmw8lvqKI1X4YeNx4XrmPJSZXZHD+7bT3mDaxLYd/v+EtvHMfP8nFihE3krezbZN/vYJ9iC3pTVOtZtz2nAVUCB+j09R1MCeRsez2leeSCSPiS+tstq1nXiabF0nutVdmFBQALkp7CoXp03B7uxpR0WRyh3eYnQWTA0Rei3taDQUfs+Kwtls7xJYtdU4rD51y9W6ZwaJzlbyUUegKypL5GlRKM6+hH5Sqw1q0/BIfDw5Bd5IrA6CpMGxjOlhNfBaqcHatTfZsWd33gEPTCo5loMVTlLPy1KeAgIkEQO1dcLqMDbepqO6PnrOoJCs0B5ynkn/gHUmQR3fsjjFFBtardA6tsyzkmKJph3bTVBqlzT1/90Jz95qx4ydNlgdIN30cw+Z81Wxbs0O9cyGjR2Drwf27wN/+RSXJhuEO4BPQGselEMKnen15lGKqdKJmU+FfnMDPNDTe7696hq78KEORx/oQmiep0XUrXcLBLTL43Tggj4DXGjtporJEOMQh6Ha/XVzEISd/np+6riovpVWcY/Bbkwtuod5yElHLSjSHVR63dnmf/JVC035LNEur6rodZvdYvf3uAC/mCTD4Z6J5ZsJGdenLLfgUcgOp3IdU+5C2puJj+T12IsECFcWDkLZfUmJTS2kF3EyZxV2f1/mPtaD7SUsqf4mU+4m/3Ho/1nJf6uBpX1skYwogs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(76116006)(966005)(52536014)(5660300002)(8936002)(186003)(55016003)(33656002)(83380400001)(66446008)(53546011)(316002)(86362001)(6506007)(110136005)(9686003)(7696005)(54906003)(38070700005)(66946007)(122000001)(66476007)(38100700002)(8676002)(64756008)(66556008)(4326008)(71200400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bL5caT2Zcfx1tn+wheiQ8PEQkTSVoG31Ig96yAhi8Ppvi2re6U/wOTpzkp/4?= =?us-ascii?Q?xawicg7OR2RMCeitliJXcE1L9FeUilCZSn3aHReRddHWxc+hUJMUwh+Z6tFX?= =?us-ascii?Q?TtHuYfFi+b1DGUY1IM8YVgwTc3t5oI8vjsoY0wqwPhePbhquATE9suk/YUdK?= =?us-ascii?Q?le1G/AbVdCKpeA4b5Wq3/OCAzD2HsibKBAUxfnRr20Vk8HVDKSDufwZdYfAF?= =?us-ascii?Q?k7OPTe3+0Mo1wIXw/Q4iCnYvzRpymCs8sd4tj8ENtrFQrpGvpeRMiIgjMDb1?= =?us-ascii?Q?O2MSaw+/7U+aBwdKzAEz8Y5SQ6Faa5K1Cp0pV/UG7lHAaD7d+l2kXMG/fgkR?= =?us-ascii?Q?V7O/KJTUaMKhIiCocsiFrXDeN+mHEAlxfWCU5TnnCmqxRu8ArUIMnj2SK8xE?= =?us-ascii?Q?76g/7JqNcdEn55gIECbVIyLJMEghYe66YLR9BMdqRGrnYW9ZF1VQ5/6VIbFW?= =?us-ascii?Q?MicG9UhQsis1gG+TSfb1oDVCqH7OB7fEYPopZkUsPZ+DLJWMQsednOD91Cge?= =?us-ascii?Q?Oybb9kDH1d/ME9u4SKaRLJgy98OndQLW3fzFQx2b4lHasI4lfQeT73zmJ3kl?= =?us-ascii?Q?UVW9N1MFAg/9oOcWK6NK+wr4Pb6ww/rYtHodSCcZ4VIpK9cxlt6eIJ5QY8PA?= =?us-ascii?Q?Xo4nl7XK+VCxIUmOviALBWlUPjy4eq+u7o13p/t4IbchgBk/jEdMaPDcW/WK?= =?us-ascii?Q?Dg0B3L1DK19uvgtF0DSbD8ax9vN1mHEVh9QdELjdFHd1U8XWNpJqDs1D2XP/?= =?us-ascii?Q?OujywIPnW9AeZ66rTMHv9RLfIExVsX7ypi/8ifjeAqUt7EnN7vmBbozacpbo?= =?us-ascii?Q?Cg3MAowcZKvFXT/GZVFUKxwIp3PqcQdEb8Yp9fpB9B6W5CFhP1mRcck3d2cB?= =?us-ascii?Q?XnxNDmkXhIHiQ/0FkQxNKb/qIsNBlvgaiTc9q+y18PxECorY2PdRzE8LNkyG?= =?us-ascii?Q?s2IAauYKzSOOaAsMOLcOFAjSTStf69qTsmCtBqJH2TFiQcxhuwWHdv5CPiNP?= =?us-ascii?Q?AAMww5sw+he2OtpZfSq+ICoQ7s2ASMC49cJtHE0GlWqAHdtGCK8VEPXfkzhB?= =?us-ascii?Q?VWFhOxIaF05vlXvExDAnbejN/9CB0rgF4WGKrKo5jyzT1K4BlUBJvfrew4d0?= =?us-ascii?Q?McrsMS5NdiZWJstIQsIVLxLj/Iybj/vCH0pxpK3YlwuyIc0icz1pNf2awtKJ?= =?us-ascii?Q?cDg9n7dpqh/5IeZWf94ztbhv2fiTrvrXmlIHktZAn5JWSQrS5DRsq9OwGr7x?= =?us-ascii?Q?HWLfMgLaDMu3U5AgdGPpBM9uPz9dlZJTJSkjW2Vm55+DULNm9Gl/Rb85JuZi?= =?us-ascii?Q?zL7yoYH6w6VupDfn6GpZB5VAnDdeHlpRgjM9Ia4LSgH6u1EROwrBOde8RkjR?= =?us-ascii?Q?mEayTJPnpu1XoyLwQSoqwapznfLGn/QMEetmlKdkGlIVr1QieOaKmeNjzToq?= =?us-ascii?Q?qmdpGr+HLQnRrbnSDz2lmeE2vHmJG7z3uYO2Vp+A4pCrFZGLGjehNkU1L0mv?= =?us-ascii?Q?Lwtu2HXgY66LThy6TT/wzZGEAajmW3+ldSDCbwanvDKRwFoNR7eVy4dSt5QX?= =?us-ascii?Q?EEFh68wSmDnFjKdXWz7z+PlDhzPE/LSatfiBWewSvEKLhFWgA61HYhPmu2L6?= =?us-ascii?Q?o6dkzTxKVCoHYK9JapxSmXok5yscHkqivk36cUqAd9w2SjBnf+Ryo/v1Ial/?= =?us-ascii?Q?r2O6dnv2U9HBCIro3BNuLQNFFeQ2HlP1uK3f+BmRNu4cIAtyyOAb3xBCb17M?= =?us-ascii?Q?8mqA1pCO6JZ7IOL2x6jvRITsKjf+wEg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 316e9bb4-3769-4329-50e2-08da3e627c02 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 15:23:13.3965 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JY/ylzOTCFwtl4fDhcmCWml8G8Kha1J6oZVUIdDBucSrJy3jN02UodhM1lnAMal2F2IUTB+tBdpmrBff9DHxUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7960 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, May 23, 2022 7:22 PM > To: Jeff Daly ; Thomas Monjalon > ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > -----Original Message----- > > From: Jeff Daly > > Sent: Monday, May 23, 2022 10:14 PM > > To: Zhang, Qi Z ; Thomas Monjalon > > ; dev@dpdk.org > > Cc: Stephen Douthit ; Yang, Qiming > > ; Wu, Wenjun1 > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > > devices > > > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Monday, May 23, 2022 1:37 AM > > > To: Jeff Daly ; Thomas Monjalon > > > ; dev@dpdk.org > > > Cc: Stephen Douthit ; Yang, Qiming > > > ; Wu, Wenjun1 > > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > X550 devices > > > > > > Caution: This is an external email. Please take care when clicking > > > links or opening attachments. > > > > > > > > > > -----Original Message----- > > > > From: Jeff Daly > > > > Sent: Saturday, May 21, 2022 2:03 AM > > > > To: Zhang, Qi Z ; Thomas Monjalon > > > > ; dev@dpdk.org > > > > Cc: Stephen Douthit ; Yang, Qiming > > > > ; Wu, Wenjun1 > > > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > > X550 devices > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Zhang, Qi Z > > > > > Sent: Thursday, May 19, 2022 8:15 PM > > > > > To: Thomas Monjalon ; dev@dpdk.org > > > > > Cc: Stephen Douthit ; Jeff Daly > > > > > ; Yang, Qiming ; > > > > > Wu, > > > > > Wenjun1 > > > > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > > > X550 devices > > > > > > > > > > Caution: This is an external email. Please take care when > > > > > clicking links or opening attachments. > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Thomas Monjalon > > > > > > Sent: Wednesday, April 13, 2022 10:21 PM > > > > > > To: dev@dpdk.org > > > > > > Cc: Stephen Douthit ; Jeff Daly > > > > > > ; Wang, Haiyue > > > > > > ; Yang, Qiming ; > > > > > > Wu, Wenjun1 > > > > > > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on > > > > > > the > > > > > > X550 devices > > > > > > > > > > > > Please, could we have a review of this patch? > > > > > > +Cc new ixgbe maintainers > > > > > > > > > > > > > > > > > > 07/03/2022 23:34, jeffd@silicom-usa.com: > > > > > > > From: Stephen Douthit > > > > > > > > > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 > > > > > > > family of devices but treat them as 1G SX modules since they > > > > > > > usually > > work. > > > > > > > Print a warning though since support isn't validated, > > > > > > > similar to what already happens for other unofficially > > > > > > > supported SFPs enabled via the allow_unsupported_sfps > > > > > > > parameter inherited from the mainline > > > > > Linux driver. > > > > > > > > > > > > > > Signed-off-by: Stephen Douthit > > > > > > > Signed-off-by: Jeff Daly > > > > > > > > > > I think we need a devargs for this feature with well > > > > > documentation So, it should not break existing behavior by > > > > > default, but allow people to take risk if they know what they are > doing. > > > > > > > > > > > > > there was already a patch submitted to IWL mailing list for this > > > > feature in the base driver, which was rejected. > > > > https://patchwork.ozlabs.org/project/intel-wired- > > > > lan/patch/20220414201329.27714-1-jeffd@silicom-usa.com/ > > > > > > OK, thanks for sharing this, > > > > > > But base on the concern of the previous comment > > > > > > " As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules > > > require the use of RX_ILOS and some Intel Ethernet products don't > > > support > > that." > > > > > > We may have a risk to accept the code as default behavior > > > > > > But devargs is allowed in DPDK for device-specific features. > > > > > > > ok, I will submit a revised patch that uses a devargs (or whatever) > > switch to allow the behavior when selected explicitly. > > > > But, can we *please* STOP marking patches as superseded when a > > follow-up patch > > hasn't been submitted yet!? I've marked the patch as 'Changes > Requested' for > > now. >=20 > Sure, I should follow, thanks to correct his, but a little bit surprise, = why this > looks like a big deal, it just a shortcut when I expected a new version w= ill > come then I skip one status change, I think mailing list already have > everything about the patch status for you. >=20 Maybe I'm not understanding the terms being used then in the mailing list s= tatus. If you expect a new version (that doesn't exist yet) then wouldn't this be = more aptly "Changes Requested" vs. "Superseded". Superseded implies there's a = new version that exists and this current one no longer applies. If I just came= onto the=20 mailing list and read a patch that was marked "Superseded" and looked for t= he=20 new one and didn't find it, I'd be very confused. If I read a patch that w= as marked "Changes Requested", I'd know that this was the last patch sent by the deve= loper and that there would be a follow-up to this one sometime. > > When I submit a follow-up I will set this one to superseded >=20 > Actually you did NOT change the below patch to superseded after you send > a new version (I did this) and you didn't reply my last question yet. > https://patchwork.dpdk.org/project/dpdk/list/?series=3D23046 >=20 >=20 why am I confused here? The patch you linked above is not related to this = patch. The patch series linked above is an update to the hotplug patches that were= =20 requested prior. (I screwed up the initial new series submission I admit, = and marked those as superseded). *This* patch however I've not submitted a new update for yet. =20 And I don't see where you asked a question ? > > > > > > > > > > > > > > Thanks > > > > > Qi > > > > > > > > > > > > > > > > > --- > > > > > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > > > > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > > index 8810d1658e..8d1bc6c80d 100644 > > > > > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > > > @@ -1538,9 +1538,21 @@ STATIC s32 > > > > > > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool > > > > > > *linear) > > > > > > > case ixgbe_sfp_type_1g_lha_core1: > > > > > > > *linear =3D false; > > > > > > > break; > > > > > > > - case ixgbe_sfp_type_unknown: > > > > > > > + /* Copper SFPs are not officially supported for x550em > > > > > > > + devices, but > > > > > can > > > > > > > + * often be made to work at fixed 1G speeds. Pretend > > > > > > > + they're > > > 1g_sx > > > > > > > + * modules here to allow g.Fast DSL SFPs to work. > > > > > > > + */ > > > > > > > case ixgbe_sfp_type_1g_cu_core0: > > > > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP > > > > > > > + is > > > > > > 1g_sx\n"); > > > > > > > + *linear =3D false; > > > > > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core0; > > > > > > > + break; > > > > > > > case ixgbe_sfp_type_1g_cu_core1: > > > > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP > > > > > > > + is > > > > > > 1g_sx\n"); > > > > > > > + *linear =3D false; > > > > > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core1; > > > > > > > + break; > > > > > > > + case ixgbe_sfp_type_unknown: > > > > > > > default: > > > > > > > return IXGBE_ERR_SFP_NOT_SUPPORTED; > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >