From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 597E6A0503; Fri, 20 May 2022 20:03:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F321A40222; Fri, 20 May 2022 20:03:03 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2126.outbound.protection.outlook.com [40.107.21.126]) by mails.dpdk.org (Postfix) with ESMTP id 769CD40156 for ; Fri, 20 May 2022 20:03:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZfmRIZUKxHhIkC7oYbCTCPq5gpuOMn6CUByt5838yoI7gjYw997LXU5mvkn7XsIdFZtnFqkBXjdgmwzNLrP54Pck8zKe13Asv28YHd4UyJdK52EMtLPk+c6hJyLuzbqx88os3x8MPioXHv77Yp1so//XI4Mr25A2qLK1zx6OQDKk5PTrTN6qlxk99PTfWaVIvhCH+oIAVqP164EZGWb2AMdoV5SEF5QFfCLdMDAfbtvOKCvNSrqgQJ7Xzli0qc5gwTTHm7pJBFUJe1esd83rps/eNZKgVXH/MTscwKzvav0bjqFldKEMfLzKWnr26U686PX7ycc36HumeiO4loArUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4J9QZKBmkbFB33Q5NJ4MjZrxpQ0TxWHDNxi0TmqgFG8=; b=T/FY3vH5oC1IlsXUR7p636dPwRnadYiH9faC4eW6bDvbn9QevofPEKG1KoTfWG/mSGcL3uj+LSSloV7TNEQDEQW5rlZl6OSgptUA50nBWl+tZIIE+ECORvkciA5Xm7F3WCFJoUsA2A3vbzh3DulENLkxrGg7Wzmt9DnI6CSVuP89aoNprGqAPQ3dhuQsQosdRJkouQVCxX/KOQEK51ETmLpVCWFYY2dVck+TzN/qDLyScB0vZcLiVOfCjwoimgIfq9gRf0OGmEXNbcFjYQXfMgU3bb5+jy3Sq9tTMYjT9xG3YBaoL/LzZEb0ay4jY9qgYN+kceq8byjjQaRhf4dH/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4J9QZKBmkbFB33Q5NJ4MjZrxpQ0TxWHDNxi0TmqgFG8=; b=bwhFT26F7Y8qHd+RQXcQyKOro63cLFC4ue9AF0+DZjVDaJeUhyhTCivxsnos/yVMVuMtAvzK6eUMZ9cOGo4xJapfNMBMVHnAdSHHrBh3rDpzaqnp89+UPB98704xDgyMD9ndN1DxwTe7Zzr6IoK0bEJQVX7ieF3mEzo34LMHmp0= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by DB9PR04MB8124.eurprd04.prod.outlook.com (2603:10a6:10:246::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18; Fri, 20 May 2022 18:03:00 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::a8d9:7211:83e:46db]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::a8d9:7211:83e:46db%4]) with mapi id 15.20.5273.017; Fri, 20 May 2022 18:02:59 +0000 From: Jeff Daly To: "Zhang, Qi Z" , Thomas Monjalon , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOR1ZG0azI89kSESFkJBuENiqzuHpQAgDk5yICAASnaUA== Date: Fri, 20 May 2022 18:02:59 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1681763.yIU609i1g2@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 63b5648b-c8ff-4181-a70e-08da3a8af9d6 x-ms-traffictypediagnostic: DB9PR04MB8124:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U29E/uiQBgnSl2CDGMSLdo7oSSSXQ00mxCpp8z5HYwHiX41cd/b4h2QawV6XfNUl4LziZ2bVWmDJ+yKqTQQUUZ3uivWg4w04XBQa73lQVTfeE0v6Z0hTUgn5+Fz2XtExMNBMnLM1fNE+235M/ctFRH11G0jBTPIlbIioOM/OWF74hCURsS/b9b+VUlbTJ8/zJMnSr/ATLayhtaKlrmrZ5rk480kxuRzaai5C5mYFgQnoh8Rdu+feB3Vbg3Ba2qI/tUkzYwPfBqSQjDoTOLdTOCZz75ZECO7ZiYEAfDC3tCYDrizLTm9SP6fZi5ML7fCewRu0JdEEsT5mbpJi3mEslVP1obPwyEr4J+oTPotXrA0G7ly5OuBtmMgpeksjS+j/OuaiA3Um3LfsF7qcCkDHjfOAq/V89YEBlZBqkC0UljsMtRwEQH4F4S+30J4z9khQxFh1RL+V+TCu3XsOlaWX8nFRvVt1WCdve6LZNr0h7CuRYUdURP5sTINQAzZ3MHZ8Og8AlIMq8bfK9fVgj5hxyUTXaCaaBZqeL/D408FF19iikpc3a+o7F8QJ81J1cgjhyROOefHDB2semumIBG93huXVLjno/KtoG49Q7mN8OzguuO+mO9etOrjDjIqy8XHn1kXMDxgwWLT5WEwKUMdfhYdvDdxzqhqd4dWwnHYeziH8gIIJJxIU0ip47oxjwNCBIbwxHed0nh8IOgxfaFGS9CPzsq3e287eh6hL9VzEetv8MK5sTXvhnIlkwo8DbuaMWWFD191xDDtjgjiZyIEUtlwizS8vgyasbG9Zhi30s+w= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(110136005)(86362001)(54906003)(186003)(38070700005)(38100700002)(2906002)(316002)(83380400001)(5660300002)(64756008)(71200400001)(8676002)(966005)(4326008)(66476007)(66446008)(66556008)(66946007)(76116006)(508600001)(122000001)(55016003)(8936002)(7696005)(6506007)(33656002)(9686003)(53546011)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PjKTyvZTY4nPLgjbLSfOPx3sptkq3SxuoS0Pc9lrUIfIx8IpG6tkMzOOVRDG?= =?us-ascii?Q?I3DG51DI4YGJ26bB5ttbvSewk4TEwbvRNtNWp3n0ByBuCft+NCkMM6lG5OoX?= =?us-ascii?Q?Vey/KosebocT3bTP9cBlzza/IQdwyrJubgx7Zy9W7kjW9U8N4o0tVtik3zXP?= =?us-ascii?Q?T5ogCnUSew0IXb2M/z5HauXUWDT7mE+6bZlACLSpgN5YEIBKHd40Rkh6+Y3/?= =?us-ascii?Q?H8Yvz7C4b00Rs+1nBbV3rqd1ELyh6HyAPEpETJfXkw6r30ALMFFKWhtBPviQ?= =?us-ascii?Q?4Ak4pP9aAYoaT2mt/Sudsq7OKzb0RC5swIkBdUk21QAViBmUtP1ehpzxFNZD?= =?us-ascii?Q?EEh42nHeptlWl+rbYrLNeRSBNuzFG1b68LbyIyRnmW1Q3DDj4PRfVeoXTzsw?= =?us-ascii?Q?XLvPy/qsCHbu/YRUDFNDRKF1s7rZXCsUuVzLhinowrtRgiuiaamq+RqVP5vZ?= =?us-ascii?Q?msKTpUw7rxswznSwJ5MyyVKvgkLfLAv2MtL/03uneCOyA7tCbVzyZbirlEE/?= =?us-ascii?Q?nBXsVDyjmUUmvtnwBFQ5RAD/Sk6nuquG+F8ld1gL2dXBiGmoFPIGSMI65ekq?= =?us-ascii?Q?CzxBoUcFvAK2x2hFV9/GiSfGJyeQIztosb0AVk/xMrhWyrEiCyMu+wFBKMo8?= =?us-ascii?Q?kepivWbZiBObvQQ9AMmmBvriXIAAYnCK5eodOo8KnfubPuPfvU2OECNrPRlq?= =?us-ascii?Q?deupdjV7CuJoaXJJBegRj5P91IdYwPiWT/XEgdT6Atv4bMk8/VL/zpJKXs/a?= =?us-ascii?Q?QFCU1eIRe2Sbw+ON+3wOdVAJVXmclG0eaTh8yGebzcYMAeQXqTklBixIj6/g?= =?us-ascii?Q?gsBa6BVDh8DP8QJubZCpMrsXk/52mnPM3IX0YL3rkbn4JOes9/1QYGOK2YMd?= =?us-ascii?Q?RiNrRjWY7Z8NQn7Bxj7m/vfHL7d+1Jgx+Io0fYDVEmh+20skE8l512SpgWC8?= =?us-ascii?Q?vPfAsVmMiHOzUu9g13in1xrpUrIs0xNaW3GIAjIT+euhCESpWrdN5Y3AknLy?= =?us-ascii?Q?nRi1Scr02FhYA5Q+Hh13ZgSWJgHYz4Rg3aPOVXlx8RLooADbM7TNqsgShe7B?= =?us-ascii?Q?fLmb3zEqeDU3gWaOiL6dNzv5VW74AO+NfJnz6o/dSODbhQdwp4LiREolCqWE?= =?us-ascii?Q?MLgpvFNcF8y8I01YAHVVKgXh3m/5tSWjF7H/c3U+G1V1la6BYpwB0nFieyfI?= =?us-ascii?Q?cQToMBJRAz3riEt3mk6DLXTfkGwVWpUZJ+qgIlVenzMdpWzG2mHQNavCmEmR?= =?us-ascii?Q?zutOV7iUzITl2Dh6S7G0VNmMtgdpVeoVvmClILwWY83VNoIiwsJXCVKBGlL3?= =?us-ascii?Q?VwNQw+bRjNu4Bl4wdPpm+Gc+tAVNS7jN5g1Jp7RfDn+p+RF4AO2LacFi8V9K?= =?us-ascii?Q?KNCrU+keSMcrZKNBSs5ZNOBxhS3tae3J3TaoIK4F+83DXTOSlcoRuM+mxWS8?= =?us-ascii?Q?K+7r7I1jgUwQ7ebEEWP1B18cPBA2O7F7LcG/EjpZ3z2XzTeWoUi1Jg5VZ50f?= =?us-ascii?Q?Eg6wdEuOD0G4Z9sXwbQoirid5JSWsbiCMQ/1NRsIyT2/ZYnwUkQ0mTDUuWsX?= =?us-ascii?Q?4+yUGylgOohlTxbh2VMpKTNiO0g2DfpvdzuH7xUez5JQhzAur9rkYs8UM9MQ?= =?us-ascii?Q?gww++HfGbDoK3ZpVLaCYHDuQ9gBdylJ/eKgPE/0h3W77J8RVbkMyUTEnlXOw?= =?us-ascii?Q?bfpNBDGv0tWfw6jsw9H2s13MU/ft59eEYI+qP8FaS91X6x2dWBY+JmPFXrft?= =?us-ascii?Q?CsYtWOVuFnv/o7fRxYDrUtl/fpd1k9El3msRNVocNNBwoxl4p6f3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63b5648b-c8ff-4181-a70e-08da3a8af9d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 18:02:59.7213 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ytY/z/8KgNP8TU5Jh97xRAfQYapNP/LnNcFfGvh07GDmX3iCkl11vj9VVPIqWTKdLx5kG3qQ/EBSlLFdi2wPoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8124 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, May 19, 2022 8:15 PM > To: Thomas Monjalon ; dev@dpdk.org > Cc: Stephen Douthit ; Jeff Daly usa.com>; Yang, Qiming ; Wu, Wenjun1 > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Wednesday, April 13, 2022 10:21 PM > > To: dev@dpdk.org > > Cc: Stephen Douthit ; Jeff Daly > > ; Wang, Haiyue ; Yang, > > Qiming ; Wu, Wenjun1 > > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > > devices > > > > Please, could we have a review of this patch? > > +Cc new ixgbe maintainers > > > > > > 07/03/2022 23:34, jeffd@silicom-usa.com: > > > From: Stephen Douthit > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 family of > > > devices but treat them as 1G SX modules since they usually work. > > > Print a warning though since support isn't validated, similar to > > > what already happens for other unofficially supported SFPs enabled > > > via the allow_unsupported_sfps parameter inherited from the mainline > Linux driver. > > > > > > Signed-off-by: Stephen Douthit > > > Signed-off-by: Jeff Daly >=20 > I think we need a devargs for this feature with well documentation So, it > should not break existing behavior by default, but allow people to take r= isk > if they know what they are doing. >=20 there was already a patch submitted to IWL mailing list for this feature in= the base driver, which was rejected. =20 https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220414201329.2= 7714-1-jeffd@silicom-usa.com/ > Thanks > Qi >=20 >=20 > > > --- > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > > index 8810d1658e..8d1bc6c80d 100644 > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > @@ -1538,9 +1538,21 @@ STATIC s32 > > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear) > > > case ixgbe_sfp_type_1g_lha_core1: > > > *linear =3D false; > > > break; > > > - case ixgbe_sfp_type_unknown: > > > + /* Copper SFPs are not officially supported for x550em devices, b= ut > can > > > + * often be made to work at fixed 1G speeds. Pretend they're 1g_= sx > > > + * modules here to allow g.Fast DSL SFPs to work. > > > + */ > > > case ixgbe_sfp_type_1g_cu_core0: > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP is > > 1g_sx\n"); > > > + *linear =3D false; > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core0; > > > + break; > > > case ixgbe_sfp_type_1g_cu_core1: > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP is > > 1g_sx\n"); > > > + *linear =3D false; > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core1; > > > + break; > > > + case ixgbe_sfp_type_unknown: > > > default: > > > return IXGBE_ERR_SFP_NOT_SUPPORTED; > > > } > > > > > > > > > >