From: Jeff Daly <jeffd@silicom-usa.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>
Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug
Date: Thu, 14 Apr 2022 10:49:58 +0000 [thread overview]
Message-ID: <VI1PR0402MB35175CC43A2973796B9B46EDEAEF9@VI1PR0402MB3517.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB3495F9B9AC093555B8B417A0F7EC9@BYAPR11MB3495.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Tuesday, April 12, 2022 10:47 PM
> To: Jeff Daly <jeffd@silicom-usa.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Stephen Douthit <stephend@silicom-usa.com>; Yang,
> Qiming <qiming.yang@intel.com>
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments.
>
>
> > -----Original Message-----
> > From: Jeff Daly <jeffd@silicom-usa.com>
> > Sent: Wednesday, April 13, 2022 01:42
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Stephen Douthit <stephend@silicom-usa.com>;
> Wang,
> > Haiyue <haiyue.wang@intel.com>
> > Subject: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> > hotplug
> >
> > Currently the ixgbe driver does not ID any SFP except for the first
> > one plugged in. This can lead to no-link, or incorrect speed conditions.
> >
> > For example:
> >
> > * If link is initially established with a 1G SFP, and later a 1G/10G
> > multispeed part is later installed, then the MAC link setup functions
> > are never called to change from 1000BASE-X to 10GBASE-R mode, and the
> > link stays running at the slower rate.
> >
> > * If link is initially established with a 1G SFP, and later a 10G only
> > module is later installed, no link is established, since we are still
> > trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner.
> >
> > Refactor the SFP ID/setup, and link setup code, to more closely match
> > the flow of the mainline kernel driver which does not have these
> > issues. In that driver a service task runs periodically to handle
> > these operations based on bit flags that have been set (usually via
> > interrupt or userspace request), and then get cleared once the
> > requested subtask has been completed.
> >
> > Fixes: af75078fece ("first public release")
> > Cc: stable@dpdk.org
> >
>
> So BIG change for new platform, DON'T CC to stable!
>
> > Signed-off-by: Stephen Douthit <stephend@silicom-usa.com>
> > Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 533
> > +++++++++++++++++++++++-------- drivers/net/ixgbe/ixgbe_ethdev.h |
> > 14 +-
> > 2 files changed, 410 insertions(+), 137 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index f31bbb7895..9e720eee47 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -236,9 +236,6 @@ static int ixgbe_dev_interrupt_get_status(struct
> > rte_eth_dev *dev); static int ixgbe_dev_interrupt_action(struct
> > rte_eth_dev *dev); static void ixgbe_dev_interrupt_handler(void
> > *param); static void ixgbe_dev_interrupt_delayed_handler(void
> > *param); -static void *ixgbe_dev_setup_link_thread_handler(void
> > *param); -static int ixgbe_dev_wait_setup_link_complete(struct
> rte_eth_dev *dev,
> > - uint32_t timeout_ms);
> >
>
>
> > + /* TODO - Even for platforms where ixgbe_check_sfp_cage() gives a
> clear
> > + * status result, if there's no interrupts, or no interrupt for the SFP
> > + * cage present pin, even if other interrupts exist, then we still need
> > + * to poll here to set the flag.
> > + */
> > +#ifndef RTE_EXEC_ENV_FREEBSD
> > + struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
> > + struct rte_intr_handle *intr_handle = pci_dev->intr_handle;
> > + if (rte_intr_allow_others(intr_handle)) {
> > + /* check if lsc interrupt is enabled */
> > + if (dev->data->dev_conf.intr_conf.lsc)
> > + have_int = true;
>
>
> > + /* Check for loss of SFP */
> > + /* TODO - For platforms that don't have this flag, do we need to set
> > + * NEED_SFP_SETUP on LSC if we're a SFP platform?
> > + */
> > + if (hw->mac.type == ixgbe_mac_X550EM_a &&
> > + (eicr & IXGBE_EICR_GPI_SDP0_X550EM_a))
> > + intr->flags |= IXGBE_FLAG_NEED_SFP_SETUP;
> > +
> > return 0;
> > }
>
>
> TODO ?
>
These were notes that some further refinements could be possible. I can remove the comments if that makes it more acceptable. The first TODO was a note that (for FreeBSD mostly) w/o interrupts the code below (not shown, which checks for 'have_int') will run vs. exiting early and relying on the NEED_SFP_SETUP flag being set elsewhere. The 2nd TODO was a question from the original developer to himself where (I believe) he was considering other implementations which may not use MOD_ABS the same that other platforms do. I don't think this is an issue (that I know of) so removing this commend and just moving on would be the best thing, and if someone else knows of a situation where this consideration might need to be made, then another patch can be submitted to address it.
> > --
> > 2.25.1
next prev parent reply other threads:[~2022-04-14 10:50 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 22:19 [PATCH v2 0/7] ixgbe SFP handling fixes Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Stephen Douthit
2021-12-20 7:45 ` Wang, Haiyue
2021-12-20 21:32 ` Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 2/7] net/ixgbe: Add ixgbe_check_sfp_cage() for testing state of PRSNT# signal Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Stephen Douthit
2021-12-20 7:53 ` Wang, Haiyue
2021-12-20 21:32 ` Stephen Douthit
2021-12-21 1:15 ` Wang, Haiyue
2021-12-21 8:57 ` Morten Brørup
2021-12-22 1:24 ` Wang, Haiyue
2021-12-22 10:43 ` Morten Brørup
2021-12-22 16:03 ` Wang, Haiyue
2021-12-22 19:13 ` Morten Brørup
2021-12-22 21:44 ` Stephen Douthit
2021-12-23 0:55 ` Wang, Haiyue
2022-01-18 21:06 ` Stephen Douthit
2022-01-19 0:31 ` Wang, Haiyue
2022-02-07 16:04 ` Ferruh Yigit
2022-02-08 13:50 ` Jeff Daly
2022-02-08 14:52 ` Ferruh Yigit
2022-02-09 4:00 ` Wang, Haiyue
2022-02-09 13:33 ` Ferruh Yigit
2022-02-09 13:43 ` Wang, Haiyue
2021-12-21 14:05 ` Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 4/7] net/ixgbe: Run 82599 link status workaround only on affected devices Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 5/7] net/ixgbe: Fix SFP detection and linking on hotplug Stephen Douthit
2022-02-07 16:07 ` Ferruh Yigit
2021-12-06 22:19 ` [PATCH v2 6/7] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs Stephen Douthit
2021-12-06 22:19 ` [PATCH v2 7/7] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Stephen Douthit
2021-12-17 9:29 ` [PATCH v2 0/7] ixgbe SFP handling fixes Thomas Monjalon
2022-02-24 15:23 ` [PATCH v3 0/3] " Jeff Daly
2022-02-24 15:23 ` [PATCH v3 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Jeff Daly
2022-02-24 15:23 ` [PATCH v3 2/3] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Jeff Daly
2022-02-24 15:23 ` [PATCH v3 3/3] net/ixgbe: Fix SFP detection and linking on hotplug Jeff Daly
2022-02-25 1:56 ` Wang, Haiyue
2022-02-25 20:50 ` [PATCH v4 " Jeff Daly
2022-02-26 15:57 ` Ferruh Yigit
2022-02-28 15:29 ` [PATCH v4 0/3] ixgbe SFP handling fixes Jeff Daly
2022-02-28 15:29 ` [PATCH v4 1/3] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs Jeff Daly
2022-03-01 5:56 ` Wang, Haiyue
2022-03-01 11:18 ` Zhang, Qi Z
2022-03-06 17:56 ` Thomas Monjalon
2022-03-08 15:01 ` Jeff Daly
2022-02-28 15:29 ` [PATCH v4 2/3] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Jeff Daly
2022-02-28 15:29 ` [PATCH v4 3/3] net/ixgbe: Fix SFP detection and linking on hotplug Jeff Daly
2022-03-12 13:03 ` Jeff Daly
2022-03-10 12:35 ` [PATCH v4 0/3] ixgbe SFP handling fixes Zhang, Qi Z
2022-04-12 17:34 ` [PATCH v5 0/2] " Jeff Daly
2022-04-12 17:34 ` [PATCH v5 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Jeff Daly
2022-04-12 17:34 ` [PATCH v5 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Jeff Daly
2022-04-12 17:42 ` [PATCH v6 0/2] ixgbe SFP handling fixes Jeff Daly
2022-04-12 17:42 ` [PATCH v6 1/2] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Jeff Daly
2022-04-13 1:21 ` Wang, Haiyue
2022-04-13 15:32 ` Jeff Daly
2022-04-14 1:56 ` Wang, Haiyue
2022-04-12 17:42 ` [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Jeff Daly
2022-04-13 2:46 ` Wang, Haiyue
2022-04-13 6:57 ` Morten Brørup
2022-04-13 7:01 ` Wang, Haiyue
2022-04-13 7:19 ` Morten Brørup
2022-04-13 11:49 ` Wang, Haiyue
2022-04-13 12:54 ` Morten Brørup
2022-04-13 15:23 ` Jeff Daly
2022-04-14 10:49 ` Jeff Daly [this message]
2022-04-14 11:08 ` Jeff Daly
2022-04-14 2:49 ` Wang, Haiyue
2022-04-14 2:59 ` Wang, Haiyue
2022-04-14 10:40 ` Jeff Daly
2022-04-14 12:11 ` Wang, Haiyue
2022-04-18 21:54 ` Jeff Daly
2022-04-19 2:05 ` Wang, Haiyue
2022-04-19 17:33 ` Jeff Daly
2022-04-20 1:09 ` Wang, Haiyue
2022-04-21 17:31 ` Jeff Daly
2022-04-22 2:11 ` Wang, Haiyue
2022-05-12 1:26 ` Zhang, Qi Z
2022-05-25 16:55 ` Jeff Daly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB35175CC43A2973796B9B46EDEAEF9@VI1PR0402MB3517.eurprd04.prod.outlook.com \
--to=jeffd@silicom-usa.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).