From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A2A7A00C2; Mon, 23 May 2022 16:13:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBC244014F; Mon, 23 May 2022 16:13:35 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80090.outbound.protection.outlook.com [40.107.8.90]) by mails.dpdk.org (Postfix) with ESMTP id 102F840141 for ; Mon, 23 May 2022 16:13:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WI2ZhG1WDa1cP6+H1uNKq0K0CEZAozpHewV0DUL1mdyMGZQwRjYhke/+thoR105bRqLKTiwlgyiUPwv0XMyGA+8Qk7/mzNm+S4b7CHOb4UjUvYpW6yPQyUszBwtLdqDhbqvaMNrQiu52/YOcVbhycYENXEtwVWHqxskaaJCS8CSo7X70hwpQ/AiFY7v1fVznuaXezcfgndsnA+DdTcUhp8pBkEVWWvzUEd2KCo0gvnMH3BAsw9AQKllUwxsDI54EjMIFOjGuoyXQyL20kokuGahue1ZaH7rEg+Bn/Ixrzq+65wJPzzHhdNZ2/6x61GH8XKocZUIj8LPaUt72CRUtXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SE5kQjGVehaJvniMz8JSbqGQQ6PYxaQv0XsuzAQOQ/Q=; b=YVl04LMdgVUvjK1UadoHVoKJKBXoAd3Y75hHr1s9UHaO5ASuxG0vu3llp2ga8TSfJiqMxRDM61y7HQrnm7NJ2N8FUKxe9q8Dvrrh4+1EjTzzhE+itPFnBZxViiaRn8MfCu+pVJcQzFBDObEbOc62r0z6xheEkV+nsYCo3aCj8mwlWI8gNKVgM8AK+bm4if/SldvKHL+xnDxif+293X7OdaAkiZjY+1xau8mFh7mARuSn604gtDlt+hM2Ykp7jnILeEoo749lAJWfdciTbTlL3EwiPuR8S1UmEYvS6RtPyUqAa1ey8Bwmih1LZ0kLnh5qMgTNgz/Y64E+aiX/9pB7qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SE5kQjGVehaJvniMz8JSbqGQQ6PYxaQv0XsuzAQOQ/Q=; b=MqKm8dW4Mu0p6sZewpQYM8wuwEiPoI5owRoYzhPu19ltgJi6ztB0J4TYxwGBkZgTy60LpzePqncD52FBBn6Ag7eQuuM+vPaptZ2DVTQy1qS9/SrL1fDCoOcxBMknskgh7pMgrtK55YJCLu44d1yb9FEJ+tmoZdLApehihbwPtaI= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by DB7PR04MB5979.eurprd04.prod.outlook.com (2603:10a6:10:8f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 14:13:31 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::9198:ca97:d3b9:d3cc%4]) with mapi id 15.20.5273.022; Mon, 23 May 2022 14:13:31 +0000 From: Jeff Daly To: "Zhang, Qi Z" , Thomas Monjalon , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOR1ZG0azI89kSESFkJBuENiqzuHpQAgDk5yICAASnaUIAD5wuAgACO5OA= Date: Mon, 23 May 2022 14:13:31 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1681763.yIU609i1g2@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8df16fe1-aeea-4cf3-05ab-08da3cc66a54 x-ms-traffictypediagnostic: DB7PR04MB5979:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ahJqaqP/CMfSgnEoBMS6znEVeNcum9HLK+qAunltkMve6pHNKhwe71GLTjt/9euhGULjVA4xcpjfBOp3moCuUdBvxPLaQNSaFIyf2O//ifgxN9bp4tlb/uNnmh8d+ArjRHgKPYfHQl61OpepEN7s7aNmSOZk0Flk+THsGgUzWTUsNGauLJBUXza0LUCJ6RYvC27gwrxoZJEiAV41CUeOAs5MfUm+CGYuCM6nmGcF68i0BK9dRHEU5nNDgz+tFENybkCBOk+HXm6FSE3fIyW1rxqImzYJ5DrhAS51Su0GNreCpxk446R/uhr0QvITSa4vHIA5sF1dep9I8zN6bDoK/B0XoJ/dWQWNL6UvyEJo/vAhkN81SmcYsx+NKtn4EDjv6czsmmGo4f7QX6FDXh8Y7ZKe8PcjPIvETMiYewISQVyIITkMhAtmTaCbMPq/yIlcmGjkO6PqndZSQgGKp0PfVCL0auNA5w6tJo/l9/UP5+/cYhzFNxcevt0eGQlH0NsHx0toxkrbDZrIKApQ4YGuFt08HbtESLRPztDiV+uvEIz7KNHFnk9aHnyFARCIH8M9HAhbsIuUvoXOG525de1J5MGEY/e9eAKDncPm1O5qzHNyUqwYXqzpIBViQtebFLl9FVw/89dsEYr2msyPJ6qzbGz9cMqBv9kjE0f/KfKlQOvtIVa6Ao2eJCitB9kiohAHuyPQOPOt4dhwk8kD/4R30Y2yyVAjoR29fHvAhviNN0iydDnpQa9k2JzLd1nVuAVa5EC9CsaIklAqF8HmEtJFNauUY4HosD5R+6HsFsBzHwo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(110136005)(316002)(52536014)(186003)(53546011)(54906003)(38100700002)(9686003)(55016003)(6506007)(7696005)(71200400001)(33656002)(966005)(2906002)(8676002)(4326008)(122000001)(38070700005)(76116006)(86362001)(508600001)(8936002)(66946007)(83380400001)(64756008)(66476007)(66446008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mdfnvAGzWD+DD+CzvRZri1XCRR0k33SylwxZ8AhLEi8quHbvCvQD3QBeJ8pD?= =?us-ascii?Q?/c6udVZP+0HHym9tiuH1cWPvuDvwZ/powBhJDCybLvoPtIYnENl331+XwIn3?= =?us-ascii?Q?gego8TC5SrjgABlbe8mTEnnA9GD8H8s41iL58eK3vO7U3TEFQlveGCfSnJ5z?= =?us-ascii?Q?gpXSIV6o9EppTFuYJMWIhgiW0iuJ0fdHyoaotDic3bph5wB/ESks+8PGsuTk?= =?us-ascii?Q?jge31RW8dy7Mcvcsk9Z+anv9PLjRqONqQVIzeLNclm8Mahmt6xA+gxiV0qw1?= =?us-ascii?Q?FV7i5cE8jOUP4NUSNBQam2vYhGCaryG90IjsuX5Se3DS/Q8GxqdFmc4uu7+3?= =?us-ascii?Q?AHQ3y4yWpAv7BHx77B/1e903mbKmYFewJ8JqKC/qHJbps22QrtS/JbQHYCoz?= =?us-ascii?Q?gnZwMaOg1kU9zHy1TJHCN+dBBGjS4VvfPuMIB8OiZ3HEJPrGhUUvVOucKwyz?= =?us-ascii?Q?ePBxhOhOfYhZRIgneR5xkKBsn4w1eta/2aG17AT6FePZN8VV3lbB5KosMkrR?= =?us-ascii?Q?STI74Ty4HpH5u6R8nw4vFvRJobPgYgfHrEtOyIpTuFvp7voxmWm9sSyW1qvv?= =?us-ascii?Q?Ow6R6eL2MjxVXcnmMYx7oPZQThSaVmf/jzQr0ixQhoWwJrWRvieimHOQm9pZ?= =?us-ascii?Q?hOfW8R5aagBgBOaGvD3PkaAYyLgWa3iLPYeBpX9QO1QRpLRglwcIh1l9qSgL?= =?us-ascii?Q?WzpYz/N0JcWm9ssdXncfmOF+IumTHI7Go9qYkSRe28AoreFupdaGVA56iLhB?= =?us-ascii?Q?EYpJLOoexqOt7CfNr5K6QKyJN99pb6VSjl6ILmtY0s7xJDe/2nGVU/7xWwHj?= =?us-ascii?Q?zuHO5Y+mYbF37wKbEPGUlL+hKK15l3+ITgCqeN91WRSWl8+kHR1Y+Uz5pkua?= =?us-ascii?Q?9Y+ubgYJxG7iJEpYXn9kD/pC+tjiIwk8oAOtycDgpeh6voy1MKJIx4gOOr8r?= =?us-ascii?Q?Wb7uO7V1GajZS55g2U4cP4Z7owi/eA9/Dkr7OlKnWeyf0OeIuUHzH7nZmlV/?= =?us-ascii?Q?Lf9VZFchKAWOgbX9nqfxy5b5/ZX27Gw/rb/FgZaGnBcqKtr0vH/vaT7FxpLl?= =?us-ascii?Q?+2DkCyyy/gFVGcUT4toL29l3Tk07cJXgwEQTLNuNRcEvHAZepnavaDqfwNE/?= =?us-ascii?Q?uagFWFUIzp06i4ULXxaZLn2tMWW3yBR31ywXejOyUa9fM9pfnGSsCNMUu26l?= =?us-ascii?Q?a8289KSEPLThVT7byHxxZsEINCAuRE6W13BjxCm/hsWvbaHCom8RMhw4EXkx?= =?us-ascii?Q?BxGcZ0c7jXe9eV2wDL1N0JdvaDaDrTWmFeW8aqVm2jdwNkRtDe47m627fQMx?= =?us-ascii?Q?8nCgMYveGFe1TSFuTVDGT5rR0TBEaCCmwpZb9eZdJIRlxROQwPg2ULqku12h?= =?us-ascii?Q?UJCxTVjAgCZLaHqGwFKX2H0SO95S6MaBG8ORxiwA+jVGxA1OXig94yP+M1VT?= =?us-ascii?Q?Mar/zuqeRRSzOvs2V74HruHdQ9+4VMH8Y8Nt4KUVfCwFMJ/eOIS2QVDKZQ6B?= =?us-ascii?Q?pRCwhDzHR6i/MU2IzI5QxmWpoWU4JeakQ0Gq4vFELGHxPutvIkYjxGa+CmH6?= =?us-ascii?Q?rz+VsgEpyFsGcKoPTvObB04TftKAzl3j064/+i5PNN8uNXzaqkICRcfjJOX7?= =?us-ascii?Q?qavD/qm4lPiPA+1qwiNBRPlJvWpFs1pY/4TMgOS3pRIb5ejUKTCxlEJfHCCg?= =?us-ascii?Q?No+foGVEkhIlzik6kyoMR+IY4ujfRUwE0jou4H2YKD1iOrPYtnxpVJB7g3qS?= =?us-ascii?Q?bUuZtGaIgG4Wsg/2t7taGD/sNkHx4TA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8df16fe1-aeea-4cf3-05ab-08da3cc66a54 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 14:13:31.1272 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MsUBRhbDl//ASlDYU7HelR7m3wY/69u/+hMin42YYfd/h97fsR6p4ay1oJteuzPOzR9VydrBhbpe+I990CQoWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5979 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, May 23, 2022 1:37 AM > To: Jeff Daly ; Thomas Monjalon > ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > -----Original Message----- > > From: Jeff Daly > > Sent: Saturday, May 21, 2022 2:03 AM > > To: Zhang, Qi Z ; Thomas Monjalon > > ; dev@dpdk.org > > Cc: Stephen Douthit ; Yang, Qiming > > ; Wu, Wenjun1 > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > > devices > > > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Thursday, May 19, 2022 8:15 PM > > > To: Thomas Monjalon ; dev@dpdk.org > > > Cc: Stephen Douthit ; Jeff Daly > > > ; Yang, Qiming ; Wu, > > > Wenjun1 > > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > X550 devices > > > > > > Caution: This is an external email. Please take care when clicking > > > links or opening attachments. > > > > > > > > > > -----Original Message----- > > > > From: Thomas Monjalon > > > > Sent: Wednesday, April 13, 2022 10:21 PM > > > > To: dev@dpdk.org > > > > Cc: Stephen Douthit ; Jeff Daly > > > > ; Wang, Haiyue ; > > > > Yang, Qiming ; Wu, Wenjun1 > > > > > > > > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > > > X550 devices > > > > > > > > Please, could we have a review of this patch? > > > > +Cc new ixgbe maintainers > > > > > > > > > > > > 07/03/2022 23:34, jeffd@silicom-usa.com: > > > > > From: Stephen Douthit > > > > > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 family > > > > > of devices but treat them as 1G SX modules since they usually wor= k. > > > > > Print a warning though since support isn't validated, similar to > > > > > what already happens for other unofficially supported SFPs > > > > > enabled via the allow_unsupported_sfps parameter inherited from > > > > > the mainline > > > Linux driver. > > > > > > > > > > Signed-off-by: Stephen Douthit > > > > > Signed-off-by: Jeff Daly > > > > > > I think we need a devargs for this feature with well documentation > > > So, it should not break existing behavior by default, but allow > > > people to take risk if they know what they are doing. > > > > > > > there was already a patch submitted to IWL mailing list for this > > feature in the base driver, which was rejected. > > https://patchwork.ozlabs.org/project/intel-wired- > > lan/patch/20220414201329.27714-1-jeffd@silicom-usa.com/ >=20 > OK, thanks for sharing this, >=20 > But base on the concern of the previous comment >=20 > " As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules requi= re > the use of RX_ILOS and some Intel Ethernet products don't support that." >=20 > We may have a risk to accept the code as default behavior >=20 > But devargs is allowed in DPDK for device-specific features. >=20 ok, I will submit a revised patch that uses a devargs (or whatever) switch = to allow the behavior when selected explicitly. But, can we *please* STOP marking patches as superseded when a follow-up pa= tch hasn't been submitted yet!? I've marked the patch as 'Changes Requested'= for now. When I submit a follow-up I will set this one to superseded. >=20 > > > > > Thanks > > > Qi > > > > > > > > > > > --- > > > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > index 8810d1658e..8d1bc6c80d 100644 > > > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > > @@ -1538,9 +1538,21 @@ STATIC s32 > > > > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool > > > > *linear) > > > > > case ixgbe_sfp_type_1g_lha_core1: > > > > > *linear =3D false; > > > > > break; > > > > > - case ixgbe_sfp_type_unknown: > > > > > + /* Copper SFPs are not officially supported for x550em > > > > > + devices, but > > > can > > > > > + * often be made to work at fixed 1G speeds. Pretend they're > 1g_sx > > > > > + * modules here to allow g.Fast DSL SFPs to work. > > > > > + */ > > > > > case ixgbe_sfp_type_1g_cu_core0: > > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP is > > > > 1g_sx\n"); > > > > > + *linear =3D false; > > > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core0; > > > > > + break; > > > > > case ixgbe_sfp_type_1g_cu_core1: > > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP is > > > > 1g_sx\n"); > > > > > + *linear =3D false; > > > > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core1; > > > > > + break; > > > > > + case ixgbe_sfp_type_unknown: > > > > > default: > > > > > return IXGBE_ERR_SFP_NOT_SUPPORTED; > > > > > } > > > > > > > > > > > > > > > > > > > >