From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F9BFA00C3; Thu, 12 May 2022 19:01:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9502D410F2; Thu, 12 May 2022 19:01:18 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60107.outbound.protection.outlook.com [40.107.6.107]) by mails.dpdk.org (Postfix) with ESMTP id 649FF40DDD; Thu, 12 May 2022 19:01:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GfYU7hzjNojqnaJT0QSU0oEDjKy9w01FIuUq03vsN3lVLSfEOARPNkaUaBoraotJT5/GDHspg9iSeqrRVGuuywIR6gMYbcF56FkJk2l9vx7VvPemQwMJ/C6fmi5Ms0yijB5WevEu+PYnpN6Jipa9W/pcG5I0+VN1Kr/SFLH1VpFEade2Xi2LyXTlm2AiND1VX1WHsi+a/QC7FfEeqbWhLgVCJk8idgc4Aw0QLY6Wp9ZhiMm913kR8IHfPWTw67UzOXHDpyYhQQ3SJ7QjkpBz1HQ49w/DJIMoHQHdDjwHWTZlcNO4fOiMyfgMyIfgZ1se21LHKu4aGaFQdpLyqjryFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gzhurQOduLnSZnEA2bD0ZHSF86Zgu7m785ddrgZTP8Q=; b=ABHiKw9YdIZCtAWtoKDm3D7JqkgraXe/B2z8dl+5BMvlqKD5RpLpLDgyyReehzDu1TgcCl/bKy/mLhdD2fm6OL4xhUwOXqwOODtV1zr1OVupRrqTMFT8GvJptv1FlbZXck8snAMY8YyBDEaz8liumIYLFXX+07K4dR5ZEel/rSZbI9kVbzXZtt47rUe639rYSIfBeh3w6OZEsIc/MHJwDbSh6+RqXqU612lL0icWyy67Z+Mz3e8ZpaH2yADXtbKTcEF18hEtP2dN5ghaWgD8O0jW+iI9nR1JzfJ5fXfimMw3ceHn73SJLH1TxL+kfifQFPT1Xm254yezFlgq9IloYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gzhurQOduLnSZnEA2bD0ZHSF86Zgu7m785ddrgZTP8Q=; b=xFwaMiiBS36sj/lXoqXIBAn+fUNvhA/bVz7avGVmVqoEV9HBZd2VA7WkX4cObY9TSzfUzO3wH1XFnhsK1l6h3yREjZW6DRaT01+HqpibVUHTa3mryr7BLeV/S7frbqhgnqYIx+xFvTDEzb0I79iwsO7nCOHQECN5Hx6S4mXi2xQ= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by AS4PR04MB9387.eurprd04.prod.outlook.com (2603:10a6:20b:4ea::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Thu, 12 May 2022 17:01:15 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::d92d:6b1:cc94:fe26]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::d92d:6b1:cc94:fe26%7]) with mapi id 15.20.5250.014; Thu, 12 May 2022 17:01:15 +0000 From: Jeff Daly To: Thomas Monjalon , "Zhang, Qi Z" CC: "Yang, Qiming" , "Wu, Wenjun1" , "Zhao1, Wei" , Xiao Zhang , Xiaolong Ye , Lunyuan Cui , "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Thread-Topic: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices Thread-Index: AQHYZJ/StH1qH9u86Eq96zO3vXQezq0Zj3GAgAA0ToCAAbN1QA== Date: Thu, 12 May 2022 17:01:15 +0000 Message-ID: References: <20220510185725.27001-1-jeffd@silicom-usa.com> <36a68dda846440738e43d83a105b358c@intel.com> <10661272.5MRjnR8RnV@thomas> In-Reply-To: <10661272.5MRjnR8RnV@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba1247ed-e45a-490a-14f9-08da34390675 x-ms-traffictypediagnostic: AS4PR04MB9387:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fo9F8Q4w2NmuVYGrgeLNSMmqPNF9O7LyBB549G7JWjui3ydpl1J8ff34Ad83PrHqn6bCFUvL4i9lYj1JCBs611IUIuL7N9bqgHgaqEzmbtQ4ufqTTVw9rqNLhljmMzcejF40W2kMHkWTyoQ2JIDb2B77+4gtiM387iqeiyR6S154biMw8gm7ZJ7/V4o4F1dYQx4yIPRfM0hLKP6tKfSjC9KT0cxKfUD3fg8MNh1be3gWuc4gWAj2r4E891cfJuMujOtLz/ms2hqPGRs/ZmrMi+c0M0jXY/dPunlEzir2r09yEHOy+BPvtqjhUJ9CcPl/DYq4bS13oec4VquPOKwaF8++K/Mliiq293H+N+UXd+IjSxIRz/hmUiPou3UgajSAI8OqFdBLfW9F9RHdFmDKjsedduEyyqwpcFNye9tC6l+nT3UdZC7MOq2at1lZzctWtl2L6CVHLakk1zCLjQXuOsCGIpwrAmNgQAm2XkYfyVsRrkgkiYUsmE3fRwQEX6SDebkwTTqnTdfiyhSL+S5dw6BHeCwYtLxeKLGowhtatrxcyGp19M1VbfCaSjWear4lM0kMZeIhu0tFKTlX6+fJX5AecQmbioioMSosJa8L8Sd/IDEQ57HjrSDGEDGB+5MvrUoYRwGxBelmY7BXwtEnRZdNTkr79+vozE2IDmKr2aNfTZIKxX+5xHeOP66ZkWug6WQiG7E8jUm4zq6wW8+sAQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(71200400001)(508600001)(33656002)(9686003)(6506007)(186003)(7696005)(86362001)(2906002)(5660300002)(7416002)(55016003)(53546011)(122000001)(83380400001)(66476007)(8676002)(64756008)(4326008)(66446008)(54906003)(66946007)(66556008)(76116006)(38100700002)(38070700005)(110136005)(8936002)(52536014)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T9fVF9SY8ryJl+jRU/Avu7KOBCUJ+il4cO2/BI7vviuB8rOkZak/7jjJuB7t?= =?us-ascii?Q?fS4MEMvOmCvLFEWUi+KOmshX4XhOMSz3zhEdTDgQidvvv7xRWTKAjSvroDk5?= =?us-ascii?Q?CVe+H0HbL6JQLE1WH/41HjzvsIrMNPWr5EkvryuOp6B3njP+tnWAF/RGXFz7?= =?us-ascii?Q?78P/nzhzCg0dzlKxOYOH0enzTCtw85Qkan3//al1s594UQMbDQrYY/23iAjj?= =?us-ascii?Q?NFxkk2uqf+WiO/y90JZV8INpRfGp+NiIaCMsiJzpNBA9gh3Oq+tw/JeT7eWe?= =?us-ascii?Q?UcL5mOR10UrsnonGqr4g2w1QoVPMezh228LFNDmi91IK+ZK9Z3DN/YuhhRZc?= =?us-ascii?Q?hOxYCxv6pWwg2UELKQgxL6Z8mtZZQb7iMi32vzizOBwtQary24bz6OhjfMiq?= =?us-ascii?Q?ERSaTDNODCxXoyffGtM9/5x+t5JYtCQ/5bstQkya+46OIg1rbUVZrjRno00x?= =?us-ascii?Q?mPOhiNQ40oBTHZ4q55bye2wcFf5Da5mZNtb0kqO9oEkL482CIohTdafNyD3X?= =?us-ascii?Q?68Ajb+mBvYcy5FgOHTV1tQfHCzqBSyLQGDSF1AgYRPu0kVJRoCVq3Wz2BV1C?= =?us-ascii?Q?eFUbHD80CUwSsYspHscXNnkqX7lAcRgqqqk/Xrpf4zO84gadUGsEUIGX3Uel?= =?us-ascii?Q?2vdsRmdRVykbONuV5pxiNA2EZX6ZnMaDsZc3Bjipr5MHegwWc7hOwf18IREt?= =?us-ascii?Q?9hw3XVNoFIWKsoBdrx99hrR/xu/12FMWT1liIwU/tlkIldSY2QLt0D3yHqVf?= =?us-ascii?Q?ZRuyarW9QS4my3ZmDSSXwqzfntdYkNpvBFcqkkbap4TmHWicwranWkCfspaM?= =?us-ascii?Q?ZrEL84KMY/TAl1UvhwYSuh2oYdBKTodsm/Doq8TADFCSmR/TeBBqRhZ6NkGY?= =?us-ascii?Q?854C6M1eLFjdtriEZDKR6KFsN2KnO2kKipDQ3WiqWy1y/9d20UfiCezZ7CiJ?= =?us-ascii?Q?eC3BTu7uMua67/pMTCxC4DP/QzHp+88PLT8s8E8kO+YdcXnY3t+P7f2SFOCC?= =?us-ascii?Q?/8CgFUk0ZxqZz+rk1yBjf/shodPj2aIZJAH2Tryg1Wg4sSfiH33uHwhvCdPS?= =?us-ascii?Q?a4vlKgir/q2SsRJiC86MeAtY0/88pWWrc8WLMP4+A5x7TTinAWf4WMQrs+/W?= =?us-ascii?Q?h3qB61POktX1QjC20RHe8oTSY76IFEYEUBLCvvSQd2JGOURlXyB8FgfMVjGJ?= =?us-ascii?Q?8XjoCUvgWhJcdtuCDk4xk0An4KTdTHrFv8DBXGBRAy2pLjOWZ+MUl4i+fqWw?= =?us-ascii?Q?1y9OBmEQaXYaBiIBVzLvxfiqJ0vSJEsGAjp9lx274qVL564DBIyv2VpdA+xR?= =?us-ascii?Q?PWz6iw50KLx8kDMZAyzYyIZgEX+/FihPFGAhzN+F2OlIkuftY0HqEzC77jOH?= =?us-ascii?Q?eJF7Px7348hgsZ1+xOZsf2FgikTMQRE33mcccXJ46UROQXNIxX1d0+Be1huJ?= =?us-ascii?Q?rMPRzNbsNTITzlxaP7pJAev01SDm3sppKVVcja71RGPVKaKKmigBGH+t1Lzz?= =?us-ascii?Q?HGszCaVAbVeiwcATu7xxU7FlKW5JRpuQjE4lLxMw1VOPAhQrxEtOSJf3K5+q?= =?us-ascii?Q?1q0cvSl7wXGqyUeS+Wd9bX2rMPK1oD2Zi6JqXgPVfjB9EbHctjcvxvzTDGMp?= =?us-ascii?Q?2ldHRD1j+tZcSWhPLFtzQ2/KhQ5o3Puk1NOL8SEGTv/dabsJxMeqx+q28nmJ?= =?us-ascii?Q?BVAZhnbWM5DpfE4pkg3+JhbPyooaqOBCSIM7vMsNxMB4wmIkSREyVKM7pmbB?= =?us-ascii?Q?olW9lt6NJTssxpvoGhh2Gvwz9mREHC4zKejT2Wt31H6nKQFeyoOZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba1247ed-e45a-490a-14f9-08da34390675 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2022 17:01:15.2150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9n64nQwNenOCTaRC/6gHxNbz8B7Sfgy+qRfq6B5lGH10MIBfblOa3mm/E4Yk0ENSRsKwe83+XylAhpidKLUVUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9387 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, May 11, 2022 10:51 AM > To: Jeff Daly ; Zhang, Qi Z > Cc: Yang, Qiming ; Wu, Wenjun1 > ; Zhao1, Wei ; Xiao Zhang > ; Xiaolong Ye ; Lunyuan Cui > ; dev@dpdk.org; stable@dpdk.org > Subject: Re: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to > appropriate devices >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > 11/05/2022 13:43, Zhang, Qi Z: > > From: Jeff Daly > > > > > > 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to > > > the SFP cage on these cards) is not asserted to avoid incorrectly > > > reporting link up when the SFP's laser is turned off. > > > > > > ff8162cb957 limited this workaround to fiber ports > > > > > > This patch: > > > * Adds devarg 'fiber_sdp3_no_tx_disable' not all fiber ixgbe devs use > > > SDP3 as TX_DISABLE > > > > > > Fixes: 1ca05831b9b ("net/ixgbe: fix link status") > > > Fixes: ff8162cb957 ("net/ixgbe: fix link status") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Jeff Daly > > > > Acked-by: Qi Zhang > > > > Applied to dpdk-next-net-intel. >=20 > There is a lack of context in this description. > I don't know what SDP3 and TX_DISABLE refers to. > Please make more complete sentences, thanks. >=20 I don't want to sound obtuse here, but this is a fix to a specific Intel NI= C driver. Any symbols or abbreviations or definitions used in a device dri= ver are almost always in the manual. While SDP3 means something specific t= o the Intel 82599 and X550 (and probably others), it probably doesn't appea= r in a driver from Marvell for example. So, in this case [S]oftware [D]efi= ned [P]ins [3] (out of 0-3) is specifically talking about the Intel X550. = I'm familiar enough with the hardware to recognize that, but if I was to lo= ok at a Marvell driver and saw something I didn't recognize like that, I'd = be checking the Marvell manual. =20 What I'm describing here is the fact that the TX_DISABLE signal (a signal d= efined in the SFP spec) from the NIC as implemented by the Software Defined= Pin (3) by many (most?) implementations that are using this Intel driver, = is not specifically the *only* use of SDP3. A later patch limited the chec= k (correctly) to fiber implementations (which is the only thing that makes = sense), and *this* patch adds a module switch for platforms to disable this= check in the event that they (as they are perfectly allowed to) don't use = SDP3 as TX_DISABLE.