From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ECDBA050C; Wed, 13 Apr 2022 17:23:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E71DE4068E; Wed, 13 Apr 2022 17:23:41 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150112.outbound.protection.outlook.com [40.107.15.112]) by mails.dpdk.org (Postfix) with ESMTP id 5D0464068B; Wed, 13 Apr 2022 17:23:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVNNd8q82e7QLgjU/eInijAVcxqlyWbdvTKMGhvCm+8AOjTybnwHNdUpN7ybhOjbLPoFyQEpujyJOSKNINyxStSFzwERu6UdYotp4TTLsjEZXA6pv1y737ev8OuJr3XsP04BbUKbkQ0x98KS/vSIH0fACOSkxHeihGMfXBQbUKmYEgib9ViCW25OckJEzMvXzJearmbS4SDSbUa6c+f1iLnKu/UPse1QLLZnNYasL9cgZQF86MciMyqztoKXd+A36fhnkKIipzu9dOcMFUkN/t9GASJDWXZCg4rqrxHHctKHtZDSnKXCdSabuVq2FMppncxZ20rgm5dokooejQrBEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DrKK/LDVeWX+4TW5Xx24W4wWo1EGmAOHT7x38877Y/o=; b=Fv9NA1BY8RdcPJV9FLYBht7cXZBpklH87rZyRNDVcfmbmfzN03bT5Z75q1y+pwvPc329RpcDoN9SnBQ0FEs9K2BICllu3q8J1ZtP1j1PfvwZHkBOJKuzCRwgbq4JVq43SNl9C72qjEICx1kNgN8qV8opA/xKh4TJW7qlnQDmwGVeADRyrxC5FH6Pl2M7hfY25h9Dx8OjQBzXIdz5wYIif95HexYZfJIbbxNXArkJTSNy6ATOBSAEPoprolSDFC+/NhL4JARWe4ja9jNeDQTL9ra6z/xY9m5VvTkKq5+iypi8Z4OxntSqieX4LEandZHFPUQd79rIKT7B4D55s1KzRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DrKK/LDVeWX+4TW5Xx24W4wWo1EGmAOHT7x38877Y/o=; b=pG1b4M6VvYIrclFvMWDOxRXQDod/WoxTinnCxiYVY0VJdgJnJXvkfOkF/h5Odd9AgiWG+IDVNW9wpGi07bEbk+aFcCvfAFhmfc+TPKje10TAmeRcfQuhTs3EQaHk2A2dWREsUObbNxLooV6hcjOXU2Q007Avpqz3/YsyYLsQVTc= Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com (2603:10a6:803:b::16) by PAXPR04MB9253.eurprd04.prod.outlook.com (2603:10a6:102:2bd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 15:23:38 +0000 Received: from VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::5dd5:47e1:1cef:cc4e]) by VI1PR0402MB3517.eurprd04.prod.outlook.com ([fe80::5dd5:47e1:1cef:cc4e%6]) with mapi id 15.20.5144.029; Wed, 13 Apr 2022 15:23:38 +0000 From: Jeff Daly To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "Wang, Haiyue" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Topic: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Index: AQHYTpSxgnie9TYA7EmxFtoINkPBYqztJEkAgABGHACAAAEVAIAABQaAgAB6QHA= Date: Wed, 13 Apr 2022 15:23:38 +0000 Message-ID: References: <20220228152937.21247-1-jeffd@silicom-usa.com> <20220412174220.31195-1-jeffd@silicom-usa.com> <20220412174220.31195-3-jeffd@silicom-usa.com> <98CBD80474FA8B44BF855DF32C47DC35D86FD6@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D86FD8@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86FD8@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 90bf5545-1b6d-4201-7026-08da1d619589 x-ms-traffictypediagnostic: PAXPR04MB9253:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /8obRpZ9NkXDf9gs/dTXyCKostdpwbRcLxDDVhLm9xFIXT9iIAcK1w0MqOkXNy88emW25IumUAkVXelaXACRTRoXgU7Kxmjl3n8H1+tSG8Md11EkTx+j5nvn/IO7EHpcgeW3AbHTa73mnvnZT4OPxXGwhuifkGJ0RkIxW972dEmgnbI/3yksK/325fH24QnGNjlstibyMX7WL5NhUWA5BK8Bt7ogGfYXt8vqgVPDipvUD1aYt1irGWWzjXDoj32JPgIGg5plfOPzAELqm4BCDALhwVgUJxySOJAuPcQvNvtc9le2YosBodj+YHAcNRKq/o6I1aSXOLRkwI7h//67AZJHlHMTcevLkkSUlsCpKW5Wzk+vcxlxEGSfOzLpNVo3+eYHc9ErGU6MAZClGbdYFIXGeze8kPYgZcn/IGVccyxf1otwSeZIDwfmsMF/poVTHd/PcP6+Vfy//Coc42r1sMzHL5EnMfsaDsPluKCnsqladrFy5vXX5JOEU3gfETpePPjLEOpxBKCsE/kiOqgoMFnRfce/Ltt2Svn/Ns48HsOcdkbg0ET952ot2Ej1zPQuh3iJ8SsXxUQq8SMLvZtAi3WQor6V0b+AI546jpTw1V2sExbDdq6TNLwgrZgBepCSePydFlkdTnbWUNzKHgwO7MS//2wyB4AvM1NP1Rpsg6gFXzpYB6GvinODy4A471xA7a+NCTAyOFd4edYB6EYwvw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3517.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(110136005)(26005)(8676002)(508600001)(66946007)(38100700002)(33656002)(66476007)(4326008)(76116006)(64756008)(5660300002)(122000001)(8936002)(52536014)(186003)(86362001)(54906003)(66446008)(66574015)(38070700005)(66556008)(55016003)(9686003)(71200400001)(316002)(2906002)(6506007)(83380400001)(53546011)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?eNU+dv1zkab5v8dBeBuLzclyxFBazCZ2ULE+bVkIfAJkaI8J3mXsfoNZpC?= =?iso-8859-1?Q?afyuwxgcYmnmNL5SBGoCkkweDD3KVP0iP7UCw3LRnAZQloy9MHC4a0mHhU?= =?iso-8859-1?Q?XbV187yHuzOQ5hmdrysn0kbeLJwpdKbUO36lxGMwBSejRZ9fIJr/kdNb5g?= =?iso-8859-1?Q?U+QD7VWPOmB417cH2yNjAPpEeuB6apVurMG6fGeufGKMS2u6d9VFEiXep8?= =?iso-8859-1?Q?GxrILwMpP9QUuAmmgjHzqFhjHFSWwoECLdCGizVg56TnSy0WCt/f0xUlk+?= =?iso-8859-1?Q?OknpQ1jLh0brI20WYB3sg3W6cjaPY/GDF8H7YNZqn8WoGT0rsHgfghVXws?= =?iso-8859-1?Q?vbqZjWZOY4Sxy643QSZy9jJGoMz43e0ZSvxLmLtZD3N9nUVpYGeCwCtHNc?= =?iso-8859-1?Q?qJr+U9enVmYHARkSoBu/zDKVh/4RfIrQGH3e9b+7oFjfFPy6n7VrcK9PDv?= =?iso-8859-1?Q?/0HfhCzf8DPLW5KgznfdDSsNsphIhJkzc7X00SOgnJGLfBJJUUpVRGriR9?= =?iso-8859-1?Q?v3nQx7sAcGft4nU/srLj612dyams3vseglw77AAOQDzEWNCVvhWNL5bFjT?= =?iso-8859-1?Q?LZUryQY25xYuXX7mWOM0rw0rPx0ekbUwnbh/ZCc8Nl89zbgKZY0+tTfpUh?= =?iso-8859-1?Q?+hLkTdVzx2YO8ULQroxU7xBmTesmpW6W0yWLve0cDy0rGhd+6ApNIO7wkX?= =?iso-8859-1?Q?i9VFil1a9nhzD3/o9LTcCf1qdUaM8Ko4U3A6hDsH9Y1PPGAHsDjkGyjE0K?= =?iso-8859-1?Q?V/y4nyVlM7oCYzLTDsDYUZw1SSMohX9/0hWIpQkpYO7NeQWI5Ih0fiuC2P?= =?iso-8859-1?Q?29iCSeq9wZiPGgIQweFNSbP5vVhGjdvVeQB/vSGfM++tP4DzxcK9MxHxuA?= =?iso-8859-1?Q?y2da0VSkqvk5aHX+/PgOGM+0VIfo9bTw4LrPKOMg9FSINEbH9h7Iiw6MZ3?= =?iso-8859-1?Q?uZeV2EsJWDUHDwFnWMzASU86zngBpa+KkMEL2V+2em+rQ+gew6tDD+yPyi?= =?iso-8859-1?Q?KCfJNvM1eio+Eob9tfdQUyAYAJFNbViu+il0y+YBn0bOJGc6cptTGZ4i0J?= =?iso-8859-1?Q?7bTmDnxC0ywKIhkwcEygaXjK1Ga7e67JvpLq0kMS8kHkjXIxsyPyTZeNJk?= =?iso-8859-1?Q?kqiNF5UNDwNaM8YxU89UoWTAehiMDGwUYMc2XCW0mrK5KkNA1YVsQ7asYJ?= =?iso-8859-1?Q?vvo6oJgmP0tv13Bpou0bMkvWZqwjtdAymOltjXDSazENFmuGBiF9qoaZ0b?= =?iso-8859-1?Q?sPbSZit4WOPYomm/rsMUATydb7J+eqP7cbtMCNw3fdMxBYKBqTNx6otRvV?= =?iso-8859-1?Q?GQZvchK6zD90VVY/y6g8INbn8RLXBfT3RJlxwITWK1AOBr1wLSkIEeascA?= =?iso-8859-1?Q?iFk2ISXM66o64hxAMkqmPC30lqDoL/xxOal7pyLHKqqNWYAzADCxpYd/AQ?= =?iso-8859-1?Q?VnnVwRjRPf4VFtDhZipi7gW9+LH3Eh1HVGOR4qjtFED77nbQ453bslEcTr?= =?iso-8859-1?Q?kv9VGA8nFFuw8AIAKxH8PiOplvoXTHFTxtAKlAW9bVVFSia/sy2iOy1xI9?= =?iso-8859-1?Q?VVuuClCBqH2W77aMXq61HGDCn+jDlg31aFtXXGdKHUCci8NeS6RC0McScM?= =?iso-8859-1?Q?tHoxoiKCaCSOi66fwq+7ZoxlGvnpYEDiEVSg8CpPcDmnAcLj8p3s7BfCh7?= =?iso-8859-1?Q?hoqhymarTL0Qg+nabSJk9P2IlY/KMddp8/BCK1tqBPkGkk8VujBHIHyLyK?= =?iso-8859-1?Q?8m80WoZjwY3twO1NxTB+KcntN44CbY385fCUnkImi3/k4RVpet1vLVqWKs?= =?iso-8859-1?Q?0i79ziJ9dA=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3517.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90bf5545-1b6d-4201-7026-08da1d619589 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 15:23:38.2942 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T7lrNrCKvQAC3i11HDWemc5haaWcjw9JG3USqZGFXJmXUrPMFhLIgfKlVWl/U0Xn4DG7GXB/8BdWI3b11I8N4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9253 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Morten Br=F8rup > Sent: Wednesday, April 13, 2022 3:20 AM > To: Wang, Haiyue ; Jeff Daly usa.com>; dev@dpdk.org > Cc: stable@dpdk.org; Stephen Douthit ; Yang, > Qiming > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug >=20 > Caution: This is an external email. Please take care when clicking links = or > opening attachments. >=20 >=20 > > From: Wang, Haiyue [mailto:haiyue.wang@intel.com] > > Sent: Wednesday, 13 April 2022 09.02 > > > > > From: Morten Br=F8rup > > > Sent: Wednesday, April 13, 2022 14:58 > > > > > > > From: Wang, Haiyue [mailto:haiyue.wang@intel.com] > > > > Sent: Wednesday, 13 April 2022 04.47 > > > > To: Daly, Jeff; dev@dpdk.org > > > > Cc: stable@dpdk.org; Stephen Douthit; Yang, Qiming > > > > > > > > > From: Jeff Daly > > > > > Sent: Wednesday, April 13, 2022 01:42 > > > > > To: dev@dpdk.org > > > > > Cc: stable@dpdk.org; Stephen Douthit ; > > > > Wang, Haiyue > > > > > > > > > > Currently the ixgbe driver does not ID any SFP except for the > > first > > > > one > > > > > plugged in. This can lead to no-link, or incorrect speed > > conditions. > > > > > > > > > > For example: > > > > > > > > > > * If link is initially established with a 1G SFP, and later a > > 1G/10G > > > > > multispeed part is later installed, then the MAC link setup > > functions > > > > are > > > > > never called to change from 1000BASE-X to 10GBASE-R mode, and the > > > > link > > > > > stays running at the slower rate. > > > > > > > > > > * If link is initially established with a 1G SFP, and later a 10G > > > > only > > > > > module is later installed, no link is established, since we are > > still > > > > > trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner. > > > > > > > > > > Refactor the SFP ID/setup, and link setup code, to more closely > > match > > > > the > > > > > flow of the mainline kernel driver which does not have these > > issues. > > > > In > > > > > that driver a service task runs periodically to handle these > > > > operations > > > > > based on bit flags that have been set (usually via interrupt or > > > > userspace > > > > > request), and then get cleared once the requested subtask has > > been > > > > > completed. > > > > > > > > > > Fixes: af75078fece ("first public release") > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > > So BIG change for new platform, DON'T CC to stable! > > > > > > What do you mean by "new platform"? The ixgbe hardware and driver is > > not new. > > > > > > > It's soc NIC, ixgbe not support before. >=20 > If the patch only fixes the driver for a new NIC that not supported by ol= der > DPDK versions, and that NIC is not going to be supported by older DPDK > versions, then I agree that there is no point in backporting it or CC'ing= stable. >=20 > However, if the patch could also apply to any other ixgbe NIC that is > potentially supported by older DPDK versions, then it should be backporte= d. >=20 This patch is not *only* for soc NIC, it's for *all* IXGBE supported NIC th= at have SFP cages.=20 The code was also validated using a dual port 82599ES 10G SFI/SFP+ PCIe NIC= adapter. > > > > > This patch fixes a bug (with a serious impact when occurring), so it > > should be backported. The size of > > > the patch does not disqualify it for backporting. > > > > > > -Morten > >