DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"Coyle, David" <david.coyle@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	"Trahe, Fiona" <fiona.trahe@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Ryan, Brendan" <brendan.ryan@intel.com>,
	"O'loingsigh, Mairtin" <mairtin.oloingsigh@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests
Date: Sat, 18 Jul 2020 20:07:52 +0000	[thread overview]
Message-ID: <VI1PR04MB316808005C3912DA06764563E67D0@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <SN6PR11MB3101E17CBA5F9DDC0160F221847C0@SN6PR11MB3101.namprd11.prod.outlook.com>

Hi Pablo,
> >
> > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the
> ff_disable
> > device configuration option for all cryptodev tests, including security related
> > tests. This patch updates the cryptodev unit tests to not disable
> > RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.
> >
> > Fixes: ea31f2b4f547 ("test/crypto: add DOCSIS security cases")
> >
> > Signed-off-by: David Coyle <david.coyle@intel.com>
> Actually, since PDCP security tests were added in previous releases, this could be
> backported, right? Commit d883e6e71 ("test/crypto: add PDCP C-Plane encap
> cases") added PDCP test cases and the ff_disable option was already present.
> Akhil, do you think we need to backport this?
Good catch, but currently PDCP is only supported by NXP platforms and we do not
do anything in dev_configure(), so the change will not make any difference.
I believe many PMDs are also not doing anything in the dev_configure().
So I believe there is no need to backport this patch. NXP will fix this in the PMDs
when it is required.


  reply	other threads:[~2020-07-18 20:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 15:29 [dpdk-dev] [PATCH v1 0/2] " David Coyle
2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 1/2] test/crypto: " David Coyle
2020-07-16 17:05   ` Akhil Goyal
2020-07-18 21:18     ` Akhil Goyal
2020-07-17 18:17   ` De Lara Guarch, Pablo
2020-07-18 20:07     ` Akhil Goyal [this message]
2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: " David Coyle
2020-07-16 17:01   ` Akhil Goyal
2020-07-17 18:19   ` De Lara Guarch, Pablo
2020-07-18 20:08     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB316808005C3912DA06764563E67D0@VI1PR04MB3168.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=brendan.ryan@intel.com \
    --cc=david.coyle@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=mairtin.oloingsigh@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).