Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests

[Akhil Goyal <akhil.goyal@nxp.com>]

Hi Pablo,
> >
> > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the
> ff_disable
> > device configuration option for all cryptodev tests, including security related
> > tests. This patch updates the cryptodev unit tests to not disable
> > RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.
> >
> > Fixes: ea31f2b4f547 ("test/crypto: add DOCSIS security cases")
> >
> > Signed-off-by: David Coyle <david.coyle@intel.com>
> 
> Actually, since PDCP security tests were added in previous releases, this could be
> backported, right? Commit d883e6e71 ("test/crypto: add PDCP C-Plane encap
> cases") added PDCP test cases and the ff_disable option was already present.
> Akhil, do you think we need to backport this?
> 
Good catch, but currently PDCP is only supported by NXP platforms and we do not
do anything in dev_configure(), so the change will not make any difference.
I believe many PMDs are also not doing anything in the dev_configure().
So I believe there is no need to backport this patch. NXP will fix this in the PMDs
when it is required.

Regards,
Akhil