DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Tejasree Kondoj <ktejasree@marvell.com>,
	Radu Nicolau <radu.nicolau@intel.com>
Cc: Narayana Prasad Raju Athreya <pathreya@marvell.com>,
	Anoob Joseph <anoobj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] security: allow application to specify UDP ports to PMD
Date: Mon, 21 Sep 2020 09:30:33 +0000
Message-ID: <VI1PR04MB31680ED1950232D2B8D8BF19E63A0@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <MWHPR18MB11044EB8ECBC349BB21EF086A83A0@MWHPR18MB1104.namprd18.prod.outlook.com>

Hi Tejasree,

> > > Add UDP source and destination ports in ipsec_xform to allow
> > > application to specify ports to be used for IPsec UDP encapsulation as
> > > they are dynamically changed by NAT in between. Also adding an extra
> > > flag to indicate whether PMD needs to perform encapsulation header
> > > verification in case of inbound. In case of inline IPsec
> > > implementation, verification of outer IP headers and UDP encapsulation
> > > headers need to be handled in the PMD. For lookaside IPsec,
> > > application can optionally offload this to the PMD.
> > >
> > > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> > > ---
> >
> > I think we should add some usage of these newly added params
> > - either in app/test or in examples/ipsec-secgw
> 
> [Tejasree] You mean adding test case in either of the above apps or addition of
> PMD implementation also? Also is the proposal sounds fine?
> 
I would say both, so that the newly added parameters are tested.
I am ok with the proposal with a minor comment,

We can have udp_src_port and udp_dst_port directly into rte_security_ipsec_xform
Instead of adding a new struct rte_security_ipsec_udp_encapsulation.

Regards,
Akhil

  reply	other threads:[~2020-09-21  9:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03  6:42 Tejasree Kondoj
2020-09-10 19:09 ` Akhil Goyal
2020-09-21  9:13   ` Tejasree Kondoj
2020-09-21  9:30     ` Akhil Goyal [this message]
2020-09-21 12:03       ` Tejasree Kondoj
2021-01-11 19:20         ` Akhil Goyal
2021-01-12  6:51           ` Tejasree Kondoj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB31680ED1950232D2B8D8BF19E63A0@VI1PR04MB3168.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ktejasree@marvell.com \
    --cc=pathreya@marvell.com \
    --cc=radu.nicolau@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git