From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FB1AA0524; Sun, 26 Jul 2020 21:19:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 839792C01; Sun, 26 Jul 2020 21:19:17 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71]) by dpdk.org (Postfix) with ESMTP id BB6E32B86; Sun, 26 Jul 2020 21:19:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7tHoKINOXCxce7e43nSkLvWcUdJWPU93+5nKycoSGjjuPOJLDQNXc2H4QxuIWcXY4IYAs9pzhIzWy0Nyer64geA2fifC7cBNGkMvyNbevapDYuBrBj2Hj0aLo5B917dBMFUB8vR90vGtUArAcpWtj3xifQeXI17Qa0QIIQghvUbGxvHV/x7t0Czuio/HAHH+ZoH15d8moP75v0TkEZYiYxnI3cfJatllHXEWJtG7ndShy3s7asNUgsAH6bB436G3/cbqWoj0z+y7frloBEOX1VqBi17FIIbXi4mSZ42IujivoTWgFePdxWVLALXXv6BmzOp2NZ8nyNd5RfN/A00DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mc+EUAEn7Krix2aSlOsD3Mh7eUFqb6xT+cy+pl94W0k=; b=N0dK/WwAZ95TAhiI9pT4V/xT+speYdBsFtCc4JPJrJyXQyaJQkwRY8Uevy+ck1F3m4ay5BiBbQ0X6a/niWVsUXl3Ds75ymqPu+u4WIHRfn/jasoh1C1bsHphGpnrIQJoDuQrclyvRdOO52YceDfWiJTPYZLeaD3QTyP72lAvPEoknsOaZMLv29/yG6B1a1D3c2Jegq1eoxxBYquXXBAftNQ1IIeiKTIA9carzGvYFqx2nJ4c1gRmTHrQT5xjNZVDgzVz9oRQqvtKduSx9qZrqsBwxErF2pKI48OJKVgv92k6/NaNLso5QJ3MrM4sBviLwhTFEjxbRMvhAG9xGiwfCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mc+EUAEn7Krix2aSlOsD3Mh7eUFqb6xT+cy+pl94W0k=; b=AmcQbdsC/ndRxJCs8Bj06eKk+ZUBZMUrQAt7tpApffcJvP2jc9slkmKvcogrhIb/Bp+8fjR2MuAzhzYMLWOZuibdM0fwqCLeEB6ccpx5DTEV4OxudrriJg8GopHQ+usYAz2+Rg0HGp7sINcHd1ZFPZHDv8KOz2+3TaqXzfM95Dk= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB6975.eurprd04.prod.outlook.com (2603:10a6:803:138::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Sun, 26 Jul 2020 19:19:15 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::611f:12a5:1d6f:fd05]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::611f:12a5:1d6f:fd05%3]) with mapi id 15.20.3216.033; Sun, 26 Jul 2020 19:19:15 +0000 From: Akhil Goyal To: "Trahe, Fiona" , "Dybkowski, AdamX" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] common/qat: fix uninitialized variable bug Thread-Index: AQHWYZ59NpZR2+T3L0KyWq7AAK1Lw6kWnySAgAABEICAAAYrAIADmXIQ Date: Sun, 26 Jul 2020 19:19:14 +0000 Message-ID: References: <20200724094010.1025-1-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.166.88] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 319e2390-dfca-479d-8f31-08d83198c907 x-ms-traffictypediagnostic: VI1PR04MB6975: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mEf+8ZFaADrmXV0Kre5afvqtG961OYuf41i76+GjZrBBcqe+P8wlZ6yXms3xL+2rrKZaORhFc80AMkaqi79UvbZnqQgTCEteYYmZJ5tCIhqkDFK44IeiI3MSh4P4zNqN5ujYZ2guEYWg+JPh/sw7TFE+V84vDMIve3q2rC8A0uo2H7970gCSYufM7Bso0CuMLYJ3X6cMAlGYYL7IcQ7Kj4b2OIgJeL9sej1EwbaekyoQJt4Yd2X/+dUFhT57tWsPwwyqoikdw7swEhFgFFHpsYWUpWGXChbaw8uz9skFVxQmjm2Jnlp+YitCz77eYCWk x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(346002)(396003)(136003)(39850400004)(52536014)(9686003)(55016002)(2906002)(4744005)(86362001)(4326008)(5660300002)(186003)(8676002)(26005)(316002)(110136005)(8936002)(6506007)(478600001)(64756008)(66446008)(76116006)(66476007)(66946007)(66556008)(33656002)(71200400001)(7696005)(44832011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: F2mDw6iuFEkI215ImKCIR2Z9RSf/wDDNXJnZptjSttdWG4Te6G9lSP4apiUabnvnUvUuZf8L3vBVJIYihoua56f01hsMtXohjBaROp7uyBVft4u1jBgKQQtd426FT8YBQVs9HWVb/NFyO5SVTU8SDhCQ1j6AInchrwTzvi8KNf79JGmZDmIEogNr/hMy/ILOoee51LiK/8jj+0vHLLf9llWh1nHsGOQvvDPIziGbE/PX/dSZ+9SwGV1Xtq/AB0bc6tpVVFzrWO8vB8XL1vDJxtWVvtAezeqsyXf9INTLQI90hu5KKXjDubeNkd3W5VCnBDdFtLsuJZdho/W1Vl7AzyiOoUDtNTwmbHlxP4wQ9Vd06XitIaeZwXbbnFNKSTnloLY1EfpMRQJH6oJbwlk5qKD7FeiGEwxSQryaeKu4J+wpXHTaZlN1+ZE8WKausBcs0biDG0yUyVF0tkeURZOj1BuBDh9WnKmn8ntpX6q7Jf8= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 319e2390-dfca-479d-8f31-08d83198c907 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2020 19:19:14.8742 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: blGL1KinS8P8l6w4DBkPi0J4GBYWAHs9L4SM5bBDyPI668XHu3uwa+n6tAWc3njaoCzL0vR344NshF4l39/+xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6975 Subject: Re: [dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > [Adam] The ret variable value (signed) is not returned directly, please= check the > rest of this function in src > > code. This is just checked to calculate how many ops were enqueued. And= if all > checks skip (meaning the > > op was not processed by sym crypto, asym crypto nor compression), we > should note the user that the > > actual op was NOT enqueued. That's why ret is set to -1. > [Fiona] ok. makes sense thanks. In that case > Acked-by: Fiona Trahe Cc: stable@dpdk.org Applied to dpdk-next-crypto Thanks