From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73BE2A0521; Tue, 3 Nov 2020 07:28:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A000BE53; Tue, 3 Nov 2020 07:28:17 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2055.outbound.protection.outlook.com [40.107.21.55]) by dpdk.org (Postfix) with ESMTP id 3857BBE4F for ; Tue, 3 Nov 2020 07:28:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BSeDqftSgobko48ibSuJMSrQbdop37Q2Rz9F7/z6Ads/+XZd8KbvW3GCVwDBxKYJJNS6LhDz2kInx/+pgO+WMPZWxeShBZvjc4B/TWBtK0mJTVhgn1S/H6T24314vwJ3LZFRMqOMHRo140Dr5PjfN9ecWMliCFdN9ZFjb83uJpL8/WCp2ZbqTkBBJUj6Qu82NVBqnrOEdYrZKCNeh3N/qLaf5kbysWS9HfSuCs8xLKGhrEHiwyHraPRuxptd3eL5Wwg8pB1APXYsbhIwoFF5KUYR82LAr/Sxm66N050bnN5W90yQk0XGNfDDwzwoxINlmIR/ArUbj9jKYxxap+PC3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ywUJovFJkq7wCIUSVexpaM1uRtcfYPuLVuBLD3VNrqc=; b=TYqeBioJYv3BCkUQ9s4EpdHlmNUMx+lmLUhTHrZrwbr+VEvruQ0KKgTvjbZi9KqysibkeBitrd9g50Kjke5zct1Qfq1W5G3ktReFOcnbRHwuCx7DnEb9tx7CRwKG4n/+Jq3iExL6FCXWdLKKBCfrS9wl8+91eS7JbDrVkxKqtbmhY4BJhEg+lq8rdZqb018wvvDS0XhzryalUPU7mYLpBEVX98LRtbwgOxpopiXxPQw0W0xE8bQQeWixJEA3svc+r2cVi+i8c4elsfKMLHdL3C+MbkhZnEjgLUWLDqntCufzhlb08aoKDwg4QL3jyKaRP1Rp1FpoNfMfzcocLSmQIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ywUJovFJkq7wCIUSVexpaM1uRtcfYPuLVuBLD3VNrqc=; b=HbZviIAnWyMbv4NmqdOoMFSJhT9xiBdpGDlSzJqlv7iHGv67ib81yX/JZmcS7/Wl7UAr8Hss/fUuIx0kzCtZ97beBTgBW/pIPtFrSHfdqCvEWwE9p4+4oH61wmhdsETa2rwS+lEaCYa98s+nHdgPHgOKXHb4s7m8vFsgVDV80Z0= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR0402MB3918.eurprd04.prod.outlook.com (2603:10a6:803:21::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 06:28:13 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 06:28:13 +0000 From: Akhil Goyal To: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "Ananyev, Konstantin" , Hemant Agrawal CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v6 1/2] cryptodev: support enqueue & dequeue callback functions Thread-Index: AQHWrpUd/M0tQ0WGjES5pYkR0+gFBqmwdpQAgAADXgCABCBsgIAAm5/wgAC3aICAAAeRwA== Date: Tue, 3 Nov 2020 06:28:12 +0000 Message-ID: References: <1603926611-19086-1-git-send-email-abhinandan.gujjar@intel.com> <1603926611-19086-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [171.50.183.179] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d46b6e97-e34b-4f13-ec50-08d87fc1a43e x-ms-traffictypediagnostic: VI1PR0402MB3918: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Kf04FHGvCZEoP79QCNsq4iD8oyx3qIOJ4JvzJluEj1C7NxTWhyLF7OENdUrhDhWBUjLRNbdBl8jzYJ6HLFCMyYy1XKry5WUFStZzA8MtiTWcP0iuLDeY/v/YDTQxMyoagboJ/BEkDEl2ZNQClRsI08tNOvf7ySSOs9FLkoguKujgLLbOI52EnaQCLHmQlRGPmQsV4IiXOsNJtwq9+9zGQJXPtkfUJuaH4niZQIVxEpxqQpoUhyLMJQ25MsDMqg4EVZvzYBINhsipZ5w50nM4YfVuvRFfBHS97IbawmJ/YOj3giIrGBg/P0mSmm7txpG1onlt0Y/quYgn+TJkx9+94Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(366004)(346002)(396003)(66476007)(26005)(8936002)(66556008)(66946007)(55016002)(64756008)(5660300002)(76116006)(66446008)(9686003)(8676002)(4326008)(6506007)(71200400001)(6636002)(52536014)(186003)(7696005)(83380400001)(2906002)(33656002)(44832011)(316002)(110136005)(86362001)(478600001)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: cSawPtC6Xt77wmAvAVYz9EatddE19Zwc8xyRpOl0ywPo6W0avZBKtP1aLiHBA9dRZ2WkSrZ7nJtFrvsNW8hle9mK1Ppx6QNdD5ni/CzM8/A9qGkUbpwaToUrt1WgPm6+Y3AE+ZbagLy6w03OQktalgd9B3KWksSfh7KdVlp46CqdQEGHKDK4vEJXUs+pJvDLdV+qDpllkS//l9ikfd5wh25OjPI7d8+Z+8AfiDQvjtmo4DncQKsse5GkbpcXf70epb4x7uOpNvm6YEbDUejz1xznK46D5/tv/4buw7AiptP2Gbck+9BNwHt+GDvVSTkOvKSR05UCTPoCwO+GQPaavq0/8ssJiXcUmk1GizjXDnqhnruZPulSrNT4sJEH+sOnjbbbEKQ3z4xn/tP8fAArGO/tszwTV4MWxyZslulNCCWMTgS/90lo51Th4rke8uWUhaiq0AxZIIzNGY/z+Cs8PK347mkRD2q59hkOglJ9k4vXuLsMEE8pz1nKk3btBb7cJOVn60yzvc7W71GvzDyX2+XCqV5YZqYY3/upRA4N9wga6qJStjUGR0R8bzNaL9vA+Cl5K6da6i8Ogda5/IDqHj2zO8gt2bYQGt5rMB+pvmcrzGuhAIZdrDGFzmmi79MrwaVfp/gLH5qNtOf5kHUErA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d46b6e97-e34b-4f13-ec50-08d87fc1a43e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 06:28:13.0480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LfZ3aeR6A8pNa2M5uE9WtSzHgA+1wI7cE4xomN4tic2UCR/AGViFid9MCUnYfbNQMQNAQxwH60nJnYS5U6qeoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3918 Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, > Subject: RE: [v6 1/2] cryptodev: support enqueue & dequeue callback funct= ions >=20 > Hi Akhil, >=20 > Can you please go through the patch again and check if any more comments? As I suggested 2 times that there are documentation issues. Haven't seen a = version To fix that. Please check it at your end and try fixing the timing of your = system so that CI Can pick it for compilation. > I understand that we work in same time zone, getting feedback from you in= the > mid night will not help me/you to pull this patch in. > A quick response will enable me to prepare patch set quickly and send it = across. I am not dedicatedly working on your patchset. I will work as per my priori= ties. Had it been a CI pass for compilation for both documentation and code, it would have been applied last night. I could remove those extra spaces, but there are other issues also as the newly added APIs are not visible in = html files generated. Please ensure that there are no issues in doxygen build is= sues and should be able to see the newly added APIs in html guides. And please note, do not top post your comments. It becomes difficult to rea= d it in Archives. >=20 > This time, I will prepare the patch along with dequeue test case. > Hope you understand the concern. Thanks.. >=20 > > > > Hi Abhinandan, > > > > > Hi Akhil, > > > > > > What is the status of this patch? Is it pulled into RC2? > > > > > > > > As I suggested below, please fix your date and let the CI pick your pat= ches for > > build. > > In my local build for documentation, the newly added APIs are not added= in the > > Documentation. Please fix doxygen issues as soon as possible. > > Did you try building documentation at your end? > > > > Regards, > > Akhil > > > > > > > > > > Regarding the date, I am not sure how it can be fixed now. > > > > May be the space is missed out as well. Could be please help? > > > > > > > > > > > > > > > +struct rte_cryptodev_cb { > > > > > > + struct rte_cryptodev_cb *next; > > > > > > + /** < Pointer to next callback */ > > > > > > + rte_cryptodev_callback_fn fn; > > > > > > + /** < Pointer to callback function */ > > > > > > + void *arg; > > > > > > + /** < Pointer to argument */ > > > > > > +}; > > > > > > + > > > > > > +/** > > > > > > + * @internal > > > > > > + * Structure used to hold information about the RCU for a queu= e pair. > > > > > > + */ > > > > > > +struct rte_cryptodev_cb_rcu { > > > > > > + struct rte_cryptodev_cb *next; > > > > > > + /** < Pointer to next callback */ > > > > > > + struct rte_rcu_qsbr *qsbr; > > > > > > + /** < RCU QSBR variable per queue pair */ }; #endif > > > > > There is an extra space in each of the comments above between * a= nd <. > > > > > Check other doxygen errors if any. > > > > > > > > > > I believe the timestamp in your system is not correct, as the > > > > > patchwork show Date of 2 days back while the patches are sent tod= ay. > > > > > Could you please check? I believe CI server is not picking your > > > > > patches for auto build. > > > > > Please correct it so that auto build can happen. None of your > > > > > version was picked by CI.