From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 968CBA04B6; Mon, 12 Oct 2020 13:46:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A5011D6D6; Mon, 12 Oct 2020 13:46:11 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2073.outbound.protection.outlook.com [40.107.22.73]) by dpdk.org (Postfix) with ESMTP id 03D571D6D2 for ; Mon, 12 Oct 2020 13:46:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kqnKqIn8BjcKFwBzhoJfZ0fj1/6KH4O67G+oPF6gIXfkKk2+qCrUFWp2QVzAyFttVww0EGFhdTKCB8PtDSHFC8jwGevH85HX+6mSS/Q+Uqhyys1RHgiNLzOXiXouK7CsZtYid5DwtE3QT/dCrHSBNgiktuczSn4vL+aG7nQsWam9s7stnPorxoyLrVJANJtTLnPIfksJt4OtqE/1tF0fL6ZnFyGaHJIe8qGoc0UdrQpiMLxs/xZvyCyAEPqlTASh1jEDbTb0+GiTxbTHLcnjSK39J7dk/5C0Fn+uk+WFxv4S+uKiJHlMOCoXuP4CgSVmv6bhvSkEJtxTiRjuHf8P6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DugIAEO8wz+9N7stpvpHZjgbPI8Da8Odnv7k2YR3tuw=; b=RM8oJsiBQ/vlu2rQKVDIHmVcABM+cE6t2jgWeUI7Vg9NKjQmmbuwKxeqtI03E6MkzbLmt7r3s/OWk37DAVV84eBThdMhphi6U7qrqssqJBQdV96xVAtXjlSIsch6PpuYbkCNCDLqDhvsOokY5EWqSpUPWWwVQ/meWV9CyVbo5ghhkTo2rqH4+X/rQmMYT3t9KjJjx5ifwaOcZlVjDrLHpHrBo32SEqb1n6u4fFV9Fja4waflt0h20wdOnaAHhKL3j2pyfr/Th4OCsRqbfQq4mTVNdNhGYIK60AnzLriD+YS887nlojW79dx/T5fa2fue8VrNxNAuZY7vubyUeUe2NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DugIAEO8wz+9N7stpvpHZjgbPI8Da8Odnv7k2YR3tuw=; b=qod1W7XlU2MDhNcvhxuymFGhZ3Uz+ho1yWk+61H+ipXgMPGHplsEAO2oPKAxObuQpaGzHuSSFT8/aR/UIHZdRYuyi11XuVV58fEUT0KJBnCJ5zlGk7GaNXLaAbOJduSDzgS0tzF/ciD9aA42n+zNI79BC+d7Fj60e4x7hpmL5WU= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4415.eurprd04.prod.outlook.com (2603:10a6:803:74::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Mon, 12 Oct 2020 11:46:05 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3455.030; Mon, 12 Oct 2020 11:46:05 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Trahe, Fiona" , "ruifeng.wang@arm.com" , "michaelsh@marvell.com" Thread-Topic: [PATCH v2 3/5] cryptodev: remove crypto list end enumerators Thread-Index: AQHWl0/5e54F2jbF0U22Y+K8h/IfnamOKlRAgAVUd4CAAGwuEA== Date: Mon, 12 Oct 2020 11:46:04 +0000 Message-ID: References: <20200930173226.770-1-arkadiuszx.kusztal@intel.com> <20200930173226.770-4-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.180.231.103] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e053a86e-afb7-4630-490b-08d86ea466c6 x-ms-traffictypediagnostic: VI1PR04MB4415: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YZVETc+k+r4DsSdt8i2y6UkRks+nDLhkXTAs4o2I7h2vZqPdfK+tsYvNOAnrW64lbRPDizzrJ8LnPrWlNzjAkenwOWNld5PnZMLfq3YD0ZF7rcjYpgtNxEOWTF3Nu6DRZtzl0Nzl/empTWKGsr+H+nhFM9tlVnvd75are0P0ee1Rq5/oKUfcaqCEtda9TjnbzZYAnChNlDwxy3dbqTADI3VALJGySPp/2PJQuIgkYOjLHsrhNywGhKS/r/2K/f5bbYVUnCClFrGvPHKCoXgtgxhJVGQc9RkxgnNLV1vWprjr3ATkUIyjTgvCn6LzFbpRf5fM9jpK7McOG84cmGGeCw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(66556008)(64756008)(76116006)(44832011)(66476007)(316002)(55016002)(54906003)(66574015)(26005)(6506007)(478600001)(2906002)(66446008)(7696005)(71200400001)(52536014)(66946007)(53546011)(186003)(83380400001)(33656002)(110136005)(5660300002)(86362001)(9686003)(4326008)(8676002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: ciXnXgyZUbm+cLWOmFP0ZL4Ww1ZYstD5faVLB3vzsGv1f/U041khRGu4JMmM6U742QvCUPippjDq7C5HSGkhmLG8jsFcPH0PLdHNMU514sZ/Ln6XekR5mLx2jJwhFW5opbZXUCyJCUZzMuKX+TEp8r56DFxQYAO4gP0+31e/XmGCjq/KSnst36PkbDA98oOiE5XBDkN96TMJhCWi4GFxLtHubGVVb0BWnwrOiVzCWad9JWUdyeFbUc97abcD+u6XGjJNfxNXvIkQw6Bugnsa/ZazQIHBKSwyYjG7r6D/a6tcmfCGcOuLro14zQKHvbyfup/5Vs7/vCl5CYd0Kv/Spsa+uUKPc2UcGb3qJ/lpep9ga35nN6SGMdyp6IHnF+f9z2pJoF9kaRZ6/WxHe7Dyvn5Xh0SlTtuqIg1TYz6JEQOJPlEMclQ/536hs9QdgioS4EQU7iOuxP+O0E1DsJSC5WzlcrhyM7KE2/nugfunNqR9wrCp8qLlgPBMOmSgIfiP4rbvk9AsynqRLXDBSzO9k69tselqC1nQ/ka1CNHTRL3nP5or0UR9EZos+/Qf+zT8jgKD1y0+//Gj9WvYN7eVv/FKpdloUuUW1+6uVdE+3Ki7iUTP5uIVuIXIgHlSZMATOz/5O91wxmTHqHCXDIP5lA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e053a86e-afb7-4630-490b-08d86ea466c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2020 11:46:04.9498 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +dKAYxjfS2c6f3uhglZQ3fQ1p0P6VarVqfH9cRLl9gKfPHIlJBSsafyLKZs3VnitqeXxaKbzFA6v1NA/KDiGUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4415 Subject: Re: [dpdk-dev] [PATCH v2 3/5] cryptodev: remove crypto list end enumerators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Arek, > Hi Akhil, >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: czwartek, 8 pa=BCdziernika 2020 21:58 > > To: Kusztal, ArkadiuszX ; dev@dpdk.org > > Cc: Trahe, Fiona ; ruifeng.wang@arm.com; > > michaelsh@marvell.com > > Subject: RE: [PATCH v2 3/5] cryptodev: remove crypto list end enumerato= rs > > > > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > > > b/lib/librte_cryptodev/rte_crypto_sym.h > > > index f29c98051..7a2556a9e 100644 > > > --- a/lib/librte_cryptodev/rte_crypto_sym.h > > > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > > > @@ -132,15 +132,12 @@ enum rte_crypto_cipher_algorithm { > > > * for m_src and m_dst in the rte_crypto_sym_op must be NULL. > > > */ > > > > > > - RTE_CRYPTO_CIPHER_DES_DOCSISBPI, > > > + RTE_CRYPTO_CIPHER_DES_DOCSISBPI > > > /**< DES algorithm using modes required by > > > * DOCSIS Baseline Privacy Plus Spec. > > > * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next > > > * for m_src and m_dst in the rte_crypto_sym_op must be NULL. > > > */ > > > - > > > - RTE_CRYPTO_CIPHER_LIST_END > > > - > > > }; > > > > Probably we should add a comment for each of the enums that we change, > that > > the user can define its own LIST_END =3D last item in the enum +1. > > LIST_END is not added to avoid ABI breakage across releases when new al= gos > > are added. > [Arek] - I do not now if necessary, should it be some kind of guarantee t= hat > order and number of enumerators will not change across the releases? Yes we should make sure in the future that the order of enums are not chang= ed In future. This can be mentioned in the comments. We will be adding the new= algos In the end only. Please add a comment.