DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators
@ 2020-09-02 15:01 Arek Kusztal
  2020-09-02 15:11 ` Trahe, Fiona
  2020-09-10 18:57 ` Akhil Goyal
  0 siblings, 2 replies; 6+ messages in thread
From: Arek Kusztal @ 2020-09-02 15:01 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, fiona.trahe, Arek Kusztal

This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
some problems that may arise when adding new crypto algorithms.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/librte_cryptodev/rte_crypto_sym.h | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h
index f29c98051..7a2556a9e 100644
--- a/lib/librte_cryptodev/rte_crypto_sym.h
+++ b/lib/librte_cryptodev/rte_crypto_sym.h
@@ -132,15 +132,12 @@ enum rte_crypto_cipher_algorithm {
 	 * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
 	 */
 
-	RTE_CRYPTO_CIPHER_DES_DOCSISBPI,
+	RTE_CRYPTO_CIPHER_DES_DOCSISBPI
 	/**< DES algorithm using modes required by
 	 * DOCSIS Baseline Privacy Plus Spec.
 	 * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next
 	 * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
 	 */
-
-	RTE_CRYPTO_CIPHER_LIST_END
-
 };
 
 /** Cipher algorithm name strings */
@@ -312,10 +309,8 @@ enum rte_crypto_auth_algorithm {
 	/**< HMAC using 384 bit SHA3 algorithm. */
 	RTE_CRYPTO_AUTH_SHA3_512,
 	/**< 512 bit SHA3 algorithm. */
-	RTE_CRYPTO_AUTH_SHA3_512_HMAC,
+	RTE_CRYPTO_AUTH_SHA3_512_HMAC
 	/**< HMAC using 512 bit SHA3 algorithm. */
-
-	RTE_CRYPTO_AUTH_LIST_END
 };
 
 /** Authentication algorithm name strings */
@@ -412,9 +407,8 @@ enum rte_crypto_aead_algorithm {
 	/**< AES algorithm in CCM mode. */
 	RTE_CRYPTO_AEAD_AES_GCM,
 	/**< AES algorithm in GCM mode. */
-	RTE_CRYPTO_AEAD_CHACHA20_POLY1305,
+	RTE_CRYPTO_AEAD_CHACHA20_POLY1305
 	/**< Chacha20 cipher with poly1305 authenticator */
-	RTE_CRYPTO_AEAD_LIST_END
 };
 
 /** AEAD algorithm name strings */
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators
  2020-09-02 15:01 [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators Arek Kusztal
@ 2020-09-02 15:11 ` Trahe, Fiona
  2020-09-10 18:57 ` Akhil Goyal
  1 sibling, 0 replies; 6+ messages in thread
From: Trahe, Fiona @ 2020-09-02 15:11 UTC (permalink / raw)
  To: Kusztal, ArkadiuszX, dev; +Cc: akhil.goyal



> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Wednesday, September 2, 2020 4:02 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] cryptodev: remove crypto list end enumerators
> 
> This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> some problems that may arise when adding new crypto algorithms.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators
  2020-09-02 15:01 [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators Arek Kusztal
  2020-09-02 15:11 ` Trahe, Fiona
@ 2020-09-10 18:57 ` Akhil Goyal
  2020-09-11  5:14   ` Kusztal, ArkadiuszX
  1 sibling, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2020-09-10 18:57 UTC (permalink / raw)
  To: Arek Kusztal, dev; +Cc: fiona.trahe

Hi Arek,

> This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> some problems that may arise when adding new crypto algorithms.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---

There is a deprecation notice to remove these enums.
You should remove that.
Please have a single series for removal of all LIST END including the Asym crypto.

And I can see that these **LIST_END are getting used in some of the crypto PMDs.
Please remove all those references and cc changes to the respective PMD maintainer.

Regards,
Akhil

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators
  2020-09-10 18:57 ` Akhil Goyal
@ 2020-09-11  5:14   ` Kusztal, ArkadiuszX
  2020-09-11  6:10     ` Akhil Goyal
  0 siblings, 1 reply; 6+ messages in thread
From: Kusztal, ArkadiuszX @ 2020-09-11  5:14 UTC (permalink / raw)
  To: Akhil Goyal, dev; +Cc: Trahe, Fiona

HI Akhil,

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: czwartek, 10 września 2020 20:57
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH] cryptodev: remove crypto list end enumerators
> 
> Hi Arek,
> 
> > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> some
> > problems that may arise when adding new crypto algorithms.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> 
> There is a deprecation notice to remove these enums.
> You should remove that.
> Please have a single series for removal of all LIST END including the Asym crypto.

Reason that I have removed LIST_ENDs separately from symmetric and asymmetric is that asymmetric
API Is experimental so it did not need notice, but if really needed I can combine it into one patch in v2.

> 
> And I can see that these **LIST_END are getting used in some of the crypto
> PMDs.
> Please remove all those references and cc changes to the respective PMD
> maintainer.

I have informed "off the list" maintainers of PMDs that are using LIST_ENDS about this patch, so they should be sending patches soon, but if needed I can do it too in v2.


> 
> Regards,
> Akhil

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators
  2020-09-11  5:14   ` Kusztal, ArkadiuszX
@ 2020-09-11  6:10     ` Akhil Goyal
  2020-09-11  6:13       ` Kusztal, ArkadiuszX
  0 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2020-09-11  6:10 UTC (permalink / raw)
  To: Kusztal, ArkadiuszX, dev; +Cc: Trahe, Fiona

Hi Arek,
> 
> HI Akhil,
> 
> > > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> > some
> > > problems that may arise when adding new crypto algorithms.
> > >
> > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > ---
> >
> > There is a deprecation notice to remove these enums.
> > You should remove that.
> > Please have a single series for removal of all LIST END including the Asym
> crypto.
> 
> Reason that I have removed LIST_ENDs separately from symmetric and
> asymmetric is that asymmetric
> API Is experimental so it did not need notice, but if really needed I can combine
> it into one patch in v2.
> 
I was talking about a series of patches. Different patches in a series.

> >
> > And I can see that these **LIST_END are getting used in some of the crypto
> > PMDs.
> > Please remove all those references and cc changes to the respective PMD
> > maintainer.
> 
> I have informed "off the list" maintainers of PMDs that are using LIST_ENDS
> about this patch, so they should be sending patches soon, but if needed I can do
> it too in v2.
> 
You can add them in your v2 and cc maintainers.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators
  2020-09-11  6:10     ` Akhil Goyal
@ 2020-09-11  6:13       ` Kusztal, ArkadiuszX
  0 siblings, 0 replies; 6+ messages in thread
From: Kusztal, ArkadiuszX @ 2020-09-11  6:13 UTC (permalink / raw)
  To: Akhil Goyal, dev; +Cc: Trahe, Fiona



> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: piątek, 11 września 2020 08:10
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH] cryptodev: remove crypto list end enumerators
> 
> Hi Arek,
> >
> > HI Akhil,
> >
> > > > This patch removes enumerators RTE_CRYPTO_CIPHER_LIST_END,
> > > > RTE_CRYPTO_AUTH_LIST_END, RTE_CRYPTO_AEAD_LIST_END to prevent
> > > some
> > > > problems that may arise when adding new crypto algorithms.
> > > >
> > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > > ---
> > >
> > > There is a deprecation notice to remove these enums.
> > > You should remove that.
> > > Please have a single series for removal of all LIST END including
> > > the Asym
> > crypto.
> >
> > Reason that I have removed LIST_ENDs separately from symmetric and
> > asymmetric is that asymmetric API Is experimental so it did not need
> > notice, but if really needed I can combine it into one patch in v2.
> >
> I was talking about a series of patches. Different patches in a series.
Ah, I got it now, no problem.
> 
> > >
> > > And I can see that these **LIST_END are getting used in some of the
> > > crypto PMDs.
> > > Please remove all those references and cc changes to the respective
> > > PMD maintainer.
> >
> > I have informed "off the list" maintainers of PMDs that are using
> > LIST_ENDS about this patch, so they should be sending patches soon,
> > but if needed I can do it too in v2.
> >
> You can add them in your v2 and cc maintainers.



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-11  6:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 15:01 [dpdk-dev] [PATCH] cryptodev: remove crypto list end enumerators Arek Kusztal
2020-09-02 15:11 ` Trahe, Fiona
2020-09-10 18:57 ` Akhil Goyal
2020-09-11  5:14   ` Kusztal, ArkadiuszX
2020-09-11  6:10     ` Akhil Goyal
2020-09-11  6:13       ` Kusztal, ArkadiuszX

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git