From: Akhil Goyal <akhil.goyal@nxp.com>
To: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] test/crypto: add AES-256 DOCSIS test vectors
Date: Mon, 11 May 2020 13:10:42 +0000 [thread overview]
Message-ID: <VI1PR04MB316845807E301AB71470F5A4E6A10@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200511101916.22850-2-mairtin.oloingsigh@intel.com>
Hi Mairtin,
I believe your patch is not rebased on top of current tree. There is no pmd_mask now.
Also, I see that the AES 256 cases are already there. This patch is already there I guess.
> static const uint8_t
> cipher_aescbc_offset_16[] = {
> 0x57, 0x68, 0x61, 0x74, 0x20, 0x61, 0x20, 0x6C,
> @@ -2637,5 +2734,84 @@ static const struct blockcipher_test_case
> aes_docsis_test_cases[] = {
> .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> BLOCKCIPHER_TEST_TARGET_PMD_MB
> },
> + /* AES 256 */
> + {
> + .test_descr = "AES-256-DOCSIS-BPI Full Block Encryption",
> + .test_data = &aes_test_data_docsis_4,
> + .op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI Runt Block Encryption",
> + .test_data = &aes_test_data_docsis_5,
> + .op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI Uneven Encryption",
> + .test_data = &aes_test_data_docsis_6,
> + .op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI Full Block Decryption",
> + .test_data = &aes_test_data_docsis_4,
> + .op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI Runt Block Decryption",
> + .test_data = &aes_test_data_docsis_5,
> + .op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI Uneven Decryption",
> + .test_data = &aes_test_data_docsis_6,
> + .op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI OOP Full Block Encryption",
> + .test_data = &aes_test_data_docsis_4,
> + .op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
> + .feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI OOP Runt Block Encryption",
> + .test_data = &aes_test_data_docsis_5,
> + .op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
> + .feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI OOP Uneven Block
> Encryption",
> + .test_data = &aes_test_data_docsis_6,
> + .op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
> + .feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI OOP Full Block Decryption",
> + .test_data = &aes_test_data_docsis_4,
> + .op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
> + .feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI OOP Runt Block Decryption",
> + .test_data = &aes_test_data_docsis_5,
> + .op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
> + .feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> + {
> + .test_descr = "AES-256-DOCSIS-BPI OOP Uneven Block
> Decryption",
> + .test_data = &aes_test_data_docsis_6,
> + .op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
> + .feature_mask = BLOCKCIPHER_TEST_FEATURE_OOP,
> + .pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_QAT
> + },
> };
> #endif /* TEST_CRYPTODEV_AES_TEST_VECTORS_H_ */
> --
> 2.12.3
next prev parent reply other threads:[~2020-05-11 13:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 9:04 [dpdk-dev] [PATCH v2 1/2] crypto/qat: support DOCSIS AES-256 Mairtin o Loingsigh
2020-02-26 9:04 ` [dpdk-dev] [PATCH v2 2/2] test/crypto: Add AES-256 DOCSIS test vectors Mairtin o Loingsigh
2020-02-26 10:42 ` Trahe, Fiona
2020-02-26 10:41 ` [dpdk-dev] [PATCH v2 1/2] crypto/qat: support DOCSIS AES-256 Trahe, Fiona
2020-03-25 19:10 ` Akhil Goyal
2020-05-11 10:19 ` [dpdk-dev] [PATCH v3] " Mairtin o Loingsigh
2020-05-11 10:19 ` [dpdk-dev] [PATCH v3] test/crypto: add AES-256 DOCSIS test vectors Mairtin o Loingsigh
2020-05-11 13:10 ` Akhil Goyal [this message]
2020-05-11 10:19 ` [dpdk-dev] [PATCH v3] doc: QAT support for AES-256 DOCSIS Mairtin o Loingsigh
2020-05-11 13:12 ` Akhil Goyal
2020-05-11 13:14 ` [dpdk-dev] [PATCH v3] crypto/qat: support DOCSIS AES-256 Akhil Goyal
2020-05-11 14:03 ` O'loingsigh, Mairtin
2020-05-11 16:14 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB316845807E301AB71470F5A4E6A10@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=mairtin.oloingsigh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).