From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
Anoob Joseph <anoobj@marvell.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: Narayana Prasad <pathreya@marvell.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors
Date: Tue, 12 May 2020 13:19:10 +0000 [thread overview]
Message-ID: <VI1PR04MB316849450D05FEC4F900C352E6BE0@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <BY5PR11MB3910E745055F34294247A26CEDBE0@BY5PR11MB3910.namprd11.prod.outlook.com>
Hi Adam,
>
> Hi Anoob.
>
> What's wrong with this test? Is this unit test failing on any PMD now?
> I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G,
> SCHEDULER) and it passes everywhere. Then why should we remove it
> completely?
>
The problem is not with the valid cases. It is the negative cases which will cause issue
On most of the hardware PMDs which do not use qp_conf and simply ignore the values set in qp_conf.
So it actually does not matter whether you set valid or invalid value for those PMDs
I believe negative test should not be there for parameters which are optional to be used.
And IMO the patch is fine.
Regards,
Akhil
next prev parent reply other threads:[~2020-05-12 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 7:12 Anoob Joseph
2020-05-12 13:07 ` Dybkowski, AdamX
2020-05-12 13:19 ` Akhil Goyal [this message]
2020-05-12 13:26 ` Anoob Joseph
2020-05-13 8:33 ` Dybkowski, AdamX
2020-05-15 18:09 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB316849450D05FEC4F900C352E6BE0@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=adamx.dybkowski@intel.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreya@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).