From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7631A04A2; Tue, 12 May 2020 15:19:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95CD51BFA2; Tue, 12 May 2020 15:19:13 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74]) by dpdk.org (Postfix) with ESMTP id 4219A1BF3C for ; Tue, 12 May 2020 15:19:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IwQ0WlF9vgQQhXQvIvKvlXczNcKlOx6VUeQCYZcuDsgD1AJ6BJWWzOPWlD+xn1grfo1wKpZEv+/hEPUZWPF6P/yB+H0QiOn1Pfj3z/M+QRnsv2SFaf+pH0TDwi6t4Q+lyy0EMrje1i8NvwZ63tmI2LZNfO6FO9oX5DF5AUAMPYJKpNaGtKC+Z4ymIdA0MwXvcvFcKW6jYbBM9OEhNw3Jlo4Cy9W5fJAhP8Mx6rXCFgIoXwQh/mZ0JYtkOBrRqLnMPx4uldNSU9vfdyRsvXl2M57Kf5BLo4C1NFPQng3tSwA2Lyjfns1C+3JxuqLFxLb+X3pMQBNRkiGkuG0FZAR4RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ds4mf85IjNXsnlHVVu4lyezjq1VBwttXy+WSeGbChoQ=; b=Uj+kkWUOloovspBOUXYsG1HruaGn2qMacAjXbgeGDDO3QQSiTTHOhgnHHjEK6Ttk3LzZJD897uJPFsfCeuVPL/SLanmEpGVu1e2fzU36ZyzGINy7Y48N2L1Ubwj5YnROxeQP1u/fbZwqNA61y6mDk5t4+MomHk/sXqcugrtf4OzwRE3VosUyuwJNdBNY2cHCTePLBCO55IFTJWPGvr+xUhQqI/vRwRxcG/hBn8M51sDS7EK5cjr03DdCUvwgMAmidjfSwcvR8lqLg/fgFtW2Iif594ujlu0Vid4Wsh8vwaq4YcKOpp37BNobHNC+SNWZ6jkDc5EWUKuX4OKio8+9Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ds4mf85IjNXsnlHVVu4lyezjq1VBwttXy+WSeGbChoQ=; b=kzQITpYdvOZHENhlectPsMFPwNQobtCKs42B+M3SyAYxOSxISIogTwIiZewdHy1TXSSqbtVxKK0OeeLTFjXJB4l5xoGytOmUs66jUGRweqxMXWAFhDBo6Ty+tJ9IYHNp0toravui3/y8v7PQz/4mL0V4cv8MKY5ywIXt/8079NE= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB5887.eurprd04.prod.outlook.com (2603:10a6:803:e8::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Tue, 12 May 2020 13:19:10 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2979.033; Tue, 12 May 2020 13:19:10 +0000 From: Akhil Goyal To: "Dybkowski, AdamX" , Anoob Joseph , "Doherty, Declan" CC: Narayana Prasad , Ankur Dwivedi , "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors Thread-Index: AQHWKF5H09wME3909EueJXWKcKYmAaikbhLQ Date: Tue, 12 May 2020 13:19:10 +0000 Message-ID: References: <1589267544-18134-1-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.84] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2f616c93-cf55-428c-7999-08d7f6770ecb x-ms-traffictypediagnostic: VI1PR04MB5887: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lwLEtF6aU8urD4VyntYm0R5DHxq7YcF0HIrq+puFixqFo3TGAt39Eck3vtd3FXLMKr4KLtZmPj08IqTtnMMDmNfHBUT+FHxCezFwGiT8CUILX8wJWz5jvO1xmZZsZy6YDvokBF6nD+AL6VkgkfVvgKl8ExdhP9GVgJtivP+a8QIeSbSRfN1Ebl9Mc4jNgdgazVMpA3uzWI8/JvVpxxWpYubBPPAOVieejXke7gH2DLdj1yz4L9nU+kRhZrmjntqUPIl/hm2oGJS1zsCAZUUEUuXBVGVB8+r/kQp1Jn/6ATYlKDW+5tsS+4s9FpQQqZhr8/WBnwG7a2DRKxoTsZh/RHvHkaShxb29F2TI1AlSdRh+ymdGgCuM619cF2FkvMlI3/hsOIBU3cCS3QUXjcSmBaHF9xJj/jiMwW5DCiSmoou91DDnfO5GuubT21zl62Ty1PEdohRaQzcqRq3t0LJD3gccN8XCBkCtWEMEoZIScNw1lyQIVa1gfiJ3+DEHjlqAr4Do0Uu8Ev4LwNM6mI25EQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(33430700001)(66556008)(498600001)(66946007)(64756008)(4326008)(7696005)(33656002)(110136005)(4744005)(8936002)(86362001)(54906003)(26005)(33440700001)(66446008)(5660300002)(9686003)(71200400001)(2906002)(6506007)(55016002)(52536014)(186003)(44832011)(66476007)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: dLQ4B6/sAoUfElrU4TBtVgerG90JfoUEOzaFI4zwU5NmbgaNtgtwk/Z3TaPTooe3Et3CkHdT4X3eDO4LpCv/2qnO4x7G/+OKr6gSlq5xR9U9Pjd2Gh5PFFPIhiY461zhVeaqXW7OSga68o6sb9WSyHXe0tWzPpGechVLOSe6WtaKo+mbSkNPohmaV21UN8oGwmdpYi6UcVhfIbRLmy0Ipp5xi2t4JeVrfkLzhxrTlpvCyrvqBNBvqwJu0F5bJGqxeuykjJXDnv/8hvRUEPITDXHXmkkDNf3QEQfY8EvtOVa6nHO3xcexMnqDJnDbXjh15XyuNMUJ6pMlOTIF6y9HDOETokPlJcOZxNQpinViPmcnCSV+CeIIEDhmEe1c5Nnv8yx98hWbxhSJaqktEzNHmmDJEckrOf5Lqe8cqkzTO8BvxS+uxhbjevHo33Zdsdthn2xuRe2JMQFqt11GuE12gFkt0+H7sMnU9efi5/AE5Os= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f616c93-cf55-428c-7999-08d7f6770ecb X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 13:19:10.4462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: idzdRAo24jOZcvkab1O0V82NJQms52Ex3Yecb9hQo+JkqHl6EABDYsCuWme1R4cEvTxeXzU4USFvMFzi4V5QCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5887 Subject: Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, >=20 > Hi Anoob. >=20 > What's wrong with this test? Is this unit test failing on any PMD now? > I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, > SCHEDULER) and it passes everywhere. Then why should we remove it > completely? >=20 The problem is not with the valid cases. It is the negative cases which wil= l cause issue On most of the hardware PMDs which do not use qp_conf and simply ignore the= values set in qp_conf. So it actually does not matter whether you set valid or invalid value for t= hose PMDs I believe negative test should not be there for parameters which are option= al to be used. And IMO the patch is fine. Regards, Akhil