From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A391A04DD; Wed, 28 Oct 2020 15:28:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0F9FCB07; Wed, 28 Oct 2020 15:28:46 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50079.outbound.protection.outlook.com [40.107.5.79]) by dpdk.org (Postfix) with ESMTP id 5C1A1CB04; Wed, 28 Oct 2020 15:28:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QA/e7zgv8CYEkDYXg0ZIUq86AnSSuQhHuFigXS0v5yQQFzPmfrOXZJEKFm6p+GXNKbRr/pCUMAdRTbHtKr+KpNcW0nYsHCcBRUN3WGRlG5Q5CQ/6HRZyxTPGZK6RMGKppB6feJnPayaHngfX8Dq9etdVcJ1h6E85VxucQcLj2p+uE/ow3CkggzuwLaAaZc+hmWNqirudTgCiRDY0P9Ac8q2NNaRR+mWfvAuGIwNALCsWl+OoTpx6JmusylMYR7wKMDcCWvKzAw70XRj3wqg5GZJgpKAhUm/7KEWKy5KIidQsTLYZ3zWjYo/6VzG2bbb+HUUreGm324zF6qrWfZF4zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8cyWjbj7hBnzhVBt4E1gsy1YBEV+oewm+7MwR0wCsi8=; b=O2DOjC0rYYYVTEHLW3ONFZOs7hJhP97OidUT/EVKUgAWufZ9RtPEpZk3ojmxcO3mZgnZRqb21mcFFgkP+LB1oNp7JbuQ252r8A/OJ6Xi6M9/B+4fPAJ6C40t4IzSFnvPwaOfXsPW+uJfR6haSL8WVSwwAErHg9G9DLngONrd9s644liJUWal2iI0j+vKjkvM2h/pR4mxS8EjTJOr+4nFvmKd4JwnDwLvhI1WqaR1M+qwloDzmdSnykzEFTOPEXKt9avFt7/y7O3BSb6KQlQ5Nze5Es6/ObkXUEhk/XkWLEO+n1abNC9nYokqwREtlGzuG7Iv3udbd4mR2ewuN+TdHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8cyWjbj7hBnzhVBt4E1gsy1YBEV+oewm+7MwR0wCsi8=; b=R9gZteGl5TdqLFC6qTtoP7jgOcfHjLm7oPE/b6qquVKwZdUwcxX+YcgqNLEoZrcADT2yhtfBiY8YiFvbFSO2KXS7e4yMcXamek5xJExpsAMaafycTP24DpoxIKLJi1YpaeE9fyy2P2N7e3A4OJ1rZNVz0i/20JHeH1XKHBEyhfA= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4415.eurprd04.prod.outlook.com (2603:10a6:803:74::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 28 Oct 2020 14:28:43 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3499.027; Wed, 28 Oct 2020 14:28:43 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "techboard@dpdk.org" CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8kYL4cZYB+DTUiYqx6FrV0786mrw8dwgADrLQCAAEzQgIAAGDkA Date: Wed, 28 Oct 2020 14:28:43 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [171.50.183.179] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4fc70c8a-9f86-45a1-def4-08d87b4dc5dc x-ms-traffictypediagnostic: VI1PR04MB4415: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 94gWsuI6pFK9jQu+fmi6MQxW3h+CqkS3xeIM5k2Ydahnf3jA5X58gwTRQZDrUIRnxelHj9zuqh3gXv9W67i07SBTNk/Zg7HCnSRgZojnkpaDbVlu4PLa39+IhnPlb6YPi+x242VhNk3mbxF1xaU1or/jjnNf+c+IfHJ1ikbjjW27UrL+qAj76/tgIf+RVIpNIj9ZNZpeuvq+C9tRHzrq2Kulv+5+RRBPrVBk7Wv1KfEIRtX94lkjRdTxt9h786bH/a3ZtO6wfkZLkLqIS+dhZr6eOA/L7yQvUhwB7gLy3jzieNN1RG3MmuodJxTboQ5LrDnRL5BgnB0YknHLrqgr7A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39850400004)(366004)(346002)(136003)(376002)(66946007)(44832011)(66476007)(66556008)(8676002)(83380400001)(26005)(7696005)(76116006)(52536014)(5660300002)(186003)(71200400001)(64756008)(478600001)(66446008)(86362001)(55016002)(9686003)(6506007)(33656002)(4326008)(54906003)(316002)(8936002)(110136005)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: SDMRo8I7wLCcyQMrdmX6MlvehKv4yrfICPMN+rQrI1mutri3TuUbQPG3RVshMBRfVdymLG9Lzac73uAeRGk/xByWLHs9SSeTjg0XnguFRE+m74nwsUnrbvBhzKzrcIpzCWo9WYs4edP7VqUsbJ44XzL8uWj28ol8DD/1pYLBVZgJR4+zDxm8OzV0tEjaFEfQ8rd1386uWaJcDJxvPjeCDiY+Tr0ujgAyA6C/BHaKX9Wdo5GF+MpaR/91aqXoUE2UM1LeetP8i5XaYO5iXFVTUp5+AKEWDyrf6PpX5kGBJMCv7SRJ3WvZuOBGPhn8ZsLqoFqFqQHurT/mRCY1bmMW0LPYLoZxfKy324AH8WILwLBPc4poDzVL7miITecJxmEPU5huWGXsWfz9N+3Kl0k5VRr28XE0XIoUtoZibYBxEDN/IY0ZAXFuO5Qd3jtVf+D4hFF7rgjBsvWxRSoKrOW71mpac3g8LmXAPyUg/5c5dBWjl0PCmFefFdaX8cWr+MFJZiRmcJd4b2Cm3n5ees1yRfzhPmQeSVA1qOskwhwMJYzK4r9QnVgPWsiK+IFv5eseRMKenf6jJ2zIpZvFoxI3NlIW+a/RaY841+zKh0iWMkT8HLO7D5SYhLjE4TrssIn9bnkpK5wRuBkPuWqa6Uu4jQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fc70c8a-9f86-45a1-def4-08d87b4dc5dc X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 14:28:43.4680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: huuQhGtf+oVczNY1mXkZlLfcp/mSXpq3Yvi0aXd6sgotDZxipRMecmIjBxIlwebL9ettkG0GmGF/1XoQ45zddw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4415 Subject: Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, > > > Hi Tech board members, > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > Could you please comment. > > > > > > > /** The data structure associated with each crypto device. */ str= uct > > > > rte_cryptodev { > > > > dequeue_pkt_burst_t dequeue_burst; > > > > @@ -867,6 +922,10 @@ struct rte_cryptodev { > > > > __extension__ > > > > uint8_t attached : 1; > > > > /**< Flag indicating the device is attached */ > > > > + > > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > > + /**< User application callback for pre enqueue processing */ > > > > + > > > > } __rte_cache_aligned; > > > > > > Here rte_cryptodevs is defined in stable API list in map file which i= s a pointer > > > To all rte_cryptodev and the above change is changing the size of the > structure. >=20 > While this patch adds new fields into rte_cryptodev structure, > it doesn't change the size of it. > struct rte_cryptodev is cache line aligned, so it's current size: > 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. > So for 64-bit we have 47B implicitly reserved, and for 32-bit we have 19B > reserved. > That's enough to add two pointers without changing size of this struct. >=20 The structure is cache aligned, and if the cache line size in 32Byte and th= e compilation is done on 64bit machine, then we will be left with 15Bytes which is not su= fficient for 2 pointers. Do we have such systems? Am I missing something? The reason I brought this into techboard is to have a consensus on such cha= nge As rte_cryptodev is a very popular and stable structure. Any changes to it = may Have impacts which one person cannot judge all use cases. > > > IMO, it seems an ABI breakage, but not sure. So wanted to double chec= k. > > > Now if it is an ABI breakage, then can we allow it? There was no depr= ecation > > > notice Prior to this release. >=20 > Yes, there was no deprecation note in advance. > Though I think the risk is minimal - size of the struct will remain uncha= nged (see > above). > My vote to let it in for 20.11. >=20 > > > Also I think if we are allowing the above change, then we should also= add > > > another Field for deq_cbs also for post crypto processing in this pat= ch only. >=20 > +1 for this. > I think it was already addressed in v5. >=20 > Konstantin