Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/caam_jr: fix caam sec era invalid issue

[Akhil Goyal <akhil.goyal@nxp.com>]

> 
> 19/10/2020 12:33, Akhil Goyal:
> > > Subject: [PATCH] crypto/caam_jr: fix caam sec era invalid issue
> > >
> > > of_init() should be called before using any of_* APIs to retrieve
> > > information from the device tree and if reading integer value
> > > that must be converted to cpu endianness before using.
> > >
> > > Fixes: 1d678de329ab ("crypto/caam_jr: add basic job ring routines")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> > > ---
> > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > Thomas,
> > Can you pick this in RC1 directly as this is fixing a critical issue in one platform
> of NXP?
> 
> It does not say what it fixes (or I am not able to understand).
> What is "era"?

ERA is the hardware block version for crypto. It may be different on each platform.
On one of the platform this value is not getting read properly.

Title and Description could be altered as below

crypto/caam_jr: fix device tree parsing for SEC_ERA

Previously, SEC_ERA was hardcoded and it was removed in [1].
Now when that hardcoded was removed, it is supposed to be
read from the device tree but it is not done correctly.
This patch calls a necessary API of_init() before using any
of_* APIs to retrieve information from the device tree and
if reading integer value that must be converted to cpu endianness
before using it.

[1] eef9e0412a84 ("drivers/crypto: fix build with -fno-common")
Fixes: 1d678de329ab ("crypto/caam_jr: add basic job ring routines")
Cc: stable@dpdk.org

Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>