From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31E4BA0350; Wed, 1 Jul 2020 23:07:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74F201D5C2; Wed, 1 Jul 2020 23:07:15 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20070.outbound.protection.outlook.com [40.107.2.70]) by dpdk.org (Postfix) with ESMTP id E53001D546 for ; Wed, 1 Jul 2020 23:07:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMa0fAD0WcNetsBLiERu8pJLWRhB6LVMi00LsyNv7AHsQPgEdgvNYo8CRRoXLlaSpHeS/9CjdkEaFfF9ruuXr/U46r/TQiFjPigWpxUFk7x172pj99SIorc0uNj+4otoDDZibsy08sfMhbCvXMrfXW53jEgTrKunmhpkBaA3mGs7xvt97MjEek7QI+u4wKWgMx3zQmgv5lhStulGmRLNoMuNifjxcDYmV9v2YusoB8x6J4aNuM66eCMpmF1Rn4t8VbFF+7Xz2FibEBU4qwSlcoj7Hl8JcEdbqah+yC6GFii62oMJwWS/m7pLyfsVdTHym+1MI1ML3foPzEurQqQXqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X8/sKkWQvxRYx3vI7vKdZC6bNrc1jLRK722Ub+M9HBY=; b=ZVheQ4bFCjYF8TD99OLbs7oP7+lAmponF0do8TFd3zVXOLBnR1BeElg08IpBRSQPDpkAax9+eOmbWacuhc32sk+mAPpZw1CrxEcSAKUd4FqW8nOwOGg7q2CUIRI7PZT5Gl4OTJ3Gl0nRc+y6Nd6JGCkdI5pvJCALy5kE1hOHVLCuzTJI3MWRfyGAZapb8xNfM36HxzTQ3Pji41qu/Cre39bk5bPy3yTFyPCDe/rtCBGx/fCCvK4ER0jna8k0IVfI5l9CONmoIb4ctebUhkR8fj004N4udqeKgaryo5J3O41n+x2WuCE3r49IxPc6yZpA937/0+Z/WWHBJnwnejnLSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X8/sKkWQvxRYx3vI7vKdZC6bNrc1jLRK722Ub+M9HBY=; b=WKIxKXllpqTwf22XdjMVgtGubsjr3I+Qnbg05KHjQicdvCJh6ERXVRlTbYbsP5d7j9vrqlN+MV6GQL4FW7SUWjpG15/3hFm/9i++yMUjGCq9aubKZHGQG4EBQBCGZKafv067sdB5ZGVxAvO7ka2DaGXrlUjvhf8y9wD00k5TSns= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4878.eurprd04.prod.outlook.com (2603:10a6:803:5b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.20; Wed, 1 Jul 2020 21:07:11 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3131.028; Wed, 1 Jul 2020 21:07:11 +0000 From: Akhil Goyal To: Tejasree Kondoj , Radu Nicolau CC: Narayana Prasad , Anoob Joseph , Vamsi Attunuru , "dev@dpdk.org" Thread-Topic: [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities Thread-Index: AQHWSVAlTVqjWHzGK0WL9/77Bl5Kh6jzQ4QQ Date: Wed, 1 Jul 2020 21:07:11 +0000 Message-ID: References: <20200623121228.10355-1-ktejasree@marvell.com> <20200623121228.10355-5-ktejasree@marvell.com> In-Reply-To: <20200623121228.10355-5-ktejasree@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.74] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 84448db8-8b22-4610-fa67-08d81e02b8df x-ms-traffictypediagnostic: VI1PR04MB4878: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U7flV9hCMd7T/Hw3fj2hZJsMvY5tVW5JErtO8vCp6yi4nUymkca2BzdFyKs+1db7qqlpvO1Cicof4zd9RLRanEKn+oOwsIrLNl0uoLFB10PL2Xdppg37qE0DtDU/sJWQVlcxOgWqs4659PzaUN6XaCLV2wc0PeqplQ8IKKn3rMNFntpGn+hBDE/4htXU6xU/fz/5Zr5LPICGKUdhRL6tiO/aMMb9pbl7R3SkEJNrrvIfcQ3gGWY/sZRsg5lMh/c/pG+2mlpNPzkUAZqm74CXlU7XPVOAiGJ3z4FdFe53OmomqhNS7mPIYIWjV0Ro0g8YJlZI+70ccpYpcSlNb8Fyuw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(44832011)(26005)(8676002)(2906002)(8936002)(33656002)(7696005)(186003)(5660300002)(4744005)(52536014)(83380400001)(71200400001)(76116006)(86362001)(6506007)(66946007)(66446008)(9686003)(54906003)(64756008)(66556008)(110136005)(4326008)(66476007)(55016002)(498600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: PwtPP9FHFZz949ijOBPmWPJ7/+EqakUcA1l4WGTCuKGbtny9IGMFSPPta/anl/DD+Jo3xQlz+hX75rMLA5b+P2bwod8HEk5rRf0QIPs8R0p0mm62Hj5se3f93BTEi6v5M4+XoSJ/6G/+32uvvsGCfU2L9c+OrbpScP8m2jo77nxGlzk/rrjZ3/tn3YrcNfz+EaD86RixU4PMicfyhVa3JETXADFfpPZYyezg86Sq1uJSpRIwq4T47h7rBZ/yp9LUYKNnNNP6LFWBrxM0wYoTRpA+H+1o/ZB9QMdJUsZnk8PG6NQOO/3Xo6sh5Uu1wDED9VXcoern9iDUq+GbFe/QN3y2syKJ5Omd8+N8HdUJ57p4HcGsdZgxBLJx7e9hGLIG540IRgt0s5hQslwlqsPz6XPqU8bhGTwVocvkViOQmGBCPXm3xorQwlazlEQnv7QwRbccdPHwNoGeo0eiLs7FPWkYCCZwmYqDyBa2VYumQHJjmDn37dYa7SYhprM79Z8x x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84448db8-8b22-4610-fa67-08d81e02b8df X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 21:07:11.1710 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TKsU7ENS2kjqlkdcUoYkjzRx+54R44yELT7Pc2boOIktkzkWeADUBc7RZqAtRqFMiwkaXAeae6uIa66aXp/1Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4878 Subject: Re: [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > +static const struct rte_cryptodev_capabilities * > +otx2_cpt_sec_caps_get(union cpt_eng_caps *hw_caps) > +{ > + SEC_CAPS_ADD(hw_caps, aes); > + > + sec_caps_add(caps_end, RTE_DIM(caps_end)); > + > + return otx2_cpt_sec_caps; > +} SEC_CAPS_ADD should be called earlier when the security context is created Or where all other capabilities of the PMD are initialized. It should not be added when capabilities need to be retrieved. As of now you are supporting only AES-GCM, but in future if you add more al= gos, Then it would be difficult to manage.