[dpdk-dev] [PATCH] common/qat: add missing kmod dependency

[dpdk-dev] [PATCH] common/qat: add missing kmod dependency

[Didier Pallard]

Dependency on kmod needed to manage crypto devices is missing
in qat crypto pmd.

Cc: stable@dpdk.org
Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")
Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
---
 drivers/common/qat/qat_device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index b050ce20e4fc..9fa142b5e5bb 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -423,3 +423,4 @@ qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)
 
 RTE_PMD_REGISTER_PCI(QAT_PCI_NAME, rte_qat_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(QAT_PCI_NAME, pci_id_qat_map);
+RTE_PMD_REGISTER_KMOD_DEP(QAT_PCI_NAME, "* igb_uio | uio_pci_generic | vfio-pci");
-- 
2.20.1

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/qat: add missing kmod dependency

[David Marchand]

Salut Didier,

On Fri, Oct 23, 2020 at 5:45 PM Didier Pallard <didier.pallard@6wind.com> wrote:
>
> Dependency on kmod needed to manage crypto devices is missing
> in qat crypto pmd.
>
> Cc: stable@dpdk.org
> Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")

The Fixes: tag goes first, then Cc:, then empty line.


> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> ---
>  drivers/common/qat/qat_device.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
> index b050ce20e4fc..9fa142b5e5bb 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -423,3 +423,4 @@ qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)
>
>  RTE_PMD_REGISTER_PCI(QAT_PCI_NAME, rte_qat_pmd);
>  RTE_PMD_REGISTER_PCI_TABLE(QAT_PCI_NAME, pci_id_qat_map);
> +RTE_PMD_REGISTER_KMOD_DEP(QAT_PCI_NAME, "* igb_uio | uio_pci_generic | vfio-pci");
> --
> 2.20.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>


There are some other drivers that have the issue.
If there is a volunteer, we have other drivers with the same issue
(but probably worth double checking):
$ git grep -l 'drv_flags = RTE_PCI_DRV_NEED_MAPPING' drivers/ |xargs
dirname |sort -u|while read dir; do dir=${dir%%/base}; git grep -q
RTE_PMD_REGISTER_KMOD_DEP $dir || echo $dir; done
drivers/baseband/acc100
drivers/baseband/fpga_5gnr_fec
drivers/baseband/fpga_lte_fec
drivers/common/qat # done
drivers/event/octeontx
drivers/event/skeleton
drivers/mempool/octeontx
drivers/net/avp
drivers/net/hinic
drivers/net/octeontx
drivers/regex/octeontx2


-- 
David Marchand

Re: [dpdk-dev] [dpdk-stable] [PATCH] common/qat: add missing kmod dependency

[Trahe, Fiona]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, October 23, 2020 5:32 PM
> To: Didier Pallard <didier.pallard@6wind.com>
> Cc: dev <dev@dpdk.org>; dpdk stable <stable@dpdk.org>; Griffin, John <john.griffin@intel.com>; Trahe,
> Fiona <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Olivier Matz
> <olivier.matz@6wind.com>; Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Subject: Re: [dpdk-stable] [PATCH] common/qat: add missing kmod dependency
> 
> Salut Didier,
> 
> On Fri, Oct 23, 2020 at 5:45 PM Didier Pallard <didier.pallard@6wind.com> wrote:
> >
> > Dependency on kmod needed to manage crypto devices is missing
> > in qat crypto pmd.
> >
> > Cc: stable@dpdk.org
> > Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")
> 
> The Fixes: tag goes first, then Cc:, then empty line.
> 
> 
> > Signed-off-by: Didier Pallard <didier.pallard@6wind.com>

Thanks!
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH] common/qat: add missing kmod dependency

[Akhil Goyal]

> Subject: [dpdk-dev] [PATCH] common/qat: add missing kmod dependency
> 
> Dependency on kmod needed to manage crypto devices is missing
> in qat crypto pmd.
> 
> Cc: stable@dpdk.org
> Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
Applied to dpdk-next-crypto

Thanks/