DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/octeontx2: fix crypto OOP support
@ 2020-10-23 15:50 Didier Pallard
  2020-10-26 18:39 ` Akhil Goyal
  2020-10-27 15:20 ` [dpdk-dev] [PATCH v2] " Didier Pallard
  0 siblings, 2 replies; 6+ messages in thread
From: Didier Pallard @ 2020-10-23 15:50 UTC (permalink / raw)
  To: dev; +Cc: stable, Ankur Dwivedi, Anoob Joseph, Akhil Goyal, Tejasree Kondoj

Out of place with linear buffers is supported by octeontx2
while not advertised.

Cc: stable@dpdk.org
Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
---
 drivers/crypto/octeontx2/otx2_cryptodev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c
index 02d2fd83bdcf..44da26c78d04 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev.c
+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
@@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 			     RTE_CRYPTODEV_FF_HW_ACCELERATED |
 			     RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
 			     RTE_CRYPTODEV_FF_IN_PLACE_SGL |
+			     RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
 			     RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
 			     RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
 			     RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO |
-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix crypto OOP support
  2020-10-23 15:50 [dpdk-dev] [PATCH] crypto/octeontx2: fix crypto OOP support Didier Pallard
@ 2020-10-26 18:39 ` Akhil Goyal
  2020-10-27 15:20 ` [dpdk-dev] [PATCH v2] " Didier Pallard
  1 sibling, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2020-10-26 18:39 UTC (permalink / raw)
  To: Didier Pallard, dev; +Cc: stable, Ankur Dwivedi, Anoob Joseph, Tejasree Kondoj

>Subject: [PATCH] crypto/octeontx2: fix crypto OOP support
> 
> Out of place with linear buffers is supported by octeontx2
> while not advertised.
> 
> Cc: stable@dpdk.org
> Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>

Cc below fixes line and then a blank line.
> ---
>  drivers/crypto/octeontx2/otx2_cryptodev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c
> b/drivers/crypto/octeontx2/otx2_cryptodev.c
> index 02d2fd83bdcf..44da26c78d04 100644
> --- a/drivers/crypto/octeontx2/otx2_cryptodev.c
> +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
> @@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
>  			     RTE_CRYPTODEV_FF_HW_ACCELERATED |
>  			     RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
>  			     RTE_CRYPTODEV_FF_IN_PLACE_SGL |
> +			     RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
>  			     RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
>  			     RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
>  			     RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO |

This feature flag is missing in the documentation of the PMD as well.
doc/guides/cryptodevs/features/octeontx2.ini

Same comment for http://patches.dpdk.org/patch/81947/


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH v2] crypto/octeontx2: fix crypto OOP support
  2020-10-23 15:50 [dpdk-dev] [PATCH] crypto/octeontx2: fix crypto OOP support Didier Pallard
  2020-10-26 18:39 ` Akhil Goyal
@ 2020-10-27 15:20 ` Didier Pallard
  2020-10-28 11:52   ` Akhil Goyal
  2020-10-29 14:38   ` [dpdk-dev] [EXT] " Ankur Dwivedi
  1 sibling, 2 replies; 6+ messages in thread
From: Didier Pallard @ 2020-10-27 15:20 UTC (permalink / raw)
  To: dev; +Cc: stable, Ankur Dwivedi, Anoob Joseph, Akhil Goyal, Tejasree Kondoj

Out of place with linear buffers is supported by octeontx2
while not advertised.

Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
Cc: stable@dpdk.org

Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
---
v2:
 * Add documentation.

 doc/guides/cryptodevs/features/octeontx2.ini | 1 +
 drivers/crypto/octeontx2/otx2_cryptodev.c    | 1 +
 2 files changed, 2 insertions(+)

diff --git a/doc/guides/cryptodevs/features/octeontx2.ini b/doc/guides/cryptodevs/features/octeontx2.ini
index c7e418d826e1..b0d50ce98447 100644
--- a/doc/guides/cryptodevs/features/octeontx2.ini
+++ b/doc/guides/cryptodevs/features/octeontx2.ini
@@ -12,6 +12,7 @@ Protocol offload       = Y
 In Place SGL           = Y
 OOP SGL In LB  Out     = Y
 OOP SGL In SGL Out     = Y
+OOP LB  In LB  Out     = Y
 RSA PRIV OP KEY QT     = Y
 Symmetric sessionless  = Y
 
diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c
index 02d2fd83bdcf..44da26c78d04 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev.c
+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
@@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 			     RTE_CRYPTODEV_FF_HW_ACCELERATED |
 			     RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
 			     RTE_CRYPTODEV_FF_IN_PLACE_SGL |
+			     RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
 			     RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
 			     RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
 			     RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO |
-- 
2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH v2] crypto/octeontx2: fix crypto OOP support
  2020-10-27 15:20 ` [dpdk-dev] [PATCH v2] " Didier Pallard
@ 2020-10-28 11:52   ` Akhil Goyal
  2020-10-29 14:38   ` [dpdk-dev] [EXT] " Ankur Dwivedi
  1 sibling, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2020-10-28 11:52 UTC (permalink / raw)
  To: Didier Pallard, dev; +Cc: stable, Ankur Dwivedi, Anoob Joseph, Tejasree Kondoj

Hi Ankur/Anoob,

> Subject: [PATCH v2] crypto/octeontx2: fix crypto OOP support
> 
> Out of place with linear buffers is supported by octeontx2
> while not advertised.
> 
> Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> ---

Could you please Ack both these otx and otx2 patches.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] crypto/octeontx2: fix crypto OOP support
  2020-10-27 15:20 ` [dpdk-dev] [PATCH v2] " Didier Pallard
  2020-10-28 11:52   ` Akhil Goyal
@ 2020-10-29 14:38   ` Ankur Dwivedi
  2020-10-29 14:52     ` Akhil Goyal
  1 sibling, 1 reply; 6+ messages in thread
From: Ankur Dwivedi @ 2020-10-29 14:38 UTC (permalink / raw)
  To: Didier Pallard, dev; +Cc: stable, Anoob Joseph, Akhil Goyal, Tejasree Kondoj



>-----Original Message-----
>From: Didier Pallard <didier.pallard@6wind.com>
>Sent: Tuesday, October 27, 2020 8:51 PM
>To: dev@dpdk.org
>Cc: stable@dpdk.org; Ankur Dwivedi <adwivedi@marvell.com>; Anoob Joseph
><anoobj@marvell.com>; Akhil Goyal <akhil.goyal@nxp.com>; Tejasree Kondoj
><ktejasree@marvell.com>
>Subject: [EXT] [PATCH v2] crypto/octeontx2: fix crypto OOP support
>
>External Email
>
>----------------------------------------------------------------------
>Out of place with linear buffers is supported by octeontx2 while not
>advertised.
>
>Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
>Cc: stable@dpdk.org
>
>Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
Acked-by: Ankur Dwivedi <adwivedi@marvell.com>
>---
>v2:
> * Add documentation.
>
> doc/guides/cryptodevs/features/octeontx2.ini | 1 +
> drivers/crypto/octeontx2/otx2_cryptodev.c    | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/doc/guides/cryptodevs/features/octeontx2.ini
>b/doc/guides/cryptodevs/features/octeontx2.ini
>index c7e418d826e1..b0d50ce98447 100644
>--- a/doc/guides/cryptodevs/features/octeontx2.ini
>+++ b/doc/guides/cryptodevs/features/octeontx2.ini
>@@ -12,6 +12,7 @@ Protocol offload       = Y
> In Place SGL           = Y
> OOP SGL In LB  Out     = Y
> OOP SGL In SGL Out     = Y
>+OOP LB  In LB  Out     = Y
> RSA PRIV OP KEY QT     = Y
> Symmetric sessionless  = Y
>
>diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c
>b/drivers/crypto/octeontx2/otx2_cryptodev.c
>index 02d2fd83bdcf..44da26c78d04 100644
>--- a/drivers/crypto/octeontx2/otx2_cryptodev.c
>+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
>@@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv
>__rte_unused,
> 			     RTE_CRYPTODEV_FF_HW_ACCELERATED |
> 			     RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING
>|
> 			     RTE_CRYPTODEV_FF_IN_PLACE_SGL |
>+			     RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
> 			     RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
> 			     RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
> 			     RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO |
>--
>2.20.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] crypto/octeontx2: fix crypto OOP support
  2020-10-29 14:38   ` [dpdk-dev] [EXT] " Ankur Dwivedi
@ 2020-10-29 14:52     ` Akhil Goyal
  0 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2020-10-29 14:52 UTC (permalink / raw)
  To: Ankur Dwivedi, Didier Pallard, dev; +Cc: stable, Anoob Joseph, Tejasree Kondoj

> >----------------------------------------------------------------------
> >Out of place with linear buffers is supported by octeontx2 while not
> >advertised.
> >
> >Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Acked-by: Ankur Dwivedi <adwivedi@marvell.com>
> >---
Applied to dpdk-next-crypto

Thanks.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-10-29 14:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-23 15:50 [dpdk-dev] [PATCH] crypto/octeontx2: fix crypto OOP support Didier Pallard
2020-10-26 18:39 ` Akhil Goyal
2020-10-27 15:20 ` [dpdk-dev] [PATCH v2] " Didier Pallard
2020-10-28 11:52   ` Akhil Goyal
2020-10-29 14:38   ` [dpdk-dev] [EXT] " Ankur Dwivedi
2020-10-29 14:52     ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git