From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B067A04BC; Thu, 8 Oct 2020 21:58:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D37D91B690; Thu, 8 Oct 2020 21:58:09 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74]) by dpdk.org (Postfix) with ESMTP id 4C25E1B68A for ; Thu, 8 Oct 2020 21:58:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CW/h+/go/cJuySKzAK2AvdZvK3ushtM/42x64sNL2u5Y0HI8yiQL3cE+jDzEPp0MVaGuTK4lUnKmoNuTMgMJwaa5m+PoCpvQLnK0TneAhGVrrRbmO7NQ/sVlCDSwX812je4O1k4+cBZvxwD4BHY2THvbV5kcvkjE9weo+pO+1s2WVzZPH/VdQUE23Dy0CJdijqCfhQVGr0+lHkZhmDSPkGSolaIKuVhLVAhBqoUUINJfRxVe6/W+8DRu/2BUjt8/rNbRr3OtEZq5C46odrAk+3gn6CfrNcrv7/BNIgH3X636DpCmaMcrldSQV85yXnafBTfbIThD5kHTSHDufw2P/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=webmImOrcoqi2bwgSBsdAivPAapUYGrLQGqRjOY/i64=; b=hr+ZpCvbTbmkd2GIo8lRT057ajSJ7PL+WR4Rdxvy5IlleG2RhS6YVmB2z9BUVmF6bhn1Ggyi3+FeINQi1BU5S6sBqEjOK0x1zoHwkEktSZHbsnrLAbcNc49hnkHvi8CbPiyszOXpudmRxdlhiug5begDinZtijx9GdNiMGxFHPe0MYLf9gSfoQNs+6mAnt5b5RDSLH17NTm6z/1iQfs1mdF5LdFX0eG/8vNFhea9qibbc8tIrY5eoMju1T4ZqOX2kxdbK1Q0V0Us2dHFpCcNuT4NCEGteM+k746mLDy5XdXN2ehUyQxIPWKSmhsMwptAFCimSROy0QjliIcgjqIW6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=webmImOrcoqi2bwgSBsdAivPAapUYGrLQGqRjOY/i64=; b=B6AslgnBxAPN3J2jv7dzFHFpN+0hKu+oQeYuyWdcBtXniYZ4uwT8Oc3cycQZ1vO4cxzf4wMrZSxnhVPg4GbQMOdMxB0kmuTbQcx5/F1tdERUhdeicA2sjYQbXo+nHK20CbJKLuCcM9K/C4jWEMju5Ic/Yg8NBbtmt7sJBscE3T4= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4799.eurprd04.prod.outlook.com (2603:10a6:803:55::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.24; Thu, 8 Oct 2020 19:58:05 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::9513:3b55:931f:216e%4]) with mapi id 15.20.3433.045; Thu, 8 Oct 2020 19:58:05 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "fiona.trahe@intel.com" , "ruifeng.wang@arm.com" , "michaelsh@marvell.com" Thread-Topic: [PATCH v2 3/5] cryptodev: remove crypto list end enumerators Thread-Index: AQHWl0/5e54F2jbF0U22Y+K8h/IfnamOKlRA Date: Thu, 8 Oct 2020 19:58:05 +0000 Message-ID: References: <20200930173226.770-1-arkadiuszx.kusztal@intel.com> <20200930173226.770-4-arkadiuszx.kusztal@intel.com> In-Reply-To: <20200930173226.770-4-arkadiuszx.kusztal@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [122.180.231.103] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b2395472-4860-4c9f-c441-08d86bc47894 x-ms-traffictypediagnostic: VI1PR04MB4799: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g3Ix4TiylwdI6PngC9fg7zVqm9+/rfGhUI5o97CZRdj4DxuTnIUllrUV/+oN/ntmBE1NxdkeewBv5BkuAx4L1Ck0A84Mwz5zuCi/yHsHyjPpvXVtMIH9xXJb0sPDTVlT/DsqjtE4qMrzriWrrvXie4bJqKjQtpiIEDgZK/81tEqJA0rXbGrgfFVGlr2X5blFFslsMKO0tkduZoGsxTd4mROOqCoTnqXFVagZ/ksZK2D0BV+jI0qZoqEDQWyHvpHVcNQ7ebWfSrVRZKsCftayrMTPa7ZhNXtYZPPTWkl0g9MztqzVyBhLI2NE/WAsIsWf7ckPbeN3wsboNSSMXqSkdw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(71200400001)(66946007)(316002)(76116006)(66476007)(9686003)(54906003)(110136005)(2906002)(52536014)(64756008)(66446008)(66556008)(8936002)(478600001)(8676002)(33656002)(86362001)(6506007)(5660300002)(44832011)(55016002)(186003)(26005)(4326008)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: LLQlk4yZHHYhZnxWU3Mkn546O/Lrm7GAUNXUIhINH3xtwBr4FUPMzQ2JhzDZp2ApwbLqiWJSY24AH+elwWimF4jUxMLMSWxF3BmapukwmP+sStSKWIDPFR6mVpYzAHZpuwCf2mIVCXxwA3OWONtJCHju1jDSCDvTQoot8acZcjDPNrxr0rq39b4CyZjpwhWX6x21Wm9BWCseMt+vSCR7iPz0BOYG9kSJfDTGTw/JB2C+E8NDq5PzpSS9zcI1SGhGMXUFVrEE9iuMVdnDESSr78SybaxaNaSZOWBscNfBHJkwfYcEbWyAhucSfUwy4js7efSa3I7r4yPwEbAXT3gGwA87AgJr/xEkowoBf4Kqqg0AOnga3K46DZ5Ti2+4IyClWneHXcaB6KRCyIndDxxt+AOfjD409bEq/RexMuf6yTvdJudcVUNpVzfq1HEF/flwpE1xbk1hLYkaeN5KKUTLQXgv11P39PwjoYVVrvjGinUblDSh9unqcKw6FcSaqLv1mYm11IJ6jGXqjbWKS0WK5d3pM2ZoCGeOpZCvm73ikUHc4Yr4z3itztVKQTVUau6IgmcqWctrfGpGgKTOgl9vieXZv5/FEiGbvXGofLzXZF3yaxlkwS+l1cClCCzIZZ4KWLY6FwG4rAi3yIzSBqqLdQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2395472-4860-4c9f-c441-08d86bc47894 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 19:58:05.2053 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qE0MSQPJ1yP87OReEMudey0EABEuRrbjpNpWZD+yk1yGr97zEnIdxKn6VQvV5+YCKaBD+mzM/w2TuPTvjxClew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4799 Subject: Re: [dpdk-dev] [PATCH v2 3/5] cryptodev: remove crypto list end enumerators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > b/lib/librte_cryptodev/rte_crypto_sym.h > index f29c98051..7a2556a9e 100644 > --- a/lib/librte_cryptodev/rte_crypto_sym.h > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > @@ -132,15 +132,12 @@ enum rte_crypto_cipher_algorithm { > * for m_src and m_dst in the rte_crypto_sym_op must be NULL. > */ >=20 > - RTE_CRYPTO_CIPHER_DES_DOCSISBPI, > + RTE_CRYPTO_CIPHER_DES_DOCSISBPI > /**< DES algorithm using modes required by > * DOCSIS Baseline Privacy Plus Spec. > * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next > * for m_src and m_dst in the rte_crypto_sym_op must be NULL. > */ > - > - RTE_CRYPTO_CIPHER_LIST_END > - > }; Probably we should add a comment for each of the enums that we change, that the user can define its own LIST_END =3D last item in the enum +1. LIST_END is not added to avoid ABI breakage across releases when new algos are added. >=20 > /** Cipher algorithm name strings */ > @@ -312,10 +309,8 @@ enum rte_crypto_auth_algorithm { > /**< HMAC using 384 bit SHA3 algorithm. */ > RTE_CRYPTO_AUTH_SHA3_512, > /**< 512 bit SHA3 algorithm. */ > - RTE_CRYPTO_AUTH_SHA3_512_HMAC, > + RTE_CRYPTO_AUTH_SHA3_512_HMAC > /**< HMAC using 512 bit SHA3 algorithm. */ > - > - RTE_CRYPTO_AUTH_LIST_END > }; >=20 > /** Authentication algorithm name strings */ > @@ -412,9 +407,8 @@ enum rte_crypto_aead_algorithm { > /**< AES algorithm in CCM mode. */ > RTE_CRYPTO_AEAD_AES_GCM, > /**< AES algorithm in GCM mode. */ > - RTE_CRYPTO_AEAD_CHACHA20_POLY1305, > + RTE_CRYPTO_AEAD_CHACHA20_POLY1305 > /**< Chacha20 cipher with poly1305 authenticator */ > - RTE_CRYPTO_AEAD_LIST_END > }; >=20 > /** AEAD algorithm name strings */ > -- > 2.17.1