From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14FFDA00C5; Thu, 2 Jul 2020 12:41:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACC341D8DD; Thu, 2 Jul 2020 12:41:01 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by dpdk.org (Postfix) with ESMTP id BD9721D73D for ; Thu, 2 Jul 2020 12:40:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hj6XE4fIqjgGRWc7QkX52FdQ2uXh1Rmmnf37yqJfea9hVc5aB0VvUehR/gbiLzallNDC23vPUnrrYlccJsojs8OhbJ4LlzyKKK2FMvqxv5tOPb/velLHFei3SStraDWbjDtnJfe2I3LKo8XtG3UJmOGz3rNvGaSYV6AGF0yY/2lkv5iGv8FXMWbGA5O8CX9BF4tQkLjtXWCPNnsKOq8wunEKC7LiPZlYp4U63NyvbQUNafQ5tbLE+27reYLmQESQbDARFmgCpRbHGTZme2FBFHd3TBYbBKdHUve5pxX3nvdc+f0jMA7MYxCj5YLghyVehp0/StgCkz1krwaRIAmymg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wq6cXKk4qRn+gw/ayQwgjftrnHyR4ygDpvfGx+aeOHg=; b=imAMoGiCXzDpED2qltP791/7R1F5M1L8EsahU3tu/xl9GE5HKdOKQnNcagrjmAYs3gV9znpwHbpViLkahpTN0A6p7Ei7a6a1dEcpaM93cskmEs/zZNFo2zA3Y+T+EDmYvB+4cOCdk1e8RyPMl2bRsegJ+49FxBWoq0vfkSUSUKWfpZZZmr6saGuEtdEy/35GJsPH1mpJbsNO4SIVKKB66oMlTU4EvwJMZ7ONCGT1hy+0OSmplFyPJF9hYpideAofiCTZ6QeSPzsrgh3WavlludMGGxWmkNkKlleKdVCUcERej5/+O79AJv2MFz1Qchs37RyZkskSaPEG6cejifrHOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wq6cXKk4qRn+gw/ayQwgjftrnHyR4ygDpvfGx+aeOHg=; b=l3CyfsjLyR21YSlC/C14rtVc7MuM46ZFUt/2C0TEq0Mbg9AzM0RBtjiRlpmuHuwY23jYGXfXTUYA9J8ooTF/wB9tIOlciuezwHMslp8IKFwYFXMw44tRwHZql10UR8Tz6BZh5P6ghNnTLsy0W7HmqJlWkxxsYAI9ZnOI//H8v1Y= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB3165.eurprd04.prod.outlook.com (2603:10a6:802:a::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Thu, 2 Jul 2020 10:40:58 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::b077:1fe4:d352:b464%7]) with mapi id 15.20.3131.035; Thu, 2 Jul 2020 10:40:58 +0000 From: Akhil Goyal To: Anoob Joseph , Tejasree Kondoj , Radu Nicolau CC: Narayana Prasad Raju Athreya , Vamsi Krishna Attunuru , "dev@dpdk.org" Thread-Topic: [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions Thread-Index: AQHWSVAflpqhO/VqCU+m/j7Km89dBajzPLYAgADXQQCAAAG+IIAABsmAgAAKnFA= Date: Thu, 2 Jul 2020 10:40:58 +0000 Message-ID: References: <20200623121228.10355-1-ktejasree@marvell.com> <20200623121228.10355-3-ktejasree@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.91] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 46fb43ea-9e0f-42ba-7023-08d81e74684a x-ms-traffictypediagnostic: VI1PR04MB3165: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DQ8D9K4awBQZktYhGQhM7q6hWRnkBfSJsX2bV7yKAzH3Hsub7vFwZlHUEHXDtxMDNjnFVnhedLL3HJcEpsMopNFrcsv9mzblIL2V7Q5Fyr34+baXxwdmIQw+eB+TDCS32duu8FhziA3YgVhMWqD95V8mKTOjRJOCtYwCOH5fDZWNCeQK7SmfP+jHqYi4YyhJ5HFYy+kZ++1McbHdd6L7r69pJwA/U3O8MWEstLFOQkk8rcNeEwEeveIvJdDJqNe0Ay63jgBbQq1pe6SSJhEHeDUYmEQQ75wTgNW22Yd2mvWhoclNTnofYtBeJRek9YHCnNIYojVKjFB3JOgrbDgIFA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(54906003)(26005)(44832011)(186003)(316002)(7696005)(110136005)(86362001)(2906002)(52536014)(6506007)(5660300002)(83380400001)(4326008)(71200400001)(478600001)(8676002)(8936002)(66446008)(33656002)(66946007)(66476007)(66556008)(64756008)(76116006)(9686003)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: KsozUc8/KztPJB9/bmJ2KmDDGGgitod3javwz68uDZnVcDRS6Fsvdf3x6EN7h1hDMAOklahEczTH87raqufGYnHSLzLXcolPs6SvJHPKe+bdn/srf7pLvyqJN2bBbgOBUlAXDYf0LSKr0NJAwrXeskq/J/vd+hHbt4Gtvn/T+pE91KxOSXQW2+IVOZeLNeGvCKwep6RxqiAp7TbAw4333k+poTGXSwftPT/9FyETC1NONY2pBYcQYCu9uOdjjz/HC24ReWX5xIUipuAphbq9qUDTVZpVviQyFak9Ttc3PIK+dwDHknBXBX2JyYe5ShGbuwHKOr2iGh+Vd9Cgimm0afjQHSBEt5pGnSfheRDu2+uqIqyF33wmzIfjgcYN14t9Mx8EF4WkHg/x5R1GNrgX65y00qNbQWMo/O4Dic2rOivciFukKafbBnMOUkWCaBRb5+4t9nH4SEhsI4FIv8Ff+KjLGzEcviH2Aw54LWgBD745eydLXiaf0AtejOXka3rc x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3168.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46fb43ea-9e0f-42ba-7023-08d81e74684a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 10:40:58.5145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lTiWp0+6YH/jOtG93LCyxWDbe5EommlXN4PqOurdU/XnKDpzMZp7unrhI93VvvCFL2Xk7eV7eWq8wNutgUo1kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3165 Subject: Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > ---------------------------------------------------------------------- > > > > > +#include "otx2_ipsec_po.h" > > > > Why is it named like this? What is 'po' ? > > > > > > [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for > > > inline and one for lookaside. The one for inline is FP and the one fo= r > > > lookaside is PO (Protocol Offload). > > > > > Isn't it better to write "inline" in place of "fp" and "offload" in pla= ce of "po"? > > > > Fp and po looks very cryptic. >=20 > [Anoob] Yes. But since it is firmware specific, these need to be added fo= r all > structures etc. And these opcodes can be used interchangeably as well (as= in PO > opcode can be used for inline and FP opcodes can be used for lookaside, b= ut > both with certain limitations). Hence we have tried to separate it out th= is way. > Larger names would mean longer function names and structure names etc. We > tried few other names as well, but then it was conflicting with other opc= odes. I > do agree that it is slightly cryptic, but we have tried to use the names > consistently to avoid confusions. >=20 I think you can use the opcode as fp and po but the function/file names sho= uld be readable. However, it is internal to PMD, I don't have a strong opinion on this but i= t would be good if Names can be made readable. Regards, Akhil