From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 648BAA0350; Mon, 11 May 2020 12:05:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42F1F1C20D; Mon, 11 May 2020 12:05:24 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140072.outbound.protection.outlook.com [40.107.14.72]) by dpdk.org (Postfix) with ESMTP id EFA8B1C1F9 for ; Mon, 11 May 2020 12:05:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e4790d9Mg6TNSHH/YrwkfCWT6QuL1rT+OQ+EPDshD1Cm583Fpar0BAPfwoShjgTF2mfzD/L16klwwEPnM3r94SBFDFFzhq2PopiK6M6LZyykH8UMFxqOrTEw4hL3LmX85YvU8DB2QLeFLX6ufQzK/+6NshZhUrb5aRlh4L6hmR8QK66ZQGYTGP1mTGLXNJV7pFvWUWr4db7TIG7qHntGOfpmJbhbQe0FYIkHId5U5Pu6lJcM2y3spkXZesb2OPGO5QPV9TovfEcKH5s4lb5Si3BFoGk8TV9zyKVcVpi7Fa9rys0yMpBZj+fMAw51nHdDa79+ibeQmDwQwIbnHCMyJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhUaoEnuBhGMm9DMIHuqnls96RQPtBOt7wpSWMsgE2A=; b=jKigToxW8bek7WBK81HgqyZkiZENo815kFPuMQhS0FkCKXifO8Mf5A4PyNp9ND9NJcxbezTVf3ps+h4KvX/k1jOT/uraXtiUAh9sr3KC0iUlol1Zsi2Ua6xnuIdrtz74DrQSk+AYHL13w8jzZrHQ3v0XdEecuhdbvakdd2LeNmMMxQ7l3Fj5+5OxNw9+DY6I380P2zeXe3sOOPhrr/yxBDvMUGegGdzPh2t1obRXDhrxkYIFriNRLgnBNzd3cVqteTBGH5+3TeNMbyNuLgT2lZJSShKMR9vwmlCmSaWkRoGkFq2M2R4wH1ex/p4wd/IRMA3COpwtj3/3gqH7pVYlbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhUaoEnuBhGMm9DMIHuqnls96RQPtBOt7wpSWMsgE2A=; b=NKJcCORIkyDwC/BPA64Yy9mgMiBggSC5SZOcgMNZg0ELTcOtMvtUSlWcRb1mIGfbnQdpH9MdMRnAOZ9lvFRd86lepi9X0VzyQYDris3yRsi5ncyRkrvP6C59XA2wrp8Nb7eSEE7kC4pei2kAdnKnSrQCWhZnTLdSPYj8NpzSsys= Received: from VI1PR04MB3168.eurprd04.prod.outlook.com (2603:10a6:802:6::10) by VI1PR04MB4160.eurprd04.prod.outlook.com (2603:10a6:803:41::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Mon, 11 May 2020 10:05:22 +0000 Received: from VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74]) by VI1PR04MB3168.eurprd04.prod.outlook.com ([fe80::8c03:2f5:3b48:ba74%7]) with mapi id 15.20.2979.033; Mon, 11 May 2020 10:05:22 +0000 From: Akhil Goyal To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Ruifeng.Wang@arm.com" , "Doherty, Declan" , "asomalap@amd.com" , "anoobj@marvell.com" , "Zhang, Roy Fan" , "Trahe, Fiona" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , Gagandeep Singh , Hemant Agrawal , "jianjay.zhou@huawei.com" , "Dybkowski, AdamX" , Apeksha Gupta Thread-Topic: [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data Thread-Index: AQHWJlpLOQwt3hkHDUyeUmyzdH/p9aiip7kAgAABtaA= Date: Mon, 11 May 2020 10:05:22 +0000 Message-ID: References: <20200504215811.15951-1-akhil.goyal@nxp.com> <20200509231217.8219-1-akhil.goyal@nxp.com> <20200509231217.8219-2-akhil.goyal@nxp.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.118.167.80] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e7d8475f-b319-4687-c093-08d7f592d146 x-ms-traffictypediagnostic: VI1PR04MB4160:|VI1PR04MB4160: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FVSRSPM4yNh2/EcmX2bTlObEdXwhpWJzIegUFyX8Ib1dyVTIaBI19sZyohXAML5noJ5gATPd5kviUqto8tBj//KR75AoP8bOlhVclOLwrCpAFNp+CqsXWqG2mo9rhUyFB7O0AUxPOo8X/P/S3P85fAhB2RwUAnGNXtArp51VKJNoTk/x4pAdJdYrPdrJNjWhaKZddEObracyqv7lOoIK/XOup5rdzmHkf6va7EFXEZTssN0jAg0MzlgHkKGf7dB0O2oyII7HzQHFYbW5yTA9z9jKtnF+nfgRTJYjGhrOxnr9p7Q+7soSFU41sPPEavVrn6+WvppiWdbB6cmeuZO/BlufQ5lmBxYh2sr3aIBHYS0rGbpIpGTDWdddTk3o/O+9FlghLVjhJZrHCOZc5Ezq6XzrJV507k+Vw87IY0WnNGfkHUOnzqeaL933m1For8OjC7t5a8cU3yLf7bfjvD87V377Ckub6hdk2xzdxiHKFskY+meIYagoMJL8i7mzK8H1+Y4nSpiinRz8COpDAAGgVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3168.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(33430700001)(478600001)(66446008)(66556008)(66476007)(33656002)(110136005)(55016002)(66946007)(5660300002)(64756008)(54906003)(44832011)(76116006)(86362001)(8676002)(52536014)(26005)(7696005)(316002)(9686003)(4326008)(7416002)(186003)(71200400001)(6506007)(2906002)(33440700001)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: WaykQamyP3yicajKSZomtm/di9kUzP0nFf3DI5rzcxuzTpQwyCr3QuBDKhYlyY+RE732a2Q5LsY6vbMz8EHYPlrz8X1WNHJEFI7q8Nub9DfxD2KBXcJxH0GTE+lLSdxcJVwfVX3TiBN4ok5R50taZMtcdbTUVZCpr52Vgo0qLKlDmVDlbJCAIJjHga//NiM1XwYGGk5elFsKgSDKrit0ZT3EF39mqQhGolioUwTOSPKxGYxckFXTaWr6fpMe+lJa17RF4cTrRSK/IzJK6hNko9sWN3fmAFsfaFHqiC5k2s9eN2e6dVBquPeXxhqw0q9tVA1JLL3Z4pXBvPi4UqXHQtDLW4/zIJrccaoFQjAg1d6CHG3U1IWLKd/XY+bPILDNxErCArEH4DkGCAhnz+biFNMf8H+52XzhXgLPKFzK7sAKPJ8vVZwVJ5OOfWciLRlIUmrIsnzV9pLkaP6hBy17ySO45pwCSO+gHI91IV7j8ZFAfKw7YVsBfT+Dp3rlFAxc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7d8475f-b319-4687-c093-08d7f592d146 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 10:05:22.0570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vwn2aOU+F7kUksvOTx6vtNIZ2yDIakV66BAiFpTScmSaiRC4VH5Lj2Tj+CPeEKbWqpBZh/k59Bdy14xY7Pj4TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4160 Subject: Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo, >=20 > Hi Akhil, >=20 > > > > Some wireless algos like SNOW, ZUC may support input data in bits which= are > > not byte aligned. However, not all PMDs can support this requirement. H= ence > > added a new feature flag RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA > > to identify which all PMDs can support non-byte aligned data. > > > > Signed-off-by: Akhil Goyal > > Acked-by: Fiona Trahe >=20 > On these PMDs, some of these algorithms do not support non byte aligned d= ata. > For instance, for ZUC, the cipher algorithm doesn't support length in bit= s, > but the authentication algorithm does. > All test pass because in the tests we are doing encryption in bytes and t= hen we > mask off > the bits not used. > Wonder if we need two different flags for this, one for cipher and anothe= r one > for authentication. > Maybe again this is not enough, since we should have a flag per algorithm= ... and > starting with this flag is a step forward. > What do you think? IMO, supporting non-byte-aligned data is a feature as a whole, but we shoul= d not have Per algo basis. It will be better if we come up with something in the capab= ility as we do For validating the key sizes etc. We should only have a single flag in feature flag list. Or none if we have = a solution which Is generic in capability. What do you say? However for now I am applying this series as this is the solution that we h= ave right now. We can fix the ZUC issue in probably next release cycle. Regards, Akhil